Re: [transcode-users] [patch] using posix versions of __s32 and others

[achurch@xxxxxxxxxxx (Andrew Church)]

>I'm subscribed to transcode-devel and transcode-users for about a month now 
>and have not yet seen a mail in transcode-devel, so I post this here on 
>transcode-users. Please tell me, if this was wrong.

     This should go to transcode-devel (it's been seeing activity, so make
sure you have the right address subscribed and your filters aren't throwing
it away), but I'll reply here for thread consistency.

>On PowerPC64 you cannot define __s32 and such definitions without risking to 
>redefine them, because they are already defined in linux kernel headers. The 
>correct way would be using posix versions like int32_t and such.

     And as a matter of fact, we have been using int32_t and the like
throughout transcode for newly-written code.  Unfortunately, transcode
includes a lot of (1) old, poorly-written code and (2) code dependent on
external libraries which also use __s8 and the like; for (1) we're fixing
them as we get to them (please be patient), but for (2) we prefer to use
the same style/types as the external libraries, even if incorrect, in order
to avoid potential incompatibilities.  So this is not a patch we would
consider applying at this time.

  --Andrew Church
    achurch@xxxxxxxxxxx
    http://achurch.org/