From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 01:06:55 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 24861126D84 for ; Sun, 1 Oct 2006 01:06:55 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 745ED3B032; Sun, 1 Oct 2006 01:06:42 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 3D25D3B02C for ; Sun, 1 Oct 2006 01:06:40 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 12082-04 for ; Sun, 1 Oct 2006 01:06:40 +0200 (CEST) Received: from mail3.sea5.speakeasy.net (mail3.sea5.speakeasy.net [69.17.117.5]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 4203E3B025 for ; Sun, 1 Oct 2006 01:06:38 +0200 (CEST) Received: (qmail 30629 invoked from network); 30 Sep 2006 23:06:39 -0000 Received: from shell2.sea5.speakeasy.net ([69.17.116.3]) (envelope-sender ) by mail3.sea5.speakeasy.net (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for ; 30 Sep 2006 23:06:39 -0000 Date: Sat, 30 Sep 2006 16:06:39 -0700 (PDT) From: Trent Piepho X-X-Sender: xyzzy@shell2.speakeasy.net To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] Analyzing benchmark results (was Re: Compile options) In-Reply-To: <1159621596.11221.27.camel@symbol.nonexistent.fi> Message-ID: References: <450AFBAC.1080901@cute.se> <200609192034.47382.Bircoph@list.ru> <200609202122.14964.Bircoph@list.ru> <1159023001.1901.16.camel@symbol.nonexistent.fi> <20060923150024.GA9922@biurrun.de> <1159621596.11221.27.camel@symbol.nonexistent.fi> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="289735540-2128198275-1159657599=:31858" X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --289735540-2128198275-1159657599=:31858 Content-Type: TEXT/PLAIN; charset=US-ASCII On Sat, 30 Sep 2006, Uoti Urpala wrote: > On Mon, 2006-09-25 at 07:07 -0700, Trent Piepho wrote: > > On Sat, 23 Sep 2006, Diego Biurrun wrote: > > > On Sat, Sep 23, 2006 at 05:50:01PM +0300, Uoti Urpala wrote: > > > > On Sat, 2006-09-23 at 07:17 -0700, Trent Piepho wrote: > > > > > Mean and sample standard deviation for each optimization level, 10 samples per test. > > > > > > > > I think minimum would be a more appropriate value than mean, as the > > > > decoding should be mostly deterministic and larger times represent > > > > interference from other processes. > > > > > > I was about to say something similar. > > > > > > What's wrong with taking - say - the best of x runs? The process is > > > supposed to be deterministic ... > > > > If that was a good idea, there would be popular statistical tests based on > > it. However, if there is any merit to the concept of comparing extrema, it > > is not something I was taught. Quite the opposite really; how to keep > > extrema from producing a result that isn't justified. > > In this case there cannot be far outlier values on the "too small" side > unless your testing method is broken. On the other hand there most Think of the measured values as being the true value plus some random error term. This random error may be always positive and not have a mean of zero. That doesn't matter. Some tests require that the resulting data have a normal distribution (Student's t), some don't (Wilcoxon rank-sum). > likely are errors which are not independent between tests and affect a > different portion of tests for each case. Since the tested value itself Why would the errors not be independent between tests? And if it wasn't, there would be some auto-correlation between tests, would there not? I'll attache the H.264 data, tell me where the auto-correlation is. I didn't see any. > is supposed to be (almost) deterministic, using minimum is more robust: There are plenty of other testing applications when the true value of the variable being measured doesn't change between samples, and any errors are the result of measurment error. Benchmarking a computer program isn't some kind of unique scenerio that requires one to throw out the previous century of statistical thought. Can you find any literature that suggests that using minimum or maximum is a better test? > getting one single "good enough" sample means the test gives the right How do you decide when you have the magic sample that you will use while throwing all other data out? > > It looks like noif_dsp is the best, with a minimum of 12.703 vs 12.764. Of > > course, we have no idea what the confidence level is for that value. > > That's one of the reason why "best of x" isn't a valid method. It just > > "Not a valid method" in what sense? If you claim that for any testing > method it always gives worse results you're wrong. It's easy to set up > an example test case (distribution of right values and possible errors) > where you can mathematically prove that minimum gives better results > than mean; if you understand this stuff at all you should be able to do > that yourself. Why don't you? What are the instances when "best of x", where x is some number you came up with before hand, is mathmatically better than established tests such as Student's t test or Wilcoxon Rank-Sum? It seems that if "best of x" was a good idea, at least for some real scenario, there would be papers published on it and references to the test. I didn't find any. Do you know of any? > > Now noif_dsp is best again with 12.628. First we get one answer, then the > > other, and then the original again! If I did another 10 runs, what would > > be the best then? How does one qualify the result, that after X runs this > > is best, but after X+1 maybe it will be totally different? It seems that > > the conclusion from Student's t test, that there is no significant > > difference, is the right one. Looking at the minimum is trying to find an > > answer that isn't there. > > This argument is nonsense. If the values are close then which one has > the smaller mean can also keep changing. Whether the difference is > significant is another question. You seem to set up an idiotic strawman It isn't another question, it is _the_ question. Does the data support a conclusion that there is a difference between two populations? It's the classic question of hypothesis testing. > argument saying that any difference in the minimums would have to be > interpreted as a significant difference. So, how does one decide if the difference in minimums is significant? You take the minimum of the two samples and then what? --289735540-2128198275-1159657599=:31858 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=h264 Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=h264 ICAgICAgICAgICAgICAgICAgICB2YyAgICB2byAgIHN5cyAgIHVzZXIgZWxh cHNlZCAgICAgICAgdHlwZSBkc3BpbiByZXN0aW4gT2xldmVsDQpPMi4xICAg ICAgICAgICAxMzMuOTAxIDAuMDI4IDAuNzg2IDEzNC41MSAgMTM1LjUwICAg ICAgICAgIE8yIEZBTFNFICBGQUxTRSAgICAgIDINCk8yLjIgICAgICAgICAg IDEzMS45MDggMC4wMzAgMC43ODAgMTMyLjYxICAxMzMuMTkgICAgICAgICAg TzIgRkFMU0UgIEZBTFNFICAgICAgMg0KTzIuMyAgICAgICAgICAgMTMxLjQx NSAwLjAyOSAwLjc4MiAxMzIuMTUgIDEzMi4zMCAgICAgICAgICBPMiBGQUxT RSAgRkFMU0UgICAgICAyDQpPMi40ICAgICAgICAgICAxMzEuNTQ3IDAuMDI5 IDAuNzgwIDEzMi4yOSAgMTMyLjQzICAgICAgICAgIE8yIEZBTFNFICBGQUxT RSAgICAgIDINCk8yLjUgICAgICAgICAgIDEzMS4yNTggMC4wMjkgMC43Nzcg MTMxLjk4ICAxMzIuNTMgICAgICAgICAgTzIgRkFMU0UgIEZBTFNFICAgICAg Mg0KTzIuNiAgICAgICAgICAgMTMzLjA5MCAwLjAyOCAwLjc4NCAxMzMuODEg IDEzMy45NyAgICAgICAgICBPMiBGQUxTRSAgRkFMU0UgICAgICAyDQpPMi43 ICAgICAgICAgICAxMzMuMjIxIDAuMDI5IDAuNzc5IDEzMy45NCAgMTM0LjEw ICAgICAgICAgIE8yIEZBTFNFICBGQUxTRSAgICAgIDINCk8yLjggICAgICAg ICAgIDEzMy44MzkgMC4wMjkgMC43ODcgMTM0LjU3ICAxMzQuNzMgICAgICAg ICAgTzIgRkFMU0UgIEZBTFNFICAgICAgMg0KTzIuOSAgICAgICAgICAgMTMx LjA2NiAwLjAyOCAwLjc3OSAxMzEuNzggIDEzMi4zNCAgICAgICAgICBPMiBG QUxTRSAgRkFMU0UgICAgICAyDQpPMi4xMCAgICAgICAgICAxMzMuNjcyIDAu MDI5IDAuNzgyIDEzNC40MiAgMTM0Ljk1ICAgICAgICAgIE8yIEZBTFNFICBG QUxTRSAgICAgIDINCk8yLmlmX2RzcC4xICAgIDEzOC40MTMgMC4wMjcgMC43 ODMgMTM5LjAzICAxMzkuNTYgICBPMi5pZl9kc3AgIFRSVUUgIEZBTFNFICAg ICAgMg0KTzIuaWZfZHNwLjIgICAgMTM4LjQ4MSAwLjAyOCAwLjc3OCAxMzku MjAgIDEzOS4zNiAgIE8yLmlmX2RzcCAgVFJVRSAgRkFMU0UgICAgICAyDQpP Mi5pZl9kc3AuMyAgICAxMzguNjMzIDAuMDMwIDAuNzg0IDEzOS4zNSAgMTM5 LjUyICAgTzIuaWZfZHNwICBUUlVFICBGQUxTRSAgICAgIDINCk8yLmlmX2Rz cC40ICAgIDEzOS44OTkgMC4wMjkgMC43OTEgMTQwLjYyICAxNDAuNzkgICBP Mi5pZl9kc3AgIFRSVUUgIEZBTFNFICAgICAgMg0KTzIuaWZfZHNwLjUgICAg MTQwLjU1MyAwLjAzMCAwLjc5MyAxNDEuMjcgIDE0MS40NCAgIE8yLmlmX2Rz cCAgVFJVRSAgRkFMU0UgICAgICAyDQpPMi5pZl9kc3AuNiAgICAxMzcuMzAw IDAuMDI4IDAuNzcyIDEzOC4wMCAgMTM4LjU3ICAgTzIuaWZfZHNwICBUUlVF ICBGQUxTRSAgICAgIDINCk8yLmlmX2RzcC43ICAgIDEzOS43NTcgMC4wMjkg MC43ODggMTQwLjQ5ICAxNDAuNjUgICBPMi5pZl9kc3AgIFRSVUUgIEZBTFNF ICAgICAgMg0KTzIuaWZfZHNwLjggICAgMTM3Ljg3MCAwLjAyOSAwLjc4MCAx MzguNjAgIDEzOS4xNSAgIE8yLmlmX2RzcCAgVFJVRSAgRkFMU0UgICAgICAy DQpPMi5pZl9kc3AuOSAgICAxMzguNzA3IDAuMDI5IDAuNzc5IDEzOS40MiAg MTM5LjU5ICAgTzIuaWZfZHNwICBUUlVFICBGQUxTRSAgICAgIDINCk8yLmlm X2RzcC4xMCAgIDEzOC4xNjMgMC4wMjkgMC43NzkgMTM4Ljg2ICAxMzkuMDQg ICBPMi5pZl9kc3AgIFRSVUUgIEZBTFNFICAgICAgMg0KTzIuaWZfYWxsLjEg ICAgMTM5LjM5OCAwLjAzMCAwLjc4MCAxNDAuMDAgIDE0MC41NyAgIE8yLmlm X2FsbCAgVFJVRSAgIFRSVUUgICAgICAyDQpPMi5pZl9hbGwuMiAgICAxMzku NzQwIDAuMDI4IDAuNzcxIDE0MC40MiAgMTQwLjYxICAgTzIuaWZfYWxsICBU UlVFICAgVFJVRSAgICAgIDINCk8yLmlmX2FsbC4zICAgIDE0MC4xNDAgMC4w MjggMC43NzUgMTQwLjg0ICAxNDEuMDEgICBPMi5pZl9hbGwgIFRSVUUgICBU UlVFICAgICAgMg0KTzIuaWZfYWxsLjQgICAgMTM4LjE5OCAwLjAyNyAwLjc3 MCAxMzguODkgIDEzOS4wNiAgIE8yLmlmX2FsbCAgVFJVRSAgIFRSVUUgICAg ICAyDQpPMi5pZl9hbGwuNSAgICAxMzcuODkyIDAuMDI4IDAuNzcwIDEzOC42 MSAgMTM5LjE2ICAgTzIuaWZfYWxsICBUUlVFICAgVFJVRSAgICAgIDINCk8y LmlmX2FsbC42ICAgIDE0Mi4zNjQgMC4wMzAgMC43ODkgMTQzLjA0ICAxNDMu MjYgICBPMi5pZl9hbGwgIFRSVUUgICBUUlVFICAgICAgMg0KTzIuaWZfYWxs LjcgICAgMTM3LjgyOCAwLjAyNiAwLjc2MCAxMzguNTQgIDEzOS4wOCAgIE8y LmlmX2FsbCAgVFJVRSAgIFRSVUUgICAgICAyDQpPMi5pZl9hbGwuOCAgICAx MzguNTE5IDAuMDI2IDAuNzYzIDEzOS4yMSAgMTM5Ljc4ICAgTzIuaWZfYWxs ICBUUlVFICAgVFJVRSAgICAgIDINCk8yLmlmX2FsbC45ICAgIDEzNy4yOTIg MC4wMjYgMC43NjQgMTM3Ljk4ICAxMzguNTUgICBPMi5pZl9hbGwgIFRSVUUg ICBUUlVFICAgICAgMg0KTzIuaWZfYWxsLjEwICAgMTM3LjI4NSAwLjAyNiAw Ljc2MSAxMzguMDAgIDEzOC41NCAgIE8yLmlmX2FsbCAgVFJVRSAgIFRSVUUg ICAgICAyDQpPNC5ub2lmX2FsbC4xICAxMzEuMDY4IDAuMDMwIDAuNzg4IDEz MS42NyAgMTMyLjYyIE80Lm5vaWZfYWxsIEZBTFNFICBGQUxTRSAgICAgIDQN Ck80Lm5vaWZfYWxsLjIgIDEzMS4xNTMgMC4wMjggMC43NzYgMTMxLjg3ICAx MzIuMDMgTzQubm9pZl9hbGwgRkFMU0UgIEZBTFNFICAgICAgNA0KTzQubm9p Zl9hbGwuMyAgMTMxLjM0OSAwLjAyOSAwLjc3OCAxMzIuMDYgIDEzMi4yMyBP NC5ub2lmX2FsbCBGQUxTRSAgRkFMU0UgICAgICA0DQpPNC5ub2lmX2FsbC40 ICAxMzEuNDA3IDAuMDI5IDAuNzc2IDEzMi4xNCAgMTMyLjI4IE80Lm5vaWZf YWxsIEZBTFNFICBGQUxTRSAgICAgIDQNCk80Lm5vaWZfYWxsLjUgIDEzMC45 OTcgMC4wMjggMC43NzcgMTMxLjcxICAxMzEuODcgTzQubm9pZl9hbGwgRkFM U0UgIEZBTFNFICAgICAgNA0KTzQubm9pZl9hbGwuNiAgMTMwLjE3NiAwLjAy OSAwLjc4MSAxMzAuODkgIDEzMS4wNiBPNC5ub2lmX2FsbCBGQUxTRSAgRkFM U0UgICAgICA0DQpPNC5ub2lmX2FsbC43ICAxMzAuMDkyIDAuMDI5IDAuNzgw IDEzMC44MSAgMTMwLjk3IE80Lm5vaWZfYWxsIEZBTFNFICBGQUxTRSAgICAg IDQNCk80Lm5vaWZfYWxsLjggIDEyOS45MjggMC4wMjkgMC43ODEgMTMwLjYw ICAxMzEuMjAgTzQubm9pZl9hbGwgRkFMU0UgIEZBTFNFICAgICAgNA0KTzQu bm9pZl9hbGwuOSAgMTMwLjk1MSAwLjAyOSAwLjc3MiAxMzEuNjUgIDEzMS44 MyBPNC5ub2lmX2FsbCBGQUxTRSAgRkFMU0UgICAgICA0DQpPNC5ub2lmX2Fs bC4xMCAxMzEuMTA0IDAuMDMwIDAuNzgzIDEzMS44MCAgMTMxLjk5IE80Lm5v aWZfYWxsIEZBTFNFICBGQUxTRSAgICAgIDQNCk80Lm5vaWZfZHNwLjEgIDEz MC4yODcgMC4wMjkgMC43NzUgMTMwLjk5ICAxMzEuMTYgTzQubm9pZl9kc3Ag RkFMU0UgICBUUlVFICAgICAgNA0KTzQubm9pZl9kc3AuMiAgMTMzLjEzMiAw LjAzMCAwLjc4OSAxMzMuODYgIDEzNC4wMiBPNC5ub2lmX2RzcCBGQUxTRSAg IFRSVUUgICAgICA0DQpPNC5ub2lmX2RzcC4zICAxMzMuMTQ0IDAuMDMwIDAu Nzg1IDEzMy44NiAgMTM0LjQzIE80Lm5vaWZfZHNwIEZBTFNFICAgVFJVRSAg ICAgIDQNCk80Lm5vaWZfZHNwLjQgIDEyOC41OTkgMC4wMjcgMC43NTMgMTI5 LjI5ICAxMjkuODUgTzQubm9pZl9kc3AgRkFMU0UgICBUUlVFICAgICAgNA0K TzQubm9pZl9kc3AuNSAgMTMyLjgzNSAwLjAzMCAwLjc4OCAxMzMuNTQgIDEz My43MyBPNC5ub2lmX2RzcCBGQUxTRSAgIFRSVUUgICAgICA0DQpPNC5ub2lm X2RzcC42ICAxMjguNjQxIDAuMDI3IDAuNzQ4IDEyOS4zMiAgMTI5LjQ5IE80 Lm5vaWZfZHNwIEZBTFNFICAgVFJVRSAgICAgIDQNCk80Lm5vaWZfZHNwLjcg IDEyOC45MjIgMC4wMjggMC43NTIgMTI5LjYxICAxMzAuMTcgTzQubm9pZl9k c3AgRkFMU0UgICBUUlVFICAgICAgNA0KTzQubm9pZl9kc3AuOCAgMTMwLjI0 OCAwLjAyOSAwLjc3NyAxMzAuOTYgIDEzMS41MiBPNC5ub2lmX2RzcCBGQUxT RSAgIFRSVUUgICAgICA0DQpPNC5ub2lmX2RzcC45ICAxMzMuMzY2IDAuMDMw IDAuNzg0IDEzNC4wOSAgMTM0LjI1IE80Lm5vaWZfZHNwIEZBTFNFICAgVFJV RSAgICAgIDQNCk80Lm5vaWZfZHNwLjEwIDEzMC43MDQgMC4wMzAgMC43Nzgg MTMxLjQyICAxMzEuOTggTzQubm9pZl9kc3AgRkFMU0UgICBUUlVFICAgICAg NA0KTzQuMSAgICAgICAgICAgMTM4LjY4MSAwLjAyOCAwLjc4NCAxMzkuMzEg IDEzOS44NiAgICAgICAgICBPNCAgVFJVRSAgIFRSVUUgICAgICA0DQpPNC4y ICAgICAgICAgICAxMzYuMDk4IDAuMDI4IDAuNzc5IDEzNi44MCAgMTM2Ljk4 ICAgICAgICAgIE80ICBUUlVFICAgVFJVRSAgICAgIDQNCk80LjMgICAgICAg ICAgIDEzNi43NjggMC4wMjkgMC43NzcgMTM3LjQ3ICAxMzcuNjQgICAgICAg ICAgTzQgIFRSVUUgICBUUlVFICAgICAgNA0KTzQuNCAgICAgICAgICAgMTM2 LjA1NSAwLjAyNyAwLjc3NyAxMzYuNzcgIDEzNi45MyAgICAgICAgICBPNCAg VFJVRSAgIFRSVUUgICAgICA0DQpPNC41ICAgICAgICAgICAxMzYuMzI4IDAu MDI4IDAuNzc3IDEzNy4wMyAgMTM3LjYwICAgICAgICAgIE80ICBUUlVFICAg VFJVRSAgICAgIDQNCk80LjYgICAgICAgICAgIDEzOC40NjYgMC4wMjggMC43 ODUgMTM5LjE1ICAxMzkuNzUgICAgICAgICAgTzQgIFRSVUUgICBUUlVFICAg ICAgNA0KTzQuNyAgICAgICAgICAgMTM1Ljk3OCAwLjAyOCAwLjc3NyAxMzYu NjkgIDEzNy4yNSAgICAgICAgICBPNCAgVFJVRSAgIFRSVUUgICAgICA0DQpP NC44ICAgICAgICAgICAxMzguNzMyIDAuMDI4IDAuNzgxIDEzOS40NCAgMTM5 LjYxICAgICAgICAgIE80ICBUUlVFICAgVFJVRSAgICAgIDQNCk80LjkgICAg ICAgICAgIDEzNi40NjEgMC4wMjcgMC43NzcgMTM3LjE2ICAxMzcuNzMgICAg ICAgICAgTzQgIFRSVUUgICBUUlVFICAgICAgNA0KTzQuMTAgICAgICAgICAg MTM3Ljk0NyAwLjAyOCAwLjc4MyAxMzguNjUgIDEzOC44MyAgICAgICAgICBP NCAgVFJVRSAgIFRSVUUgICAgICA0DQo= --289735540-2128198275-1159657599=:31858 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng --289735540-2128198275-1159657599=:31858-- From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 05:24:00 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 029AD126D84 for ; Sun, 1 Oct 2006 05:24:00 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id CDD403B026; Sun, 1 Oct 2006 05:23:54 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id D65833B023 for ; Sun, 1 Oct 2006 05:23:51 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 04425-01 for ; Sun, 1 Oct 2006 05:23:51 +0200 (CEST) Received: from pne-smtpout4-sn1.fre.skanova.net (pne-smtpout4-sn1.fre.skanova.net [81.228.11.168]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id A04EC3B022 for ; Sun, 1 Oct 2006 05:23:51 +0200 (CEST) Received: from symbol.nonexistent.fi (80.220.221.236) by pne-smtpout4-sn1.fre.skanova.net (7.2.075) id 44A36A0A003E5884 for mplayer-dev-eng@mplayerhq.hu; Sun, 1 Oct 2006 05:23:53 +0200 Subject: Re: [MPlayer-dev-eng] Analyzing benchmark results (was Re: Compile options) From: Uoti Urpala To: mplayer-dev-eng@mplayerhq.hu In-Reply-To: References: <450AFBAC.1080901@cute.se> <200609192034.47382.Bircoph@list.ru> <200609202122.14964.Bircoph@list.ru> <1159023001.1901.16.camel@symbol.nonexistent.fi> <20060923150024.GA9922@biurrun.de> <1159621596.11221.27.camel@symbol.nonexistent.fi> Content-Type: text/plain Date: Sun, 01 Oct 2006 06:23:52 +0300 Message-Id: <1159673033.11221.132.camel@symbol.nonexistent.fi> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu On Sat, 2006-09-23 at 07:17 -0700, Trent Piepho wrote: > > > > > > Mean and sample standard deviation for each optimization level, 10 samples per test. On Sat, Sep 23, 2006 at 05:50:01PM +0300, Uoti Urpala wrote: > > > > > I think minimum would be a more appropriate value than mean, as the > > > > > decoding should be mostly deterministic and larger times represent > > > > > interference from other processes. Note that my original remark was about the values shown as the speeds of the optimization levels, rather than about estimating the accuracy of the values. On Sat, 30 Sep 2006, Uoti Urpala wrote: > > In this case there cannot be far outlier values on the "too small" side > > unless your testing method is broken. On the other hand there most On Sat, 2006-09-30 at 16:06 -0700, Trent Piepho wrote: > Think of the measured values as being the true value plus some random error > term. This random error may be always positive and not have a mean of > zero. That doesn't matter. Some tests require that the resulting data > have a normal distribution (Student's t), some don't (Wilcoxon rank-sum). Just knowing whether one speed is likely higher isn't enough really, you want to know what the speed value actually (approximately) is. So the goal is normally not to run a test to determine whether you can say that A is faster than B, but to produce estimates for the speeds of A and B. Also even if you're just trying to estimate whether one speed is higher that still doesn't mean something like the rank-sum test would be best: it might not require any particular distribution to not show a difference where one doesn't exist, but the opposite is not true - you can get more accurate results by using extra information. > > likely are errors which are not independent between tests and affect a > > different portion of tests for each case. Since the tested value itself > > Why would the errors not be independent between tests? And if it wasn't, > there would be some auto-correlation between tests, would there not? I'll > attache the H.264 data, tell me where the auto-correlation is. I didn't > see any. The activity of other processes on the computer is quite likely to have trends which are not independent between tests. > > is supposed to be (almost) deterministic, using minimum is more robust: > > There are plenty of other testing applications when the true value of the > variable being measured doesn't change between samples, and any errors are > the result of measurment error. Benchmarking a computer program isn't some > kind of unique scenerio that requires one to throw out the previous century > of statistical thought. Can you find any literature that suggests that > using minimum or maximum is a better test? Benchmarking a computer program might not be a unique scenerio; however it IS different from the area of applicability of most statistical tests. You could say it's not so much "requires one to throw out the previous century of statistical thought" but the kind of scenario where people haven't tried to apply the statistical methods during the last century either. There are at least 2 significant factors: 1) Systematic errors and unexpected distribution of random errors in testing are likely. 2) Even if you're extremely careful in testing the best statistics can tell you is something like "option A is likely faster if you use the code from this day and hour in svn, compiled with this exact compiler version and linked with this exact linker version, running under this particular CPU, this version of this OS with these other programs running". Once you extrapolate from that to something which actually matters the uncertainties in the extrapolation are more important than any fine statistical details. 1) means that robustness is a major factor, and 2) means small differences don't matter even if you could detect them more accurately. Minimum is quite robust, even against extreme things like someone hostilely setting 2/3 of the samples to arbitrary values meant to confuse your statistics as badly as possible (still with the constraint that it's not lower than the true value of course), and gives a better estimate of the "true" value than any other simple method such as mean. > > getting one single "good enough" sample means the test gives the right > > How do you decide when you have the magic sample that you will use while > throwing all other data out? After a few dozen runs, maybe checking whether the lowest value is isolated or whether there are several close ones. Seriously, trying to be more exact than that is misguided: errors from reasons other than bad luck with the samples are much more likely. > Why don't you? What are the instances when "best of x", where x is some > number you came up with before hand, is mathmatically better than > established tests such as Student's t test or Wilcoxon Rank-Sum? It seems Your exact question here isn't too clear since "best of x" produces an estimate for the true value, whereas those tests do not produce an estimate for the value but for the probability of one distribution having a higher mean than another. Anyway a distribution where the measurement is true value + one of [0, 1, 2, 3, 4] with equal probability is an example where taking minimum first is better for most tests as it'll very likely give you the exact true value once you have a reasonable number of samples. > that if "best of x" was a good idea, at least for some real scenario, there > would be papers published on it and references to the test. I didn't find > any. Do you know of any? I don't know of papers, and wouldn't expect any to be published (at least about the case of using it with computer programs). There isn't that much to say - there isn't some hidden feature of the data that could be detected with a clever test, rather the point is that using any sophisticated analysis tools is likely a mistake. > > > Now noif_dsp is best again with 12.628. First we get one answer, then the > > > other, and then the original again! If I did another 10 runs, what would > > > be the best then? How does one qualify the result, that after X runs this > > > is best, but after X+1 maybe it will be totally different? It seems that > > > the conclusion from Student's t test, that there is no significant > > > difference, is the right one. Looking at the minimum is trying to find an > > > answer that isn't there. > > > > This argument is nonsense. If the values are close then which one has > > the smaller mean can also keep changing. Whether the difference is > > significant is another question. You seem to set up an idiotic strawman > > It isn't another question, it is _the_ question. Does the data support a > conclusion that there is a difference between two populations? It's the > classic question of hypothesis testing. As mentioned above that is not the question you're normally interested in when doing benchmarks. You want to know how fast the speeds are (at least relative to each other), not whether one is higher than the other (by some unknown amount). > > argument saying that any difference in the minimums would have to be > > interpreted as a significant difference. > > So, how does one decide if the difference in minimums is significant? You > take the minimum of the two samples and then what? If the difference in values is greater than what you consider significant performance differences. Worrying about random errors in testing would be a mistake; peculiarities in the "true" values specific to your current platform or the exact svn version from this day are bigger. _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 09:12:00 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 65704126D84 for ; Sun, 1 Oct 2006 09:12:00 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 868E13B034; Sun, 1 Oct 2006 09:11:57 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id B2D723B031 for ; Sun, 1 Oct 2006 09:11:54 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 26320-01 for ; Sun, 1 Oct 2006 09:11:54 +0200 (CEST) Received: from mandel.name (mandel.name [85.214.43.148]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 810803B024 for ; Sun, 1 Oct 2006 09:11:50 +0200 (CEST) Received: from localhost ([127.0.0.1] helo=mail.mandel.name) by mandel.name with esmtp (Exim 4.50) id 1GTvUD-00086H-Ns for mplayer-dev-eng@mplayerhq.hu; Sun, 01 Oct 2006 09:11:41 +0200 Received: from 68.183.198.185 (SquirrelMail authenticated user olaf) by mail.mandel.name with HTTP; Sun, 1 Oct 2006 00:11:41 -0700 (PDT) Message-ID: <58100.68.183.198.185.1159686701.squirrel@mail.mandel.name> Date: Sun, 1 Oct 2006 00:11:41 -0700 (PDT) From: "Olaf Mandel" To: mplayer-dev-eng@mplayerhq.hu User-Agent: SquirrelMail/1.4.4 MIME-Version: 1.0 Content-Type: multipart/mixed;boundary="----=_20061001001141_31873" X-Priority: 3 (Normal) Importance: Normal X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu Subject: [MPlayer-dev-eng] [PATCH] Skipped subtitles in first part of DVD X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu ------=_20061001001141_31873 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, if a DVD (or any MPEG?) is played back with subtitles, it can happen that several of the first subtitles are not displayed. In mplayer this can be corrected by seeking in the movie, but there is no workaround for mencoder. The problem is in the MPEG-demuxer in demux_mpg_open(), where repeated calls to ds_fill_buffer(demuxer->video) not only fill the video stream, but sometimes also the subtitle stream. These packets need to be removed from the stream, otherwise all subtitles before the one from the forgotten packet are dropped. Something similar seems to happen in demux_seek_mpg(), but I have not seen that bug and cannot say if the second added line in the patch is needed or not. Could someone who knows the demuxer please look at it? Thanks, Olaf Mandel - -- Olaf Mandel eMail Olaf@Mandel.name -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFFH2otmafSxjM5iEgRAsUuAJ9zTUOAJ3SagFWWay5Oz5Jc65JiPgCcC3JN b+GTk6eMJ6e2C62o6fun8aA= =IaVp -----END PGP SIGNATURE----- ------=_20061001001141_31873 Content-Type: multipart/signed; boundary="----=_20061001001141_31873_part_2" Content-Transfer-Encoding: base64 ------=_20061001001141_31873_part_2 Content-Type: application/octet-stream; name="patch1" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch1" SW5kZXg6IGxpYm1wZGVtdXgvZGVtdXhfbXBnLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGlibXBkZW11eC9k ZW11eF9tcGcuYwkocmV2aXNpb24gMjAwMDkpCisrKyBsaWJtcGRlbXV4L2RlbXV4X21wZy5jCSh3 b3JraW5nIGNvcHkpCkBAIC0xMzUsNiArMTM1LDcgQEAKICAgICBpZiAobXBnX2QtPmZpbmFsX3B0 cyA+IDMgKiBoYWxmX3B0cyB8fCBtcGdfZC0+ZmluYWxfcHRzIDwgMS41ICogaGFsZl9wdHMpIHsK ICAgICAgIG1wZ19kLT5oYXNfdmFsaWRfdGltZXN0YW1wcyA9IDA7CiAgICAgfQorICAgIGRzX2Zy ZWVfcGFja3MoZGVtdXhlci0+c3ViKTsKICAgICBkc19mcmVlX3BhY2tzKGRlbXV4ZXItPmF1ZGlv KTsKICAgICBkc19mcmVlX3BhY2tzKGRlbXV4ZXItPnZpZGVvKTsKICAgICBkZW11eGVyLT5zdHJl YW0tPmVvZj0wOyAvLyBjbGVhciBlb2YgZmxhZwpAQCAtNzg5LDYgKzc5MCw3IEBACiAgICAgICAg IC8vcHJlcGFyZSBhbm90aGVyIHNlZWsgYmVjYXVzZSB3ZSBhcmUgb2ZmIGJ5IG1vcmUgdGhhbiAw LjVzCiAJaWYobXBnX2QpIHsKICAgICAgICAgbmV3cG9zICs9IChuZXdwdHMgLSBtcGdfZC0+bGFz dF9wdHMpICogKG5ld3BvcyAtIG9sZHBvcykgLyAobXBnX2QtPmxhc3RfcHRzIC0gb2xkcHRzKTsK KyAgICAgICAgZHNfZnJlZV9wYWNrcyhkZW11eGVyLT5zdWIpOyAgLy9VbnN1cmU6IGlzIHRoaXMg bmVjZXNzYXJ5PwogICAgICAgICBkc19mcmVlX3BhY2tzKGRfYXVkaW8pOwogICAgICAgICBkc19m cmVlX3BhY2tzKGRfdmlkZW8pOwogICAgICAgICBkZW11eGVyLT5zdHJlYW0tPmVvZj0wOyAvLyBj bGVhciBlb2YgZmxhZwo= ------=_20061001001141_31873_part_2 Content-Type: application/pgp-signature; name="patch1.sig.asc" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch1.sig.asc" LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEuNC4xIChHTlUv TGludXgpCgppRDhEQlFCRkgyb3RtYWZTeGpNNWlFZ1JBbTNkQUo5emlpMlZpMFU2Y1BKbm5raitO U001WGUrckdRQ2c0dTVjCkY5dTJ4S1ZwRVpXSUIxamk0dEErbitVPQo9MFB6OAotLS0tLUVORCBQ R1AgU0lHTkFUVVJFLS0tLS0K ------=_20061001001141_31873_part_2-- ------=_20061001001141_31873 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng ------=_20061001001141_31873-- From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 09:18:47 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 71568126D84 for ; Sun, 1 Oct 2006 09:18:47 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id A6F633B045; Sun, 1 Oct 2006 09:18:46 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 3553F3B03F for ; Sun, 1 Oct 2006 09:18:45 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 23239-08-14 for ; Sun, 1 Oct 2006 09:18:45 +0200 (CEST) Received: from mandel.name (mandel.name [85.214.43.148]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 12CBF3B03A for ; Sun, 1 Oct 2006 09:18:45 +0200 (CEST) Received: from localhost ([127.0.0.1] helo=mail.mandel.name) by mandel.name with esmtp (Exim 4.50) id 1GTvau-0008Ek-MS for mplayer-dev-eng@mplayerhq.hu; Sun, 01 Oct 2006 09:18:36 +0200 Received: from 68.183.198.185 (SquirrelMail authenticated user olaf) by mail.mandel.name with HTTP; Sun, 1 Oct 2006 00:18:36 -0700 (PDT) Message-ID: <39724.68.183.198.185.1159687116.squirrel@mail.mandel.name> Date: Sun, 1 Oct 2006 00:18:36 -0700 (PDT) From: "Olaf Mandel" To: mplayer-dev-eng@mplayerhq.hu User-Agent: SquirrelMail/1.4.4 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu Subject: [MPlayer-dev-eng] Re:[PATCH] Skipped subtitles in first part of DVD X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, let me try again, this time with the patch actually part of the mail body... > > if a DVD (or any MPEG?) is played back with subtitles, it can happen that > several of the first subtitles are not displayed. In mplayer this can be > corrected by seeking in the movie, but there is no workaround for > mencoder. > > The problem is in the MPEG-demuxer in demux_mpg_open(), where repeated > calls to ds_fill_buffer(demuxer->video) not only fill the video stream, > but sometimes also the subtitle stream. These packets need to be removed > from the stream, otherwise all subtitles before the one from the forgotten > packet are dropped. > > Something similar seems to happen in demux_seek_mpg(), but I have not seen > that bug and cannot say if the second added line in the patch is needed or > not. Could someone who knows the demuxer please look at it? > > Thanks, > Olaf Mandel - -- Olaf Mandel eMail Olaf@Mandel.name Index: libmpdemux/demux_mpg.c =================================================================== - --- libmpdemux/demux_mpg.c (revision 20009) +++ libmpdemux/demux_mpg.c (working copy) @@ -135,6 +135,7 @@ if (mpg_d->final_pts > 3 * half_pts || mpg_d->final_pts < 1.5 * half_pts) { mpg_d->has_valid_timestamps = 0; } + ds_free_packs(demuxer->sub); ds_free_packs(demuxer->audio); ds_free_packs(demuxer->video); demuxer->stream->eof=0; // clear eof flag @@ -789,6 +790,7 @@ //prepare another seek because we are off by more than 0.5s if(mpg_d) { newpos += (newpts - mpg_d->last_pts) * (newpos - oldpos) / (mpg_d->last_pts - oldpts); + ds_free_packs(demuxer->sub); //Unsure: is this necessary? ds_free_packs(d_audio); ds_free_packs(d_video); demuxer->stream->eof=0; // clear eof flag -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFFH2vMmafSxjM5iEgRAuSDAJ48NYJ527vxTXeSBkojuDeIqont0gCgr3wz frfl8dtDXC09i8gSBhO5TaY= =w5dE -----END PGP SIGNATURE----- _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 11:34:07 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id CC3AB126D88 for ; Sun, 1 Oct 2006 11:34:07 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 6F8DE3B044; Sun, 1 Oct 2006 11:34:05 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 359B23B036 for ; Sun, 1 Oct 2006 11:34:03 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 07425-04-2 for ; Sun, 1 Oct 2006 11:34:03 +0200 (CEST) Received: from aa011msr.fastwebnet.it (aa011msr.fastwebnet.it [85.18.95.71]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 155B83B03C for ; Sun, 1 Oct 2006 11:34:03 +0200 (CEST) Received: from [192.168.2.101] (37.2.0.113) by aa011msr.fastwebnet.it (7.3.105.6) (authenticated as nicola_sabbi) id 45128AD800403108 for mplayer-dev-eng@mplayerhq.hu; Sun, 1 Oct 2006 11:34:01 +0200 Message-ID: <451F8DB7.7030708@fastwebnet.it> Date: Sun, 01 Oct 2006 11:43:19 +0200 From: Nico Sabbi User-Agent: Mozilla Thunderbird 1.0.7-4mdk (X11/20051221) X-Accept-Language: en-us, en MIME-Version: 1.0 To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] Re:[PATCH] Skipped subtitles in first part of DVD References: <39724.68.183.198.185.1159687116.squirrel@mail.mandel.name> In-Reply-To: <39724.68.183.198.185.1159687116.squirrel@mail.mandel.name> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Olaf Mandel wrote: >-----BEGIN PGP SIGNED MESSAGE----- >Hash: SHA1 > >Hello, > >let me try again, this time with the patch actually part of the mail body... > > > >>if a DVD (or any MPEG?) is played back with subtitles, it can happen that >>several of the first subtitles are not displayed. In mplayer this can be >>corrected by seeking in the movie, but there is no workaround for >>mencoder. >> >>The problem is in the MPEG-demuxer in demux_mpg_open(), where repeated >>calls to ds_fill_buffer(demuxer->video) not only fill the video stream, >>but sometimes also the subtitle stream. These packets need to be removed >>from the stream, otherwise all subtitles before the one from the forgotten >>packet are dropped. >> >>Something similar seems to happen in demux_seek_mpg(), but I have not seen >>that bug and cannot say if the second added line in the patch is needed or >>not. Could someone who knows the demuxer please look at it? >> >>Thanks, >>Olaf Mandel >> >> >- -- >Olaf Mandel eMail Olaf@Mandel.name > >Index: libmpdemux/demux_mpg.c >=================================================================== >- --- libmpdemux/demux_mpg.c (revision 20009) >+++ libmpdemux/demux_mpg.c (working copy) >@@ -135,6 +135,7 @@ > if (mpg_d->final_pts > 3 * half_pts || mpg_d->final_pts < 1.5 * >half_pts) { mpg_d->has_valid_timestamps = 0; > } >+ ds_free_packs(demuxer->sub); > ds_free_packs(demuxer->audio); > ds_free_packs(demuxer->video); > demuxer->stream->eof=0; // clear eof flag >@@ -789,6 +790,7 @@ > //prepare another seek because we are off by more than 0.5s > if(mpg_d) { > newpos += (newpts - mpg_d->last_pts) * (newpos - oldpos) / >(mpg_d->last_pts - oldpts); >+ ds_free_packs(demuxer->sub); //Unsure: is this necessary? > ds_free_packs(d_audio); > ds_free_packs(d_video); > demuxer->stream->eof=0; // clear eof flag > > > thanks, applied _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 15:06:32 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 67094126D88 for ; Sun, 1 Oct 2006 15:06:32 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 073E23B0AE; Sun, 1 Oct 2006 15:06:30 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id F1F103B0AB for ; Sun, 1 Oct 2006 15:06:27 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 01965-01 for ; Sun, 1 Oct 2006 15:06:27 +0200 (CEST) Received: from fmmailgate02.web.de (fmmailgate02.web.de [217.72.192.227]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id CFF943B047 for ; Sun, 1 Oct 2006 15:06:23 +0200 (CEST) Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172]) by fmmailgate02.web.de (Postfix) with ESMTP id 4AD24240533E for ; Sun, 1 Oct 2006 15:06:24 +0200 (CEST) Received: from [88.217.36.222] (helo=[88.217.36.222]) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.107 #114) id 1GU11T-0002kG-00 for mplayer-dev-eng@mplayerhq.hu; Sun, 01 Oct 2006 15:06:23 +0200 Message-ID: <451FBD52.4060804@web.de> Date: Sun, 01 Oct 2006 15:06:26 +0200 From: Burkhard Fischer User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060620 Debian/1.7.13-0.2 X-Accept-Language: en MIME-Version: 1.0 To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] memory leak because of missing demux_close_asf() References: <451FBC7F.30505@gmx.net> In-Reply-To: <451FBC7F.30505@gmx.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Sender: b.fi2@web.de X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi Guillaume, I tested my patch against the current SVN version. The memory leak still exists. Here is my patch (svn diff output): Index: libmpdemux/demux_asf.c =================================================================== --- libmpdemux/demux_asf.c (revision 20011) +++ libmpdemux/demux_asf.c (working copy) @@ -553,6 +553,8 @@ //---- ASF header: if(!asf) return NULL; if (!read_asf_header(demuxer,asf)) { + if (asf->packet) + free(asf->packet); free(asf); return NULL; } @@ -586,7 +588,15 @@ return demuxer; } +void demux_close_asf(demuxer_t* demuxer) { + struct asf_priv* asf = demuxer->priv; + if(!asf) return NULL; + if (asf->packet) + free(asf->packet); + free(asf); +} + demuxer_desc_t demuxer_desc_asf = { "ASF demuxer", "asf", @@ -598,7 +608,7 @@ asf_check_header, demux_asf_fill_buffer, demux_open_asf, - NULL, //demux_close_asf, + demux_close_asf, demux_seek_asf, demux_asf_control }; Bye, Burkhard > Please provide a patch against latest SVN. (maybe it's the same code > as pre8, but anyhow you need to check that...) > > Also, please do not add some cosmetics (i.e. add empty newlines and > stuff...) > > Guillaume _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 15:33:11 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 79C6A126D88 for ; Sun, 1 Oct 2006 15:33:11 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 10FD63B0A6; Sun, 1 Oct 2006 15:33:08 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 4D16F3B042 for ; Sun, 1 Oct 2006 15:33:06 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 04563-01-4 for ; Sun, 1 Oct 2006 15:33:06 +0200 (CEST) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.168]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 2FFEC3B03C for ; Sun, 1 Oct 2006 15:33:06 +0200 (CEST) Received: by ug-out-1314.google.com with SMTP id h2so455786ugf for ; Sun, 01 Oct 2006 06:33:06 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=NeIbieShR0pozlJxk5bgcNvznvfS5CB4wpxwY00sbzIrRdOVSJ7pPp5mYefjs7DG/Rs5Nkj1sCyI5pi7caGLKFSiHCgyekokF/SOB90zJD/i5W/sANlaaYjhLeCv6Vmx59eIlc/+/JPVLZpJzWIyrZx2SwFS0N/grK1v3QHV5rE= Received: by 10.66.244.10 with SMTP id r10mr1894812ugh; Sun, 01 Oct 2006 06:33:06 -0700 (PDT) Received: by 10.66.222.2 with HTTP; Sun, 1 Oct 2006 06:33:06 -0700 (PDT) Message-ID: <4e03026a0610010633y576d594dh3e828237ab8960fc@mail.gmail.com> Date: Sun, 1 Oct 2006 15:33:06 +0200 From: "Guillaume POIRIER" To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] memory leak because of missing demux_close_asf() In-Reply-To: <451FBD52.4060804@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <451FBC7F.30505@gmx.net> <451FBD52.4060804@web.de> X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi, On 10/1/06, Burkhard Fischer wrote: > Hi Guillaume, > > I tested my patch against the current SVN version. The memory leak still > exists. > > Here is my patch (svn diff output): > > Index: libmpdemux/demux_asf.c > =================================================================== > --- libmpdemux/demux_asf.c (revision 20011) > +++ libmpdemux/demux_asf.c (working copy) > @@ -553,6 +553,8 @@ > //---- ASF header: > if(!asf) return NULL; > if (!read_asf_header(demuxer,asf)) { > + if (asf->packet) > + free(asf->packet); > free(asf); > return NULL; > } > @@ -586,7 +588,15 @@ > return demuxer; > } > > +void demux_close_asf(demuxer_t* demuxer) { > + struct asf_priv* asf = demuxer->priv; > > + if(!asf) return NULL; > + if (asf->packet) > + free(asf->packet); > + free(asf); > +} > + > demuxer_desc_t demuxer_desc_asf = { > "ASF demuxer", > "asf", > @@ -598,7 +608,7 @@ > asf_check_header, > demux_asf_fill_buffer, > demux_open_asf, > - NULL, //demux_close_asf, > + demux_close_asf, > demux_seek_asf, > demux_asf_control > }; His patch looks quite clean, so I'm quite tempted to apply it, unless someone disagrees. Guillaume -- With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has a lead on USA on selling out individuals right to corporations! Vive la France! _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 15:49:44 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id DB301126D88 for ; Sun, 1 Oct 2006 15:49:44 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 4F98D3B0C7; Sun, 1 Oct 2006 15:49:43 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id DFB473B0C5 for ; Sun, 1 Oct 2006 15:49:41 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 06595-02-8 for ; Sun, 1 Oct 2006 15:49:41 +0200 (CEST) Received: from smtp3-g19.free.fr (smtp3-g19.free.fr [212.27.42.29]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id C37A43B0C4 for ; Sun, 1 Oct 2006 15:49:41 +0200 (CEST) Received: from lisa.gnuage.org (lns-bzn-21-82-248-183-219.adsl.proxad.net [82.248.183.219]) by smtp3-g19.free.fr (Postfix) with SMTP id 4E5EA48F60 for ; Sun, 1 Oct 2006 15:49:42 +0200 (CEST) Date: Sun, 1 Oct 2006 15:53:43 +0200 From: Aurelien Jacobs To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] memory leak because of missing demux_close_asf() Message-Id: <20061001155343.f26c3ac4.aurel@gnuage.org> In-Reply-To: <451FBD52.4060804@web.de> References: <451FBC7F.30505@gmx.net> <451FBD52.4060804@web.de> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu On Sun, 01 Oct 2006 15:06:26 +0200 Burkhard Fischer wrote: > Hi Guillaume, > > I tested my patch against the current SVN version. The memory leak still > exists. Please don't top-post. > Here is my patch (svn diff output): > > Index: libmpdemux/demux_asf.c > =================================================================== > --- libmpdemux/demux_asf.c (revision 20011) > +++ libmpdemux/demux_asf.c (working copy) > @@ -553,6 +553,8 @@ > //---- ASF header: > if(!asf) return NULL; > if (!read_asf_header(demuxer,asf)) { > + if (asf->packet) > + free(asf->packet); > free(asf); > return NULL; > } Inconsistent indentation (same applies to your whole patch). Aurel _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 15:57:39 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id C7C51126DA6 for ; Sun, 1 Oct 2006 15:57:39 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 1D1593B0CC; Sun, 1 Oct 2006 15:57:38 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 36BB63B0C5 for ; Sun, 1 Oct 2006 15:57:36 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 07571-02-6 for ; Sun, 1 Oct 2006 15:57:36 +0200 (CEST) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.172]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 1AAB33B09F for ; Sun, 1 Oct 2006 15:57:36 +0200 (CEST) Received: by ug-out-1314.google.com with SMTP id h2so457388ugf for ; Sun, 01 Oct 2006 06:57:37 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=t7UBnHwB0qbyxGTH0UMSYHQNoFKIfZHazedSJSJMSOOsZ6f7s7yNt/607xnI0OkmQ9j7xUWQwtL7e/BjoA/CL1UBaYGk5P54ijfYe0TFMkFy99m/jNAWN9xdYSBg3KfLxtngMy0TbuZK09MQavDwHi1lyPl7RApkfx+HWMYDiKw= Received: by 10.66.240.12 with SMTP id n12mr1914517ugh; Sun, 01 Oct 2006 06:57:36 -0700 (PDT) Received: by 10.66.222.2 with HTTP; Sun, 1 Oct 2006 06:57:36 -0700 (PDT) Message-ID: <4e03026a0610010657u573f7b05m4ac57950a1d4c3b0@mail.gmail.com> Date: Sun, 1 Oct 2006 15:57:36 +0200 From: "Guillaume POIRIER" To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] memory leak because of missing demux_close_asf() In-Reply-To: <20061001155343.f26c3ac4.aurel@gnuage.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <451FBC7F.30505@gmx.net> <451FBD52.4060804@web.de> <20061001155343.f26c3ac4.aurel@gnuage.org> X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi, On 10/1/06, Aurelien Jacobs wrote: > On Sun, 01 Oct 2006 15:06:26 +0200 > Burkhard Fischer wrote: > > > Hi Guillaume, > > > > I tested my patch against the current SVN version. The memory leak still > > exists. > > Please don't top-post. > > > Here is my patch (svn diff output): > > > > Index: libmpdemux/demux_asf.c > > =================================================================== > > --- libmpdemux/demux_asf.c (revision 20011) > > +++ libmpdemux/demux_asf.c (working copy) > > @@ -553,6 +553,8 @@ > > //---- ASF header: > > if(!asf) return NULL; > > if (!read_asf_header(demuxer,asf)) { > > + if (asf->packet) > > + free(asf->packet); > > free(asf); > > return NULL; > > } > > Inconsistent indentation (same applies to your whole patch). > > Aurel Other than that, is the patch ok? I can sure fix the identation before commiting... Guillaume -- With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has a lead on USA on selling out individuals right to corporations! Vive la France! _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 15:59:51 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id DBC1D126D88 for ; Sun, 1 Oct 2006 15:59:51 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 4AF433B0D4; Sun, 1 Oct 2006 15:59:50 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 0B9273B047 for ; Sat, 30 Sep 2006 18:45:00 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 02340-06 for ; Sat, 30 Sep 2006 18:44:59 +0200 (CEST) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.176]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id AE1A23B044 for ; Sat, 30 Sep 2006 18:44:55 +0200 (CEST) Received: by py-out-1112.google.com with SMTP id c31so1517619pyd for ; Sat, 30 Sep 2006 09:44:56 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:user-agent:mime-version:to:subject:content-type:content-transfer-encoding; b=q5vEy8dwRcnOJ3RSceUyJlE1JSvtrq+rAxm1QzizItky8LwUTS/Eeuex6outtMDKyuqqVqH+2OasrwSBtRNPpMaCWLlYQcVcR75sGbbnNc6K01xdfpZLoIRscv0UlT8F4XgoqpjVBm0zxLwyN5MEXD4KdMmJQHJW6/ZbcTEvqsY= Received: by 10.65.35.6 with SMTP id n6mr1974822qbj; Sat, 30 Sep 2006 09:44:56 -0700 (PDT) Received: from ?192.168.2.100? ( [24.203.4.206]) by mx.gmail.com with ESMTP id 15sm2616648nzn.2006.09.30.09.44.55; Sat, 30 Sep 2006 09:44:55 -0700 (PDT) Message-ID: <451E9F07.8030301@gmail.com> Date: Sat, 30 Sep 2006 12:44:55 -0400 From: sr1515 User-Agent: Thunderbird 1.5.0.7 (X11/20060909) MIME-Version: 1.0 To: mplayer-dev-eng@mplayerhq.hu Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-Mailman-Approved-At: Sun, 01 Oct 2006 15:59:49 +0200 Subject: [MPlayer-dev-eng] vf_yadif.c - Revision 19836 bug X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi all, I am NOT a developer but I've been using the SVN version (and previously the CVS version) of Mplayer for years. I regularly update my source. I simply want to inform your group that ever since revision 19836, vf_yadif.c has been triggering this compile error: ------- quote ------- {standard input}: Assembler messages: {standard input}:185: Error: bad expression {standard input}:185: Error: junk `1-1' after expression {standard input}:216: Error: bad expression {standard input}:216: Error: junk `2-1' after expression {standard input}:250: Error: bad expression {standard input}:250: Error: junk `1-1' after expression {standard input}:281: Error: bad expression {standard input}:281: Error: junk `2-1' after expression {standard input}:460: Error: bad expression {standard input}:460: Error: junk `1-1' after expression {standard input}:491: Error: bad expression {standard input}:491: Error: junk `2-1' after expression {standard input}:525: Error: bad expression {standard input}:525: Error: junk `1-1' after expression {standard input}:556: Error: bad expression {standard input}:556: Error: junk `2-1' after expression make[1]: *** [vf_yadif.o] Error 1 make[1]: Leaving directory `~/devel/MPlayer-1.0-SVN/libmpcodecs' make: *** [libmpcodecs/libmpcodecs.a] Error 2 ------ end quote ----- Compilation works when any version vf_yadif.c from revision 19836 to current is replaced with revision 19835. My box is a P-III, running Slackware 10.0 (fully up to date on patches). Since, for all I can understand, the revised vf_yadif.c appears to be related to low level MMX features, my CPU specs as per /proc/cpuinfo are the following: $ cat cpuinfo processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 8 model name : Pentium III (Coppermine) stepping : 10 cpu MHz : 935.478 cache size : 256 KB fdiv_bug : no hlt_bug : no f00f_bug : no coma_bug : no fpu : yes fpu_exception : yes cpuid level : 2 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 mmx fxsr sse bogomips : 1867.77 Hoping this note helps. Reply to sending address for more information. Thanks and best regards. MP _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 16:00:34 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id EA395126D88 for ; Sun, 1 Oct 2006 16:00:33 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 48A803B0DA; Sun, 1 Oct 2006 16:00:32 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id C4C293B0D7 for ; Sun, 1 Oct 2006 16:00:30 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 09088-01-4 for ; Sun, 1 Oct 2006 16:00:30 +0200 (CEST) Received: from ods15.dyndns.org (80.178.6.70.adsl.012.net.il [80.178.6.70]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 22E833B0D6 for ; Sun, 1 Oct 2006 16:00:30 +0200 (CEST) Received: from ods15 by ods15.dyndns.org with local (Exim 4.54) id 1GU1ro-0002St-7t for mplayer-dev-eng@mplayerhq.hu; Sun, 01 Oct 2006 16:00:28 +0200 Date: Sun, 1 Oct 2006 16:00:28 +0200 To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] memory leak because of missing demux_close_asf() Message-ID: <20061001140028.GN6927@crate15> References: <451FBC7F.30505@gmx.net> <451FBD52.4060804@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <451FBD52.4060804@web.de> User-Agent: Mutt/1.5.11 From: Oded Shimon X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu On Sun, Oct 01, 2006 at 03:06:26PM +0200, Burkhard Fischer wrote: > Hi Guillaume, > > I tested my patch against the current SVN version. The memory leak still > exists. > > Here is my patch (svn diff output): > > Index: libmpdemux/demux_asf.c > =================================================================== > --- libmpdemux/demux_asf.c (revision 20011) > +++ libmpdemux/demux_asf.c (working copy) > @@ -553,6 +553,8 @@ > //---- ASF header: > if(!asf) return NULL; > if (!read_asf_header(demuxer,asf)) { > + if (asf->packet) > + free(asf->packet); useless if before a free() > +void demux_close_asf(demuxer_t* demuxer) { > + struct asf_priv* asf = demuxer->priv; > > + if(!asf) return NULL; jusr 'return;', this is a void function. > + if (asf->packet) > + free(asf->packet); again, useless if. > + free(asf); > +} > + > demuxer_desc_t demuxer_desc_asf = { > "ASF demuxer", > "asf", > @@ -598,7 +608,7 @@ > asf_check_header, > demux_asf_fill_buffer, > demux_open_asf, > - NULL, //demux_close_asf, > + demux_close_asf, Patch seems ok otherwise (indentation whatever?) - ods15 _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 16:42:42 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 710EA126D88 for ; Sun, 1 Oct 2006 16:42:42 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 4AE9B3B0C8; Sun, 1 Oct 2006 16:42:39 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id F05193B0BF for ; Sun, 1 Oct 2006 16:42:37 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 13309-02 for ; Sun, 1 Oct 2006 16:42:37 +0200 (CEST) Received: from mail.gmx.net (mail.gmx.de [213.165.64.20]) by natsuki.mplayerhq.hu (Postfix) with SMTP id B4B333B0B4 for ; Sun, 1 Oct 2006 16:42:37 +0200 (CEST) Received: (qmail invoked by alias); 01 Oct 2006 14:42:28 -0000 Received: from pD9E98533.dip0.t-ipconnect.de (EHLO localhost) [217.233.133.51] by mail.gmx.net (mp029) with SMTP; 01 Oct 2006 16:42:28 +0200 X-Authenticated: #11956158 Date: Sun, 1 Oct 2006 16:42:12 +0200 From: Reimar =?iso-8859-1?Q?D=F6ffinger?= To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] vf_yadif.c: fix for (probably) older binutils Message-ID: <20061001144212.GA31010@1und1.de> Mail-Followup-To: mplayer-dev-eng@mplayerhq.hu References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="bg08WKrSYDhXBjb5" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-Y-GMX-Trusted: 0 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu --bg08WKrSYDhXBjb5 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hello, On Thu, Sep 21, 2006 at 11:17:55PM +0200, Tomas Janousek wrote: > my as does not understand "-1-1(something)", so I changed it to "0-1-1" > and so on. > > I have binutils-2.15.90.0.3-5 on Fedora Core 2. So is this patch or the attached one or something completely different preferable? Greetings, Reimar Döffinger --bg08WKrSYDhXBjb5 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename="yadif_binu.diff" Index: libmpcodecs/vf_yadif.c =================================================================== --- libmpcodecs/vf_yadif.c (revision 20011) +++ libmpcodecs/vf_yadif.c (working copy) @@ -83,8 +83,8 @@ "pmaxsw "#tmp", "#dst" \n\t" #define CHECK(pj,mj) \ - "movq "#pj"-1(%[cur],%[mrefs]), %%mm2 \n\t" /* cur[x-refs-1+j] */\ - "movq "#mj"-1(%[cur],%[prefs]), %%mm3 \n\t" /* cur[x+refs-1-j] */\ + "movq "#pj"(%[cur],%[mrefs]), %%mm2 \n\t" /* cur[x-refs-1+j] */\ + "movq "#mj"(%[cur],%[prefs]), %%mm3 \n\t" /* cur[x+refs-1-j] */\ "movq %%mm2, %%mm4 \n\t"\ "movq %%mm2, %%mm5 \n\t"\ "pxor %%mm3, %%mm4 \n\t"\ @@ -193,13 +193,13 @@ "paddw %%mm3, %%mm0 \n\t"\ "psubw %[pw1], %%mm0 \n\t" /* spatial_score */\ \ - CHECK(-1,1)\ + CHECK(-2,0)\ CHECK1\ - CHECK(-2,2)\ + CHECK(-3,1)\ CHECK2\ - CHECK(1,-1)\ + CHECK(0,-2)\ CHECK1\ - CHECK(2,-2)\ + CHECK(1,-3)\ CHECK2\ \ /* if(p->mode<2) ... */\ --bg08WKrSYDhXBjb5 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng --bg08WKrSYDhXBjb5-- From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 16:49:20 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id F1789126D88 for ; Sun, 1 Oct 2006 16:49:19 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 8E1BC3B036; Sun, 1 Oct 2006 16:49:16 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 5A6F33B033 for ; Sun, 1 Oct 2006 16:49:13 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 13917-02-5 for ; Sun, 1 Oct 2006 16:49:13 +0200 (CEST) Received: from mx.republique.smartjog.net (republique.smartjog.net [83.243.17.194]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 3BFED3B032 for ; Sun, 1 Oct 2006 16:49:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mx.republique.smartjog.net (Postfix) with ESMTP id 5AA19C01F for ; Sun, 1 Oct 2006 16:48:45 +0200 (CEST) Received: from mx.republique.smartjog.net ([127.0.0.1]) by localhost (mail [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 09149-01 for ; Sun, 1 Oct 2006 16:48:40 +0200 (CEST) Received: from [127.0.0.1] (unknown [84.7.121.65]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx.republique.smartjog.net (Postfix) with ESMTP id 706E8BFFC for ; Sun, 1 Oct 2006 16:48:40 +0200 (CEST) Message-ID: <451FD563.4030505@smartjog.com> Date: Sun, 01 Oct 2006 16:49:07 +0200 From: Baptiste Coudurier User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] mjpeg yuv422 output from mencoder/mplayer References: <200609301246.59119.karolina.lindqvist@kramnet.se> <20060930145816.GA16579@MichaelsNB> In-Reply-To: <20060930145816.GA16579@MichaelsNB> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at smartjog.com X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi Michael Niedermayer a écrit : > Hi > > On Sat, Sep 30, 2006 at 12:46:58PM +0200, Karolina Lindqvist wrote: >> I need something that outputs the MJPEG YUV422 format, that the zoran (zr, >> zr2) drivers need, but I find nothing in the mencoder/mplayer programs that >> can output that format to disc. >> >> I tried mencoder with -lavcopts vcodec=mjpeg which almost appears to do the >> job. Except for that it does not accept format=422p. It can only do YV12 >> (YUV420). > > a patch which adds 422p jpeg encoding support to lavc would be welcome ... > > [...] Tried to. I have at least something working in progressive. Problem is that mpegvideo.c is really hardcoded to 4:2:0 and since DCT on jpeg is done on 8x8 mb it is quite hard to work around that. If you have a clean idea in mind I would rearrange the code and submit it. -- Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA checking for life_signs in -lkenny... no _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 18:14:28 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 6FF70126D88 for ; Sun, 1 Oct 2006 18:14:28 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id B4F2E3B0A9; Sun, 1 Oct 2006 18:14:25 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 20A553B0A7 for ; Sun, 1 Oct 2006 18:14:24 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 26967-02-9 for ; Sun, 1 Oct 2006 18:14:24 +0200 (CEST) Received: from mail.gmx.net (mail.gmx.de [213.165.64.20]) by natsuki.mplayerhq.hu (Postfix) with SMTP id E04D13B0A4 for ; Sun, 1 Oct 2006 18:14:23 +0200 (CEST) Received: (qmail invoked by alias); 01 Oct 2006 16:14:25 -0000 Received: from chello080109116125.4.15.vie.surfer.at (EHLO localhost) [80.109.116.125] by mail.gmx.net (mp033) with SMTP; 01 Oct 2006 18:14:25 +0200 X-Authenticated: #3831892 Date: Sun, 1 Oct 2006 18:12:42 +0200 From: Michael Niedermayer To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] vf_yadif.c: fix for (probably) older binutils Message-ID: <20061001161242.GL2852@MichaelsNB> References: <20061001144212.GA31010@1und1.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20061001144212.GA31010@1und1.de> User-Agent: Mutt/1.5.10i X-Y-GMX-Trusted: 0 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi On Sun, Oct 01, 2006 at 04:42:12PM +0200, Reimar D=F6ffinger wrote: > Hello, > On Thu, Sep 21, 2006 at 11:17:55PM +0200, Tomas Janousek wrote: > > my as does not understand "-1-1(something)", so I changed it to "0-1-1"= =20 > > and so on. > >=20 > > I have binutils-2.15.90.0.3-5 on Fedora Core 2. >=20 > So is this patch or the attached one or something completely different pr= eferable? ive no real objections to it [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In the past you could go to a library and read, borrow or copy any book Today you'd get arrested for mere telling someone where the library is _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 18:21:36 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 07A1E126D88 for ; Sun, 1 Oct 2006 18:21:36 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 9AEE23B0B1; Sun, 1 Oct 2006 18:21:33 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 563B93B0AB for ; Sun, 1 Oct 2006 18:21:31 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 26967-02-26 for ; Sun, 1 Oct 2006 18:21:31 +0200 (CEST) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by natsuki.mplayerhq.hu (Postfix) with SMTP id 241193B0A7 for ; Sun, 1 Oct 2006 18:21:31 +0200 (CEST) Received: (qmail invoked by alias); 01 Oct 2006 16:21:32 -0000 Received: from chello080109116125.4.15.vie.surfer.at (EHLO localhost) [80.109.116.125] by mail.gmx.net (mp032) with SMTP; 01 Oct 2006 18:21:32 +0200 X-Authenticated: #3831892 Date: Sun, 1 Oct 2006 18:19:50 +0200 From: Michael Niedermayer To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] mjpeg yuv422 output from mencoder/mplayer Message-ID: <20061001161949.GM2852@MichaelsNB> References: <200609301246.59119.karolina.lindqvist@kramnet.se> <20060930145816.GA16579@MichaelsNB> <451FD563.4030505@smartjog.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <451FD563.4030505@smartjog.com> User-Agent: Mutt/1.5.10i X-Y-GMX-Trusted: 0 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi On Sun, Oct 01, 2006 at 04:49:07PM +0200, Baptiste Coudurier wrote: > Hi >=20 > Michael Niedermayer a =E9crit : > >Hi > > > >On Sat, Sep 30, 2006 at 12:46:58PM +0200, Karolina Lindqvist wrote: > >>I need something that outputs the MJPEG YUV422 format, that the zoran= =20 > >>(zr, zr2) drivers need, but I find nothing in the mencoder/mplayer=20 > >>programs that can output that format to disc.=20 > >> > >>I tried mencoder with -lavcopts vcodec=3Dmjpeg which almost appears to = do=20 > >>the job. Except for that it does not accept format=3D422p. It can only = do=20 > >>YV12 (YUV420). > > > >a patch which adds 422p jpeg encoding support to lavc would be welcome .= =2E. > > > >[...] >=20 > Tried to. I have at least something working in progressive. Problem is=20 > that mpegvideo.c is really hardcoded to 4:2:0 and since DCT on jpeg is=20 > done on 8x8 mb it is quite hard to work around that. hmm lavc mpeg2 video supports 422 encoding over mpegvideo.c ... [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In the past you could go to a library and read, borrow or copy any book Today you'd get arrested for mere telling someone where the library is _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 19:21:25 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 10026126D83 for ; Sun, 1 Oct 2006 19:21:25 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id D192F3B0BD; Sun, 1 Oct 2006 19:21:21 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 6B0B63B0B9 for ; Sun, 1 Oct 2006 19:21:19 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 06508-03-3 for ; Sun, 1 Oct 2006 19:21:19 +0200 (CEST) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.173]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 4E9BA3B0B8 for ; Sun, 1 Oct 2006 19:21:19 +0200 (CEST) Received: by ug-out-1314.google.com with SMTP id h2so472805ugf for ; Sun, 01 Oct 2006 10:21:20 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=k7ZNfQsW6QhMLcjFxj4z0PFDGhclmiOhkgHwYnZ6TuPO+AJSjhCbY6nJTVf+dIBKhPNnSgUI2f42W2/ObmRZMidAXCRJCCC0gm+eDlGHE05xazjsZ/uMGL8hnnDYcg6lFIuYK8ew1xSY0+imSFzbYGgM1IgCtRY/02fJ4BBUDS8= Received: by 10.67.24.13 with SMTP id b13mr2087742ugj; Sun, 01 Oct 2006 10:21:19 -0700 (PDT) Received: by 10.66.222.2 with HTTP; Sun, 1 Oct 2006 10:21:19 -0700 (PDT) Message-ID: <4e03026a0610011021w192daaa2lfcb48b657d4b908@mail.gmail.com> Date: Sun, 1 Oct 2006 19:21:19 +0200 From: "Guillaume POIRIER" To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] [PATCH] 3 more cpuid tags, including Core 2's SSSE3 In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi, On 9/30/06, Zuxy Meng wrote: > Sync with Linux kernel. Trivial patch, applied. > SSSE3 may be of interest to mplayer because it > includes integer trickies like pabs and psign which apply both to MMX > and XMM registers. Maybe, but until I get a machine that has these new instructions, I won't try to use them ;) Guillaume -- With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has a lead on USA on selling out individuals right to corporations! Vive la France! _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 19:33:33 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 197D7126D83 for ; Sun, 1 Oct 2006 19:33:33 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 514AC3B0C0; Sun, 1 Oct 2006 19:33:30 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id A35C23B0B2 for ; Sun, 1 Oct 2006 19:33:27 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 13039-01-3 for ; Sun, 1 Oct 2006 19:33:27 +0200 (CEST) Received: from mx.laposte.net (mx.laposte.net [81.255.54.11]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 835333B0A7 for ; Sun, 1 Oct 2006 19:33:27 +0200 (CEST) Received: from [192.168.0.2] (82.250.197.183) by mx.laposte.net (7.2.060.1) (authenticated as laurent.wozniak) id 4517D1B700470E6D for mplayer-dev-eng@mplayerhq.hu; Sun, 1 Oct 2006 19:33:28 +0200 Message-ID: <451FFC77.9090405@laposte.net> Date: Sun, 01 Oct 2006 19:35:51 +0200 From: laurent wozniak User-Agent: Thunderbird 1.5.0.7 (X11/20060909) MIME-Version: 1.0 To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] Re: Compile options References: <450AFBAC.1080901@cute.se> <200609192034.47382.Bircoph@list.ru> <200609202122.14964.Bircoph@list.ru> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Trent Piepho wrote: > It seems like there are some functions which h264 inlines that cause the > code size to grow very large, effecting the cache miss rate enough to make > inlining slower. Why doesn't this also make mpeg4 slower? I can think > of a two reasons: > 1. Most functions get faster with inlining, but some get slower. mpeg4 > either doesn't use, or uses less, the functions which get slower. Or h264 > doesn't use, or uses less, the functions which get faster. > 2. mpeg4 has a smaller code size elsewhere, and so it's working set still > fits in the cache with the larger functions. h264's working set size is > larger, and so inlining has an overall negative impact. > > If the first reason is the cause, then attribute((noinline)) could be added > to the functions which get slower with inlining. Comparing the code size > of each exported function of dsputil_mmx.c with and without > -finline-functions will find which functions get much larger. Then one > must find what functions those functions are inlining that causes them to > get larger and noinline them. > Hello, Some searchers have studied and presented us this problem when I was at university (8 years ago). The problem is when you inline too many functions at once, you consume too many registers in the resulting function and the remaining variables are used from the stack. If too many variables are used from the stack, performance of the resulting inlined function are worse than the non inline functions. This is because when calling a function, you first push many registers on the stack, thus the called function can also use registers. Some processors even have a special instruction to perform this push in one shot. Seems that GCC is still not able to do this "push some registers" in the middle (or at some point) of a function when inlining. That's why the resulting inlined function can have poor performances. This result of course varies from one processor family to another, since they don't have the same number of registers. And pcode internal registers are also probably influenced (I mean the internal risc side of a cisc), thus x86 is not one single processor family regarding this problem. Cheers, Laurent _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 19:35:44 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 000A6126D83 for ; Sun, 1 Oct 2006 19:35:43 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 4A4093B0CB; Sun, 1 Oct 2006 19:35:40 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 236B03B0B2 for ; Sun, 1 Oct 2006 19:35:38 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 14163-01 for ; Sun, 1 Oct 2006 19:35:38 +0200 (CEST) Received: from moutng.kundenserver.de (unknown [212.227.126.177]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id EE3633B0A7 for ; Sun, 1 Oct 2006 19:35:37 +0200 (CEST) Received: from [212.117.93.214] (helo=localhost.localdomain) by mrelayeu.kundenserver.de (node=mrelayeu2) with ESMTP (Nemesis), id 0MKwtQ-1GU5Do2VHW-0003So; Sun, 01 Oct 2006 19:35:36 +0200 Received: by localhost.localdomain (sSMTP sendmail emulation); Sun, 1 Oct 2006 19:35:23 +0200 Date: Sun, 1 Oct 2006 19:35:23 +0200 From: Diego Biurrun To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] [PATCH] avc1 in X-QT over RTSP Message-ID: <20061001173523.GD2112@biurrun.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-Provags-ID: kundenserver.de abuse@kundenserver.de login:cda85dccaaeec2d03fac572ff7daa982 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu Cc: Ross Finlayson X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu On Wed, Sep 27, 2006 at 12:45:59AM +0000, Carl Eugen Hoyos wrote: > > Attached patch allows to play avc1 Videos sent over RTSP in subsession > "X-QUICKTIME". That's the way Apple streams at the moment. > > Original bugreport: > http://lists.mplayerhq.hu/pipermail/mplayer-users/2006-January/057669.html > (-fps 16.67 is needed to play the mentioned stream.) > > Please comment, Carl Eugen > > --- libmpdemux/demux_rtp_codec.cpp (Revision 19984) > +++ libmpdemux/demux_rtp_codec.cpp (Arbeitskopie) > @@ -86,6 +86,36 @@ > } while (!parseQTState_video(qtRTPSource->qtState, fourcc)); > > bih->biCompression = sh_video->format = fourcc; > + bih->biWidth = qtRTPSource->qtState.width; > + bih->biHeight = qtRTPSource->qtState.height; > + > +#define BE_32(x) (((unsigned char *)(x))[0] << 24 | \ > + ((unsigned char *)(x))[1] << 16 | \ > + ((unsigned char *)(x))[2] << 8 | \ > + ((unsigned char *)(x))[3]) > +#define char2int(x,y) BE_32(&(x)[(y)]) > +#define MOV_FOURCC(a,b,c,d) ((a<<24)|(b<<16)|(c<<8)|(d)) > + > + if (bih->biCompression == mmioFOURCC('a','v','c','1') && > + qtRTPSource->qtState.sdAtomSize > + < 0xffffffff-sizeof(BITMAPINFOHEADER)) { > + unsigned pos = 86; > + while (pos+8 < qtRTPSource->qtState.sdAtomSize) { > + unsigned atomLength = char2int(qtRTPSource->qtState.sdAtom, pos); > + if (char2int(qtRTPSource->qtState.sdAtom, pos+4) > + == MOV_FOURCC('a','v','c','C') && atomLength > 8) { > + sh_video->bih = bih > + = (BITMAPINFOHEADER*)realloc(bih, sizeof(BITMAPINFOHEADER) > + +atomLength-8); > + bih->biSize = sizeof(BITMAPINFOHEADER)+atomLength-8; > + memcpy((char*)bih+sizeof(BITMAPINFOHEADER), > + qtRTPSource->qtState.sdAtom+pos+8, atomLength-8); > + break; > + } > + pos += atomLength; > + } > + needVideoFrameRate(demuxer, subsession); > + } > } else { > fprintf(stderr, > "Unknown MPlayer format code for MIME type \"video/%s\"\n", Ross, is this patch OK? Diego _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 19:50:37 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 79244126D83 for ; Sun, 1 Oct 2006 19:50:37 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id D19983B0E5; Sun, 1 Oct 2006 19:50:33 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 46AB33B0DF for ; Sun, 1 Oct 2006 19:50:32 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 13039-04-2 for ; Sun, 1 Oct 2006 19:50:32 +0200 (CEST) Received: from mx.republique.smartjog.net (republique.smartjog.net [83.243.17.194]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 1903A3B0DE for ; Sun, 1 Oct 2006 19:50:31 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mx.republique.smartjog.net (Postfix) with ESMTP id BB55BC017 for ; Sun, 1 Oct 2006 19:50:04 +0200 (CEST) Received: from mx.republique.smartjog.net ([127.0.0.1]) by localhost (mail [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 09510-06 for ; Sun, 1 Oct 2006 19:49:59 +0200 (CEST) Received: from [127.0.0.1] (unknown [84.7.121.65]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx.republique.smartjog.net (Postfix) with ESMTP id A5F59BFFD for ; Sun, 1 Oct 2006 19:49:59 +0200 (CEST) Message-ID: <451FFFE3.3060702@smartjog.com> Date: Sun, 01 Oct 2006 19:50:27 +0200 From: Baptiste Coudurier User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] mjpeg yuv422 output from mencoder/mplayer References: <200609301246.59119.karolina.lindqvist@kramnet.se> <20060930145816.GA16579@MichaelsNB> <451FD563.4030505@smartjog.com> <20061001161949.GM2852@MichaelsNB> In-Reply-To: <20061001161949.GM2852@MichaelsNB> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at smartjog.com X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Michael Niedermayer a écrit : > Hi > > On Sun, Oct 01, 2006 at 04:49:07PM +0200, Baptiste Coudurier wrote: >> Hi >> >> Michael Niedermayer a écrit : >>> Hi >>> >>> On Sat, Sep 30, 2006 at 12:46:58PM +0200, Karolina Lindqvist wrote: >>>> I need something that outputs the MJPEG YUV422 format, that the zoran >>>> (zr, zr2) drivers need, but I find nothing in the mencoder/mplayer >>>> programs that can output that format to disc. >>>> >>>> I tried mencoder with -lavcopts vcodec=mjpeg which almost appears to do >>>> the job. Except for that it does not accept format=422p. It can only do >>>> YV12 (YUV420). >>> a patch which adds 422p jpeg encoding support to lavc would be welcome ... >>> >>> [...] >> Tried to. I have at least something working in progressive. Problem is >> that mpegvideo.c is really hardcoded to 4:2:0 and since DCT on jpeg is >> done on 8x8 mb it is quite hard to work around that. > > hmm lavc mpeg2 video supports 422 encoding over mpegvideo.c ... > > [...] Yes. Mpeg2 macroblocks are orderded right out of encode_mb_internal. Output is 8 blocks: 4 luma blocks, 4 chroma blocks in 4:2:2, and stored that way. In mjpeg_encode_mb, you will have 8 blocks while they must be coded 2 luma, 2 chroma, in 4:2:2 and 4 others will be on the next line in the bitstream. I was thinking that storing those 4 blocks temporarly and write them after was not clean. I just rewrote encode_mb_internal to output 4 blocks, and changed s->mb_height to 8. -- Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA checking for life_signs in -lkenny... no _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 19:50:55 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 318D0126D83 for ; Sun, 1 Oct 2006 19:50:55 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 0F3333B132; Sun, 1 Oct 2006 19:50:53 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id CDEF63B0F1 for ; Sun, 1 Oct 2006 19:50:50 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 13039-04-5 for ; Sun, 1 Oct 2006 19:50:50 +0200 (CEST) Received: from pne-smtpout4-sn2.hy.skanova.net (pne-smtpout4-sn2.hy.skanova.net [81.228.8.154]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id AC6963B0E1 for ; Sun, 1 Oct 2006 19:50:50 +0200 (CEST) Received: from symbol.nonexistent.fi (80.220.221.236) by pne-smtpout4-sn2.hy.skanova.net (7.2.075) id 44A2EAB8003D2131 for mplayer-dev-eng@mplayerhq.hu; Sun, 1 Oct 2006 19:50:51 +0200 Subject: Re: [MPlayer-dev-eng] Re: Compile options From: Uoti Urpala To: mplayer-dev-eng@mplayerhq.hu In-Reply-To: <451FFC77.9090405@laposte.net> References: <450AFBAC.1080901@cute.se> <200609192034.47382.Bircoph@list.ru> <200609202122.14964.Bircoph@list.ru> <451FFC77.9090405@laposte.net> Content-Type: text/plain Date: Sun, 01 Oct 2006 20:50:51 +0300 Message-Id: <1159725051.11221.136.camel@symbol.nonexistent.fi> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu On Sun, 2006-10-01 at 19:35 +0200, laurent wozniak wrote: > Some searchers have studied and presented us this problem when I was at > university (8 years ago). > > The problem is when you inline too many functions at once, you consume > too many registers in the resulting function and the remaining variables > are used from the stack. The slowdown in this case was probably caused by code size and cache use rather than register shortage. _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 21:22:01 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 33468126D83 for ; Sun, 1 Oct 2006 21:22:01 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 79FB83B156; Sun, 1 Oct 2006 21:21:58 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 6F0803B14E for ; Sun, 1 Oct 2006 21:21:56 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 27722-05-5 for ; Sun, 1 Oct 2006 21:21:56 +0200 (CEST) Received: from mail.blastwave.org (mail.blastwave.org [147.87.98.10]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 58B843B152 for ; Sun, 1 Oct 2006 21:21:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.blastwave.org (Postfix) with ESMTP id B26E7F931 for ; Sun, 1 Oct 2006 21:21:57 +0200 (MEST) X-Virus-Scanned: amavisd-new at blastwave.org Received: from mail.blastwave.org ([127.0.0.1]) by localhost (enterprise.blastwave.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id B7yNA3C2Ojb5 for ; Sun, 1 Oct 2006 21:21:56 +0200 (MEST) Received: from jashugan.kinali.ch (jashugan.kinali.ch [213.144.135.203]) by mail.blastwave.org (Postfix) with SMTP id 21CCBF92F for ; Sun, 1 Oct 2006 21:21:56 +0200 (MEST) Date: Sun, 1 Oct 2006 21:21:55 +0200 From: Attila Kinali To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] vf_yadif.c - Revision 19836 bug Message-Id: <20061001212155.b446f4ac.attila@kinali.ch> In-Reply-To: <451E9F07.8030301@gmail.com> References: <451E9F07.8030301@gmail.com> Organization: NERV X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.20; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu On Sat, 30 Sep 2006 12:44:55 -0400 sr1515 wrote: > Hi all, > > I am NOT a developer but I've been using the SVN version (and previously > the CVS version) of Mplayer for years. I regularly update my source. > > I simply want to inform your group that ever since revision 19836, > vf_yadif.c has been triggering this compile error: Learn: Bugreports do not belong to -dev-eng unless they contain a patch! Beside, someone already reported this on -users. Attila Kinali -- egp ist vergleichbar mit einem ikea bausatz fuer flugzeugtraeger -- reeler in +kaosu _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 21:40:03 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 28C07126D83 for ; Sun, 1 Oct 2006 21:40:03 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 8F7CA3B16A; Sun, 1 Oct 2006 21:40:00 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 814E83B166 for ; Sun, 1 Oct 2006 21:39:58 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 02630-02-6 for ; Sun, 1 Oct 2006 21:39:58 +0200 (CEST) Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 5D6363B160 for ; Sun, 1 Oct 2006 21:39:58 +0200 (CEST) Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GU7A5-0003FN-BF for mplayer-dev-eng@mplayerhq.hu; Sun, 01 Oct 2006 21:39:41 +0200 Received: from lisk.in ([83.240.29.200]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 01 Oct 2006 21:39:41 +0200 Received: from tomi by lisk.in with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 01 Oct 2006 21:39:41 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: mplayer-dev-eng@mplayerhq.hu From: Tomas Janousek Date: Sun, 01 Oct 2006 21:39:24 +0200 Lines: 12 Message-ID: References: <451E9F07.8030301@gmail.com> <20061001212155.b446f4ac.attila@kinali.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: lisk.in User-Agent: Mozilla/5.0 (X11; U; Linux i686; cs-CZ; rv:1.8.0.4) Gecko/20060629 SeaMonkey/1.0.2 In-Reply-To: <20061001212155.b446f4ac.attila@kinali.ch> X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu Subject: [MPlayer-dev-eng] Re: vf_yadif.c - Revision 19836 bug X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi, Attila Kinali napsal(a): > Beside, someone already reported this on -users. Someone (read: me) posted a patch on -dev-eng, which was finally=20 accepted but not applied. --=20 =2E--------- Tom=E1=9A Janou=9Aek a.k.a. Liskni_si ---------. : NOMI team, developer, http://tomi.nomi.cz/ tomi@nomi.cz : ' JID:liskni_si@jabber.cz, ICQ#161807083, tel:+420608876277 ' _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 21:48:12 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 1E2A3126D83 for ; Sun, 1 Oct 2006 21:48:12 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 9F2623B176; Sun, 1 Oct 2006 21:48:08 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 45E693B16B for ; Sun, 1 Oct 2006 21:48:07 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 32741-03-2 for ; Sun, 1 Oct 2006 21:48:07 +0200 (CEST) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.172]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 278B53B165 for ; Sun, 1 Oct 2006 21:48:07 +0200 (CEST) Received: by ug-out-1314.google.com with SMTP id h2so483995ugf for ; Sun, 01 Oct 2006 12:48:08 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=RMLh4mEPhe6wF+z9aUxu5T8FV4IOllT/eUl/Sw28WmFNkzt/XkCpq/bmpQ6n2RBMbFlv5C7C+fSqGSNRUhejoyJFU7z7q78dlRtH9rCDzauLKI34JJN2CrzPitH4bf5e43VIH1tgFvNf6/GMJOpPliiKNxpcTmV3CCmsafGJ/dg= Received: by 10.67.119.13 with SMTP id w13mr2174780ugm; Sun, 01 Oct 2006 12:48:08 -0700 (PDT) Received: by 10.66.222.2 with HTTP; Sun, 1 Oct 2006 12:48:08 -0700 (PDT) Message-ID: <4e03026a0610011248y591a0708gf18edfab6c45b32d@mail.gmail.com> Date: Sun, 1 Oct 2006 21:48:08 +0200 From: "Guillaume POIRIER" To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] Re: vf_yadif.c - Revision 19836 bug In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <451E9F07.8030301@gmail.com> <20061001212155.b446f4ac.attila@kinali.ch> X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi, On 10/1/06, Tomas Janousek wrote: > Hi, > > Attila Kinali napsal(a): > > Beside, someone already reported this on -users. > > Someone (read: me) posted a patch on -dev-eng, which was finally > accepted but not applied. I was waiting for Reimar to show up and apply it himself, but since he hasn't showed up tonite, I'll apply his patch in a few minutes, so that we can be done with this problem. Guillaume -- With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has a lead on USA on selling out individuals right to corporations! Vive la France! _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 21:51:45 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 7BC07126D83 for ; Sun, 1 Oct 2006 21:51:45 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 567CA3B186; Sun, 1 Oct 2006 21:51:42 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 37BA13B184 for ; Sun, 1 Oct 2006 21:51:40 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 32741-03-9 for ; Sun, 1 Oct 2006 21:51:40 +0200 (CEST) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by natsuki.mplayerhq.hu (Postfix) with SMTP id 0FD283B16B for ; Sun, 1 Oct 2006 21:51:40 +0200 (CEST) Received: (qmail invoked by alias); 01 Oct 2006 19:51:41 -0000 Received: from chello080109116125.4.15.vie.surfer.at (EHLO localhost) [80.109.116.125] by mail.gmx.net (mp042) with SMTP; 01 Oct 2006 21:51:41 +0200 X-Authenticated: #3831892 Date: Sun, 1 Oct 2006 21:49:58 +0200 From: Michael Niedermayer To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] mjpeg yuv422 output from mencoder/mplayer Message-ID: <20061001194957.GP2852@MichaelsNB> References: <200609301246.59119.karolina.lindqvist@kramnet.se> <20060930145816.GA16579@MichaelsNB> <451FD563.4030505@smartjog.com> <20061001161949.GM2852@MichaelsNB> <451FFFE3.3060702@smartjog.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <451FFFE3.3060702@smartjog.com> User-Agent: Mutt/1.5.10i X-Y-GMX-Trusted: 0 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi On Sun, Oct 01, 2006 at 07:50:27PM +0200, Baptiste Coudurier wrote: > Michael Niedermayer a =E9crit : > >Hi > > > >On Sun, Oct 01, 2006 at 04:49:07PM +0200, Baptiste Coudurier wrote: > >>Hi > >> > >>Michael Niedermayer a =E9crit : > >>>Hi > >>> > >>>On Sat, Sep 30, 2006 at 12:46:58PM +0200, Karolina Lindqvist wrote: > >>>>I need something that outputs the MJPEG YUV422 format, that the zoran= =20 > >>>>(zr, zr2) drivers need, but I find nothing in the mencoder/mplayer=20 > >>>>programs that can output that format to disc.=20 > >>>> > >>>>I tried mencoder with -lavcopts vcodec=3Dmjpeg which almost appears t= o do=20 > >>>>the job. Except for that it does not accept format=3D422p. It can onl= y do=20 > >>>>YV12 (YUV420). > >>>a patch which adds 422p jpeg encoding support to lavc would be welcome= =20 > >>>... > >>> > >>>[...] > >>Tried to. I have at least something working in progressive. Problem is= =20 > >>that mpegvideo.c is really hardcoded to 4:2:0 and since DCT on jpeg is= =20 > >>done on 8x8 mb it is quite hard to work around that. > > > >hmm lavc mpeg2 video supports 422 encoding over mpegvideo.c ... > > > >[...] >=20 > Yes. Mpeg2 macroblocks are orderded right out of encode_mb_internal.=20 > Output is 8 blocks: 4 luma blocks, 4 chroma blocks in 4:2:2, and stored= =20 > that way. >=20 > In mjpeg_encode_mb, you will have 8 blocks while they must be coded 2=20 > luma, 2 chroma, in 4:2:2 and 4 others will be on the next line in the=20 > bitstream. what is the problem with coding them like in mpeg2, IIRC the jpeg syntax is flexible enough ... [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In the past you could go to a library and read, borrow or copy any book Today you'd get arrested for mere telling someone where the library is _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 21:52:29 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id C5CD7126D83 for ; Sun, 1 Oct 2006 21:52:29 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 622F33B191; Sun, 1 Oct 2006 21:52:27 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 2525D3B18F for ; Sun, 1 Oct 2006 21:52:26 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 32741-03-13 for ; Sun, 1 Oct 2006 21:52:26 +0200 (CEST) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.172]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 088843B18E for ; Sun, 1 Oct 2006 21:52:25 +0200 (CEST) Received: by ug-out-1314.google.com with SMTP id h2so484220ugf for ; Sun, 01 Oct 2006 12:52:27 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=c0kF+9R0DjBUz+kR5XPMGq91HataZgi2yaXwK6KlDKRz7sH9COQsvoaQeE7ORMbY3UouMSoI4mEm7qxOIxjXu8AxX4iXhTjTvk7gMN2+GMDuwWfDxrOLyxT5l4LQaGPQ1dX0tma8vLRimJtJ+/FX1eXm5nsJFU83kqnwwlW7jFs= Received: by 10.67.24.13 with SMTP id b13mr2177156ugj; Sun, 01 Oct 2006 12:52:27 -0700 (PDT) Received: by 10.66.222.2 with HTTP; Sun, 1 Oct 2006 12:52:27 -0700 (PDT) Message-ID: <4e03026a0610011252n1b0214e4m8f4810eb223ad755@mail.gmail.com> Date: Sun, 1 Oct 2006 21:52:27 +0200 From: "Guillaume POIRIER" To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] vf_yadif.c: fix for (probably) older binutils In-Reply-To: <20061001161242.GL2852@MichaelsNB> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20061001144212.GA31010@1und1.de> <20061001161242.GL2852@MichaelsNB> X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi, On 10/1/06, Michael Niedermayer wrote: > Hi > > On Sun, Oct 01, 2006 at 04:42:12PM +0200, Reimar D=F6ffinger wrote: > > Hello, > > On Thu, Sep 21, 2006 at 11:17:55PM +0200, Tomas Janousek wrote: > > > my as does not understand "-1-1(something)", so I changed it to "0-1-= 1" > > > and so on. > > > > > > I have binutils-2.15.90.0.3-5 on Fedora Core 2. > > > > So is this patch or the attached one or something completely different = preferable? > > ive no real objections to it Applied (I got bugged by the continuous flow of ppl who complain with this problem.... plus, Reimar's stuff is usually 100% gold guaranteed, so... ) Guillaume --=20 With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has a lead on USA on selling out individuals right to corporations! Vive la France! _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Sun Oct 1 22:31:39 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id A277A126D83 for ; Sun, 1 Oct 2006 22:31:39 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 44C7F3B178; Sun, 1 Oct 2006 22:31:36 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 570713B15B for ; Sun, 1 Oct 2006 22:31:34 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 10684-01-3 for ; Sun, 1 Oct 2006 22:31:34 +0200 (CEST) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.171]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 299A73B024 for ; Sun, 1 Oct 2006 22:31:34 +0200 (CEST) Received: by ug-out-1314.google.com with SMTP id h2so486693ugf for ; Sun, 01 Oct 2006 13:31:35 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:mime-version:content-type; b=IpeQvkQZ2IzTTdT0KFN8khqziaK7rxIwCs64Qm+neHsJZsTevqQehlxr7bVmKhAvfWACBgx5iJIg6hKi0wwmEMH8+3xI48ogz9J2P8RvG0LOaEPZ6YcOuzAizPDUbb54tvcYeh59HkIFj2EiuFBaBxZTE02gyB3773WyzexNAy4= Received: by 10.67.101.8 with SMTP id d8mr2202321ugm; Sun, 01 Oct 2006 13:31:35 -0700 (PDT) Received: by 10.66.222.2 with HTTP; Sun, 1 Oct 2006 13:31:35 -0700 (PDT) Message-ID: <4e03026a0610011331y5d72f90dt5093abb14fbbbdb0@mail.gmail.com> Date: Sun, 1 Oct 2006 22:31:35 +0200 From: "Guillaume POIRIER" To: MPlayer-ML MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_5780_31673187.1159734695724" X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu Subject: [MPlayer-dev-eng] [PATCH] add support for latest x264 options X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu ------=_Part_5780_31673187.1159734695724 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi there, Attached patch does $SUBJ. The doc part can be improved I imagine, but I lack the technical background to do so. Please review. Guillaume -- With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has a lead on USA on selling out individuals right to corporations! Vive la France! ------=_Part_5780_31673187.1159734695724 Content-Type: text/plain; name=x264-r575-sync.diff; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_esrvzosm Content-Disposition: attachment; filename="x264-r575-sync.diff" SW5kZXg6IGxpYm1wY29kZWNzL3ZlX3gyNjQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsaWJtcGNvZGVjcy92 ZV94MjY0LmMJKHLDqXZpc2lvbiAyMDAxNSkKKysrIGxpYm1wY29kZWNzL3ZlX3gyNjQuYwkoY29w aWUgZGUgdHJhdmFpbCkKQEAgLTEyMCw2ICsxMjAsMTAgQEAKIHN0YXRpYyBjaGFyICpjcW04aXkg PSBOVUxMOwogc3RhdGljIGNoYXIgKmNxbThweSA9IE5VTEw7CiBzdGF0aWMgaW50IGdsb2JhbGhl YWRlcj0wOworc3RhdGljIGludCBkaXJlY3RfOHg4ID0gLTE7CitzdGF0aWMgaW50IGRlYWR6b25l X2ludGVyID0gMjE7CitzdGF0aWMgaW50IGRlYWR6b25lX2ludHJhID0gMTE7CitzdGF0aWMgaW50 IGludGVybGFjZWQgPSAwOwogCiBtX29wdGlvbl90IHgyNjRlbmNvcHRzX2NvbmZbXSA9IHsKICAg ICB7ImJpdHJhdGUiLCAmYml0cmF0ZSwgQ09ORl9UWVBFX0lOVCwgQ09ORl9SQU5HRSwgMCwgMjQw MDAwMDAsIE5VTEx9LApAQCAtMjA3LDYgKzIxMSwxMSBAQAogICAgIHsibm92aXN1YWxpemUiLCAm dmlzdWFsaXplLCBDT05GX1RZUEVfRkxBRywgMCwgMSwgMCwgTlVMTH0sCiAgICAgeyJnbG9iYWwi LCAmZ2xvYmFsaGVhZGVyLCBDT05GX1RZUEVfRkxBRywgMCwgMCwgMSwgTlVMTH0sCiAgICAgeyJu b2dsb2JhbCIsICZnbG9iYWxoZWFkZXIsIENPTkZfVFlQRV9GTEFHLCAwLCAxLCAwLCBOVUxMfSwK KyAgICB7ImRpcmVjdF84eDgiLCAmZGlyZWN0Xzh4OCwgQ09ORl9UWVBFX0lOVCwgQ09ORl9SQU5H RSwgLTEsIDEsIE5VTEx9LAorICAgIHsiZGVhZHpvbmVfaW50ZXIiLCAmZGVhZHpvbmVfaW50ZXIs IENPTkZfVFlQRV9JTlQsIENPTkZfUkFOR0UsIDAsIDMyLCBOVUxMfSwKKyAgICB7ImRlYWR6b25l X2ludHJhIiwgJmRlYWR6b25lX2ludHJhLCBDT05GX1RZUEVfSU5ULCBDT05GX1JBTkdFLCAwLCAz MiwgTlVMTH0sCisgICAgeyJpbnRlcmxhY2VkIiwgJmludGVybGFjZWQsIENPTkZfVFlQRV9GTEFH LCAwLCAwLCAxLCBOVUxMfSwKKyAgICB7Im5vaW50ZXJsYWNlZCIsICZpbnRlcmxhY2VkLCBDT05G X1RZUEVfRkxBRywgMCwgMCwgMCwgTlVMTH0sCiAgICAge05VTEwsIE5VTEwsIDAsIDAsIDAsIDAs IE5VTEx9CiB9OwogCkBAIC0zNDIsNiArMzUxLDEwIEBACiAgICAgbW9kLT5wYXJhbS52dWkuaV9z YXJfaGVpZ2h0ID0gZF9oZWlnaHQqd2lkdGg7CiAgICAgbW9kLT5wYXJhbS5pX3RocmVhZHMgPSB0 aHJlYWRzOwogICAgIGlmKGdsb2JhbGhlYWRlcikgbW9kLT5wYXJhbS5iX3JlcGVhdF9oZWFkZXJz ID0gMDsKKyAgICBtb2QtPnBhcmFtLmFuYWx5c2UuaV9kaXJlY3RfOHg4X2luZmVyZW5jZSA9IGRp cmVjdF84eDg7CisgICAgbW9kLT5wYXJhbS5iX2ludGVybGFjZWQgPSBpbnRlcmxhY2VkOworICAg IG1vZC0+cGFyYW0uYW5hbHlzZS5pX2x1bWFfZGVhZHpvbmVbMF0gPSBkZWFkem9uZV9pbnRlcjsK KyAgICBtb2QtPnBhcmFtLmFuYWx5c2UuaV9sdW1hX2RlYWR6b25lWzFdID0gZGVhZHpvbmVfaW50 cmE7CiAKICAgICBpZihjcW0gIT0gTlVMTCkKICAgICB7CkluZGV4OiBET0NTL21hbi9lbi9tcGxh eWVyLjEKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gRE9DUy9tYW4vZW4vbXBsYXllci4xCShyw6l2aXNpb24gMjAw MTUpCisrKyBET0NTL21hbi9lbi9tcGxheWVyLjEJKGNvcGllIGRlIHRyYXZhaWwpCkBAIC05Mjcw LDYgKzkyNzAsMTAgQEAKIC5SRQogLgogLlRQCisuQiAobm8paW50ZXJsYWNlZAorZW5hYmxlIHB1 cmUtaW50ZXJsYWNlZCBtb2RlCisuCisuVFAKIC5CIGRpcmVjdF9wcmVkPTwwXC0zPgogRGV0ZXJt aW5lcyB0aGUgdHlwZSBvZiBtb3Rpb24gcHJlZGljdGlvbiB1c2VkIGZvciBkaXJlY3QgbWFjcm9i bG9ja3MKIGluIEItZnJhbWVzLgpAQCAtOTI5NCw2ICs5Mjk4LDIwIEBACiAuUkUKIC4KIC5UUAor LkIgZGlyZWN0Xzh4OD08LTFcLTE+CitkaXJlY3QgcHJlZGljdGlvbiBzaXplCisuUEQgMAorLlJT cworLklQcyAtMQorc21hbGxlc3QgcG9zc2libGUgYWNjb3JkaW5nIHRvIGxldmVsIChkZWZhdWx0 KQorLklQcyAwCis0eDQKKy5JUHMgMQorOHg4CisuUkUKKy5QRCAxCisuCisuVFAKIC5CIChubyl3 ZWlnaHRfYgogVXNlIHdlaWdodGVkIHByZWRpY3Rpb24gaW4gQi1mcmFtZXMuCiBXaXRob3V0IHRo aXMgb3B0aW9uLCBiaWRpcmVjdGlvbmFsbHkgcHJlZGljdGVkIG1hY3JvYmxvY2tzIGdpdmUKQEAg LTk0MzMsNiArOTQ1MSwxNiBAQAogVGhpcyBvcHRpb24gaGFzIG5vIGVmZmVjdCB3aXRob3V0IEIt ZnJhbWVzLgogLgogLlRQCisuQiBkZWFkem9uZV9pbnRlcj08MFwtMzI+CitzZXQgdGhlIHNpemUg b2YgdGhlIGludGVyIGx1bWEgcXVhbnRpemF0aW9uIGRlYWR6b25lIGZvciBub24tdHJlbGxpcwor cXVhbnRpemF0aW9uIChkZWZhdWx0OiAyMSkKKy4KKy5UUAorLkIgZGVhZHpvbmVfaW50cmE9PDBc LTMyPgorc2V0IHRoZSBzaXplIG9mIHRoZSBpbnRyYSBsdW1hIHF1YW50aXphdGlvbiBkZWFkem9u ZSBmb3Igbm9uLXRyZWxsaXMKK3F1YW50aXphdGlvbiAoZGVmYXVsdDogMTEpCisuCisuVFAKIC5C IHRyZWxsaXM9PDBcLTI+CiByYXRlLWRpc3RvcnRpb24gb3B0aW1hbCBxdWFudGl6YXRpb24KIC5Q RCAwCg== ------=_Part_5780_31673187.1159734695724 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng ------=_Part_5780_31673187.1159734695724-- From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 00:23:29 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id CF16A126D83 for ; Mon, 2 Oct 2006 00:23:29 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 45C6F3B19B; Mon, 2 Oct 2006 00:23:25 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id DF17F3B18B for ; Mon, 2 Oct 2006 00:23:22 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 24037-03 for ; Mon, 2 Oct 2006 00:23:22 +0200 (CEST) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.183]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 97E0E3B17C for ; Mon, 2 Oct 2006 00:23:22 +0200 (CEST) Received: from [212.117.93.214] (helo=localhost.localdomain) by mrelayeu.kundenserver.de (node=mrelayeu0) with ESMTP (Nemesis), id 0MKwh2-1GU9iV0eJ4-0000rH; Mon, 02 Oct 2006 00:23:24 +0200 Received: by localhost.localdomain (sSMTP sendmail emulation); Mon, 2 Oct 2006 00:23:22 +0200 Date: Mon, 2 Oct 2006 00:23:22 +0200 From: Diego Biurrun To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] [PATCH] double click to switch to full screen in GUI Message-ID: <20061001222322.GC2167@biurrun.de> References: <4502FE79.80701@laposte.net> <20060910050021.GC2246@biurrun.de> <4503F73B.6030706@laposte.net> <20060912081334.GD8252@biurrun.de> <4506F479.6050202@laposte.net> <20060913230300.GC2420@biurrun.de> <20060914034028.GA27034@brightrain.aerifal.cx> <4509C56B.5060508@laposte.net> <20060929161656.GC4702@1und1.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="PmA2V3Z32TCmWXqI" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20060929161656.GC4702@1und1.de> User-Agent: Mutt/1.5.13 (2006-08-11) X-Provags-ID: kundenserver.de abuse@kundenserver.de login:cda85dccaaeec2d03fac572ff7daa982 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu --PmA2V3Z32TCmWXqI Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, Sep 29, 2006 at 06:16:56PM +0200, Reimar Döffinger wrote: > On Thu, Sep 14, 2006 at 11:11:07PM +0200, laurent wozniak wrote: > > gtkInit(); > > +// --- initialize some input constants > > + g_object_get ( G_OBJECT ( gtk_settings_get_default() ), > > + "gtk-double-click-time", &double_click_time, NULL ); > > + mp_input_set_double_click_time(double_click_time); > > I don't care much, but it should be tested if this works with GTK1 Apparently it does not, I get linking errors 'undefined reference to gtk_settings_get_default'. Some sort of solution is needed. This part of the code can be dropped, protected by #ifdef or support for GTK 1.x dropped. > > @@ -305,6 +307,7 @@ > > > > static mp_cmd_bind_t def_cmd_binds[] = { > > > > + { { MOUSE_BTN0_DBL, 0 }, "vo_fullscreen" }, > > I'd prefer it not to be bound by default. I strongly disagree. Pretty much every player goes into fullscreen on doubleclick. I'm not aware of any that doesn't... > > +// Mouse button double click time > > +// Default value may be overridden during the gui initialization > > +static unsigned int double_click_time = 300; > > + > > probably should be a command line option. Oh dear, another one? > > + // When binding a command to a mouse button double click, > > + // if the corresponding single click is not bound, > > + // bind it to the command which does nothing: > > + // Avoid logging command not found on the first click of the double click. > > + for(j = 0 ; (key = keys[j]) != 0 ; j++) { > > + if (MOUSE_BTN0_DBL <= key && key <= MOUSE_BTN_LAST_DBL) { > > + key = MOUSE_BTN0 + key - MOUSE_BTN0_DBL; > > + other_cmd = mp_input_find_bind_for_key(1, &key); > > + if (other_cmd == NULL) { > > + int other_cmd_keys[2]; > > + other_cmd_keys[0] = key; > > + other_cmd_keys[1] = 0; > > + mp_input_bind_keys(other_cmd_keys, MP_CMD_TXT_NO_COMMAND); > > + } > > + } > > + } > > + > > I find the (IMHO doubtful since possibly confusing) convenience of not having > to add a no_command keybind not worth even that few lines of code. I'm a bit sceptical myself here, but the convenience is real .. > > +void mplayer_put_key(int code) { > > + unsigned int now; > > + int btn; > > + int ignore; > > + > > + ignore = code & MP_VETOED_KEY; > > + code &= ~MP_VETOED_KEY; > > + > > + // Check mouse button press event > > + if ((MOUSE_BTN0 | MP_KEY_DOWN) <= code && code <= (MOUSE_BTN_LAST | MP_KEY_DOWN)) { > > + btn = code - (MOUSE_BTN0 | MP_KEY_DOWN); > > trailing whitespace... I've cleaned up the patch a bit, removing trailing whitespace, reformatting code to match the file it's in and improving some comments. I'm attaching the patch so we can use this as the new baseline for discussions. Diego --PmA2V3Z32TCmWXqI Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="double_click.diff" Index: Gui/interface.c =================================================================== --- Gui/interface.c (revision 19814) +++ Gui/interface.c (working copy) @@ -202,6 +202,7 @@ void guiInit( void ) { + gint doubleclick_time; int i; memset( &guiIntfStruct,0,sizeof( guiIntfStruct ) ); @@ -217,6 +218,10 @@ if ( autosync && autosync != gtkAutoSync ) { gtkAutoSyncOn=1; gtkAutoSync=autosync; } gtkInit(); +// --- initialize some input constants + g_object_get ( G_OBJECT ( gtk_settings_get_default() ), + "gtk-double-click-time", &doubleclick_time, NULL ); + mp_input_set_doubleclick_time(doubleclick_time); // --- initialize X wsXInit( (void *)mDisplay ); // --- load skin Index: Gui/mplayer/sw.c =================================================================== --- Gui/mplayer/sw.c (revision 19814) +++ Gui/mplayer/sw.c (working copy) @@ -12,6 +12,11 @@ #include "../help_mp.h" #include "widgets.h" +#include "../input/input.h" +#include "../input/mouse.h" + +extern void mplayer_put_key(int code); + int mplSubRender = 0; int SubVisible = 0; @@ -43,10 +48,17 @@ static int mplSubMoved = 0; static int msButton = 0; + int btn, veto; + mplPBShow( X,Y ); + + /* Activate mouse event veto by default. */ + veto = MP_VETOED_KEY; switch( Button ) { + case wsPRMouseButton: + break; case wsRRMouseButton: gtkShow( evShowPopUpMenu,NULL ); break; @@ -88,5 +101,18 @@ msButton=0; mplSubMoved=0; break; +// --- + default: + /* Mouse event not handled, remove veto. */ + veto = 0; } + + if ( wsP0MouseButton <= Button && Button <= wsPLastMouseButton ) { + btn = Button - wsP0MouseButton; + mplayer_put_key((MOUSE_BTN0 + btn) | veto | MP_KEY_DOWN); + } + else if ( wsR0MouseButton <= Button && Button <= wsRLastMouseButton ) { + btn = Button - wsR0MouseButton; + mplayer_put_key((MOUSE_BTN0 + btn) | veto); + } } Index: Gui/wm/ws.h =================================================================== --- Gui/wm/ws.h (revision 19814) +++ Gui/wm/ws.h (working copy) @@ -29,11 +29,15 @@ #define wsPRMouseButton 3 #define wsP4MouseButton 4 #define wsP5MouseButton 5 -#define wsRLMouseButton 1 + 128 -#define wsRMMouseButton 2 + 128 -#define wsRRMouseButton 3 + 128 -#define wsR4MouseButton 4 + 128 -#define wsR5MouseButton 5 + 128 +#define wsP0MouseButton wsPLMouseButton +#define wsPLastMouseButton 10 +#define wsRLMouseButton (1 + 128) +#define wsRMMouseButton (2 + 128) +#define wsRRMouseButton (3 + 128) +#define wsR4MouseButton (4 + 128) +#define wsR5MouseButton (5 + 128) +#define wsR0MouseButton wsRLMouseButton +#define wsRLastMouseButton (10 + 128) #define wsEnterWindow 253 #define wsLeaveWindow 254 #define wsMoveMouse 255 Index: fifo.c =================================================================== --- fifo.c (revision 19814) +++ fifo.c (working copy) @@ -25,7 +25,7 @@ set_nonblock_flag(temp[1]); } -void mplayer_put_key(int code){ +void mplayer_put_key_internal(int code){ if( write(keyb_fifo_put,&code,4) != 4 ){ mp_msg(MSGT_INPUT,MSGL_ERR,"*** key event dropped (FIFO is full) ***\n"); @@ -39,8 +39,8 @@ static int key_fifo_read=0; static int key_fifo_write=0; -void mplayer_put_key(int code){ -// printf("mplayer_put_key(%d)\n",code); +void mplayer_put_key_internal(int code){ +// printf("mplayer_put_key_internal(%d)\n",code); if (key_fifo_data == NULL) key_fifo_data = malloc(key_fifo_size * sizeof(int)); if(((key_fifo_write+1)%key_fifo_size)==key_fifo_read) return; // FIFO FULL!! Index: input/input.c =================================================================== --- input/input.c (revision 19814) +++ input/input.c (working copy) @@ -35,6 +35,8 @@ #include #endif +#define MP_CMD_TXT_NO_COMMAND "no_command" + /// This array defines all known commands. /// The first field is an id used to recognize the command without too many strcmp. /// The second is obviously the command name. @@ -305,6 +307,7 @@ static mp_cmd_bind_t def_cmd_binds[] = { + { { MOUSE_BTN0_DBL, 0 }, "vo_fullscreen" }, { { MOUSE_BTN3, 0 }, "seek 10" }, { { MOUSE_BTN4, 0 }, "seek -10" }, { { MOUSE_BTN5, 0 }, "volume 1" }, @@ -495,6 +498,10 @@ static mp_cmd_t* ar_cmd = NULL; static unsigned int ar_delay = 100, ar_rate = 8, last_ar = 0; +// Mouse button doubleclick time, default value may be overridden +// during the GUI initialization. +static unsigned int doubleclick_time = 300; + static int use_joystick = 1, use_lirc = 1, use_lircc = 1; static char* config_file = "input.conf"; @@ -877,9 +884,14 @@ static char* -mp_input_find_bind_for_key(mp_cmd_bind_t* binds, int n,int* keys) { +mp_input_find_bind_for_key(int n, int* keys) { + mp_cmd_bind_t* binds; int j; + binds = cmd_binds; + if (binds == NULL) + return NULL; + for(j = 0; binds[j].cmd != NULL; j++) { if(n > 0) { int found = 1,s; @@ -903,24 +915,27 @@ static mp_cmd_t* mp_input_get_cmd_from_keys(int n,int* keys, int paused) { - char* cmd = NULL; + char* cmd; mp_cmd_t* ret; - if(cmd_binds) - cmd = mp_input_find_bind_for_key(cmd_binds,n,keys); - if(cmd == NULL) - cmd = mp_input_find_bind_for_key(def_cmd_binds,n,keys); + for(;;) { + cmd = mp_input_find_bind_for_key(n,keys); + // Found a command. + if(cmd != NULL) { + if (strcmp(cmd, MP_CMD_TXT_NO_COMMAND) == 0) + return NULL; + break; + } - if(cmd == NULL) { + // Ignore unbound key. mp_msg(MSGT_INPUT,MSGL_WARN,MSGTR_NoBindFound,mp_input_get_key_name(keys[0])); - if(n > 1) { - int s; - for(s=1; s < n; s++) - mp_msg(MSGT_INPUT,MSGL_WARN,"-%s",mp_input_get_key_name(keys[s])); - } mp_msg(MSGT_INPUT,MSGL_WARN," \n"); - return NULL; + keys++; + n--; + if(n<=0) + return NULL; } + ret = mp_input_parse_cmd(cmd); if(!ret) { mp_msg(MSGT_INPUT,MSGL_ERR,MSGTR_INPUT_INPUT_ErrInvalidCommandForKey,mp_input_get_key_name(key_down[0])); @@ -1382,6 +1397,8 @@ void mp_input_bind_keys(int keys[MP_MAX_KEY_DOWN+1], char* cmd) { int i = 0,j; + int key; + char* other_cmd; mp_cmd_bind_t* bind = NULL; #ifdef MP_DEBUG @@ -1389,6 +1406,23 @@ assert(cmd != NULL); #endif + /* When binding a command to a mouse button doubleclick, if the + * corresponding single click is not bound, bind it to the + * command which does nothing in order to avoid logging command + * not found on the first click of the doubleclick. */ + for(j = 0 ; (key = keys[j]) != 0 ; j++) { + if (MOUSE_BTN0_DBL <= key && key <= MOUSE_BTN_LAST_DBL) { + key = MOUSE_BTN0 + key - MOUSE_BTN0_DBL; + other_cmd = mp_input_find_bind_for_key(1, &key); + if (other_cmd == NULL) { + int other_cmd_keys[2]; + other_cmd_keys[0] = key; + other_cmd_keys[1] = 0; + mp_input_bind_keys(other_cmd_keys, MP_CMD_TXT_NO_COMMAND); + } + } + } + if(cmd_binds) { for(i = 0; cmd_binds[i].cmd != NULL ; i++) { for(j = 0 ; cmd_binds[i].input[j] == keys[j] && keys[j] != 0 ; j++) @@ -1594,6 +1628,9 @@ mp_input_init(int use_gui) { char* file; + // Bind default keys, thus ensure cmd_binds is allocated. + mp_input_add_binds(def_cmd_binds); + #ifdef HAVE_NEW_GUI if(use_gui) mp_input_add_binds(gui_def_cmd_binds); @@ -1743,3 +1780,67 @@ mp_cmd_free(cmd); return 0; } + +unsigned int +mp_input_get_doubleclick_time() { + return doubleclick_time; +} + +void +mp_input_set_doubleclick_time(unsigned int time) { + doubleclick_time = time; +} + + +extern void mplayer_put_key_internal(int code); + +static unsigned int mouse_button_press_timer = 0; +static int last_pressed_mouse_button; + +// This puts key layer filter events. +// It can translate the event into another one. +void mplayer_put_key(int code) { + unsigned int now; + int btn, ignore; + + ignore = code & MP_VETOED_KEY; + code &= ~MP_VETOED_KEY; + + // Check mouse button press event. + if ((MOUSE_BTN0 | MP_KEY_DOWN) <= code && + code <= (MOUSE_BTN_LAST | MP_KEY_DOWN)) { + btn = code - (MOUSE_BTN0 | MP_KEY_DOWN); + // Translate mouse wheel: Interpret press event as release event. + if (btn == 3 || btn == 4) + code = MOUSE_BTN0 + btn; + // Detect mouse doubleclick. + else { + now = GetTimerMS(); + if (btn == last_pressed_mouse_button && + now - mouse_button_press_timer <= mp_input_get_doubleclick_time()) { + mouse_button_press_timer = 0; + // Translate mouse doubleclick: Create new event. + code = MOUSE_BTN0_DBL + btn; + ignore = 0; + } + else { + mouse_button_press_timer = now; + last_pressed_mouse_button = btn; + } + } + } + // Translate mouse wheel: Ignore simulated release event. + else if (code == MOUSE_BTN3 || code == MOUSE_BTN4) + ignore = 1; + // Translate mouse wheel: Convert to mouse button release event. + else if (code == MOUSE_WHL_UP) + code = MOUSE_BTN3; + else if (code == MOUSE_WHL_DOWN) + code = MOUSE_BTN4; + // Process mouse doubleclick. + else if (MOUSE_BTN0_DBL <= code && code <= MOUSE_BTN_LAST_DBL) + mouse_button_press_timer = 0; + + if (!ignore) + mplayer_put_key_internal(code); +} Index: input/input.h =================================================================== --- input/input.h (revision 19814) +++ input/input.h (working copy) @@ -147,6 +147,8 @@ #define MP_KEY_DOWN (1<<29) // Use this when the key shouldn't be auto-repeated (like mouse buttons) #define MP_NO_REPEAT_KEY (1<<28) +// Use this to notify of the key event while performing no action. +#define MP_VETOED_KEY (1<<27) #ifndef MP_MAX_KEY_DOWN #define MP_MAX_KEY_DOWN 32 @@ -260,3 +262,9 @@ int mp_input_check_interrupt(int time); +// mouse button doubleclick time +unsigned int +mp_input_get_doubleclick_time(); + +void +mp_input_set_doubleclick_time(unsigned int time); Index: input/mouse.h =================================================================== --- input/mouse.h (revision 19814) +++ input/mouse.h (working copy) @@ -11,8 +11,14 @@ #define MOUSE_BTN7 (MOUSE_BASE+7) #define MOUSE_BTN8 (MOUSE_BASE+8) #define MOUSE_BTN9 (MOUSE_BASE+9) +#define MOUSE_BTN_LAST MOUSE_BTN9 + +#define MOUSE_BASE_EXT (0x300|MP_NO_REPEAT_KEY) -#define MOUSE_BASE_DBL (0x300|MP_NO_REPEAT_KEY) +#define MOUSE_WHL_UP (MOUSE_BASE_EXT+0) +#define MOUSE_WHL_DOWN (MOUSE_BASE_EXT+1) + +#define MOUSE_BASE_DBL (MOUSE_BASE_EXT+2) #define MOUSE_BTN0_DBL (MOUSE_BASE_DBL+0) #define MOUSE_BTN1_DBL (MOUSE_BASE_DBL+1) #define MOUSE_BTN2_DBL (MOUSE_BASE_DBL+2) @@ -23,3 +29,4 @@ #define MOUSE_BTN7_DBL (MOUSE_BASE_DBL+7) #define MOUSE_BTN8_DBL (MOUSE_BASE_DBL+8) #define MOUSE_BTN9_DBL (MOUSE_BASE_DBL+9) +#define MOUSE_BTN_LAST_DBL MOUSE_BTN9_DBL Index: libvo/vo_directx.c =================================================================== --- libvo/vo_directx.c (revision 19814) +++ libvo/vo_directx.c (working copy) @@ -1019,9 +1019,9 @@ break; int x = GET_WHEEL_DELTA_WPARAM(wParam); if (x > 0) - mplayer_put_key(MOUSE_BTN3); + mplayer_put_key(MOUSE_WHL_UP); else - mplayer_put_key(MOUSE_BTN4); + mplayer_put_key(MOUSE_WHL_DOWN); break; } case WM_XBUTTONDOWN: Index: libvo/vo_quartz.c =================================================================== --- libvo/vo_quartz.c (revision 19814) +++ libvo/vo_quartz.c (working copy) @@ -300,9 +300,9 @@ if(part == inContent) { if(wheel > 0) - mplayer_put_key(MOUSE_BTN3); + mplayer_put_key(MOUSE_WHL_UP); else - mplayer_put_key(MOUSE_BTN4); + mplayer_put_key(MOUSE_WHL_DOWN); } } break; Index: libvo/vo_sdl.c =================================================================== --- libvo/vo_sdl.c (revision 19814) +++ libvo/vo_sdl.c (working copy) @@ -1189,10 +1189,7 @@ case SDL_MOUSEBUTTONDOWN: if(vo_nomouse_input) break; - if(event.button.button == 4 || event.button.button == 5) - mplayer_put_key(MOUSE_BASE+event.button.button-1); - else - mplayer_put_key((MOUSE_BASE+event.button.button-1) | MP_KEY_DOWN); + mplayer_put_key((MOUSE_BTN0+event.button.button-1) | MP_KEY_DOWN); break; case SDL_MOUSEBUTTONUP: @@ -1198,7 +1195,7 @@ case SDL_MOUSEBUTTONUP: if(vo_nomouse_input) break; - mplayer_put_key(MOUSE_BASE+event.button.button-1); + mplayer_put_key(MOUSE_BTN0+event.button.button-1); break; /* graphics mode selection shortcuts */ Index: libvo/w32_common.c =================================================================== --- libvo/w32_common.c (revision 19814) +++ libvo/w32_common.c (working copy) @@ -114,9 +114,9 @@ if (!vo_nomouse_input) { int x = GET_WHEEL_DELTA_WPARAM(wParam); if (x > 0) - mplayer_put_key(MOUSE_BTN3); + mplayer_put_key(MOUSE_WHL_UP); else - mplayer_put_key(MOUSE_BTN4); + mplayer_put_key(MOUSE_WHL_DOWN); break; } } Index: libvo/x11_common.c =================================================================== --- libvo/x11_common.c (revision 19814) +++ libvo/x11_common.c (working copy) @@ -1098,17 +1098,8 @@ mouse_waiting_hide = 1; mouse_timer = GetTimerMS(); } - // Ignore mouse whell press event - if (Event.xbutton.button > 3) - { - mplayer_put_key(MOUSE_BTN0 + Event.xbutton.button - 1); - break; - } #ifdef HAVE_NEW_GUI - // Ignor mouse button 1 - 3 under gui - if (use_gui && (Event.xbutton.button >= 1) - && (Event.xbutton.button <= 3)) - break; + if ( use_gui ) { break; } #endif mplayer_put_key((MOUSE_BTN0 + Event.xbutton.button - 1) | MP_KEY_DOWN); @@ -1121,10 +1112,7 @@ mouse_timer = GetTimerMS(); } #ifdef HAVE_NEW_GUI - // Ignor mouse button 1 - 3 under gui - if (use_gui && (Event.xbutton.button >= 1) - && (Event.xbutton.button <= 3)) - break; + if ( use_gui ) { break; } #endif mplayer_put_key(MOUSE_BTN0 + Event.xbutton.button - 1); break; --PmA2V3Z32TCmWXqI Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng --PmA2V3Z32TCmWXqI-- From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 00:28:15 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 442D3126D83 for ; Mon, 2 Oct 2006 00:28:15 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id AB2A13B1A9; Mon, 2 Oct 2006 00:28:11 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 078933B19A for ; Mon, 2 Oct 2006 00:28:10 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 22465-04 for ; Mon, 2 Oct 2006 00:28:09 +0200 (CEST) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id D74093B18B for ; Mon, 2 Oct 2006 00:28:09 +0200 (CEST) Received: from [212.117.93.214] (helo=localhost.localdomain) by mrelayeu.kundenserver.de (node=mrelayeu4) with ESMTP (Nemesis), id 0ML21M-1GU9n82YW9-0002iq; Mon, 02 Oct 2006 00:28:11 +0200 Received: by localhost.localdomain (sSMTP sendmail emulation); Mon, 2 Oct 2006 00:28:10 +0200 Date: Mon, 2 Oct 2006 00:28:10 +0200 From: Diego Biurrun To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] [PATCH] add support for latest x264 options Message-ID: <20061001222810.GD2167@biurrun.de> References: <4e03026a0610011331y5d72f90dt5093abb14fbbbdb0@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e03026a0610011331y5d72f90dt5093abb14fbbbdb0@mail.gmail.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-Provags-ID: kundenserver.de abuse@kundenserver.de login:cda85dccaaeec2d03fac572ff7daa982 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu On Sun, Oct 01, 2006 at 10:31:35PM +0200, Guillaume POIRIER wrote: > > Please review. > > --- DOCS/man/en/mplayer.1 (r??vision 20015) > +++ DOCS/man/en/mplayer.1 (copie de travail) > @@ -9270,6 +9270,10 @@ > .RE > . > .TP > +.B (no)interlaced > +enable pure-interlaced mode Capitalize, add period. > @@ -9433,6 +9451,16 @@ > .TP > +.B deadzone_inter=<0\-32> > +set the size of the inter luma quantization deadzone for non-trellis > +quantization (default: 21) dito > +.B deadzone_intra=<0\-32> > +set the size of the intra luma quantization deadzone for non-trellis > +quantization (default: 11) dito Diego _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 00:32:34 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 7B646126D83 for ; Mon, 2 Oct 2006 00:32:34 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id A1C983B0CF; Mon, 2 Oct 2006 00:32:30 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 248953B0BE for ; Mon, 2 Oct 2006 00:32:28 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 22465-04-8 for ; Mon, 2 Oct 2006 00:32:28 +0200 (CEST) Received: from mail.fatooh.org (fire.casa-z.org [66.93.171.141]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 86FCE3B0B1 for ; Mon, 2 Oct 2006 00:32:27 +0200 (CEST) Received: from localhost (fire [127.0.0.1]) by mail.fatooh.org (Postfix) with ESMTP id D013CC34EF for ; Sun, 1 Oct 2006 15:32:25 -0700 (PDT) Received: from mail.fatooh.org ([127.0.0.1]) by localhost (fire.fatooh.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CjYgjEl+WMI2 for ; Sun, 1 Oct 2006 15:32:25 -0700 (PDT) Received: from [10.1.0.0] (c-24-5-192-235.hsd1.ca.comcast.net [24.5.192.235]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.fatooh.org (Postfix) with ESMTP id 52DD6C2713 for ; Sun, 1 Oct 2006 15:32:25 -0700 (PDT) Message-ID: <452041FD.9070402@fatooh.org> Date: Sun, 01 Oct 2006 15:32:29 -0700 From: Corey Hickey User-Agent: Thunderbird 1.5.0.7 (X11/20060928) MIME-Version: 1.0 To: mplayer-dev-eng@mplayerhq.hu Content-Type: multipart/mixed; boundary="------------020104030107070004090807" X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu Subject: [MPlayer-dev-eng] [PATCH][RFC] ve_xvid4: make PSNR printing more consistent with other encoders X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu This is a multi-part message in MIME format. --------------020104030107070004090807 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hello, The attached patch makes the PSNR printing in ve_xvid4 look more consistent with the other encoders (mostly ve_lavc and ve_xvid). ------without the patch------ xvid: Min PSNR y : 35.68 dB, u : 40.13 dB, v : 41.10 dB, in frame 1 xvid: Average PSNR y : 38.83 dB, u : 41.61 dB, v : 42.68 dB, for 142 frames xvid: Max PSNR y : 42.39 dB, u : 44.05 dB, v : 44.96 dB, in frame 104 ----------------------------- (the wrapping above is from my mail client, not mencoder) -------with the patch-------- xvid: Min PSNR Y:35.68, Cb:40.13, Cr:41.10, All:36.79 in frame 1 xvid: Average PSNR Y:38.83, Cb:41.61, Cr:42.68, All:39.67 for 142 frames xvid: Max PSNR Y:42.39, Cb:44.05, Cr:44.96, All:42.98 in frame 104 ----------------------------- There are four differences: 1. removal of "dB" None of the other encoders display the units. I could say e.g. "Min PSNR(dB)" instead, if anyone thinks the units are important here. 2. removal of some whitespace I think it's easier to read this way, but my eyes might just be trained because the other encoders look like that. 3. change "u" to "Cb" and "v" to "Cr" This change is correct, isn't it? ve_xvid and ve_lavc print "YCbCr", whereas x264 (not ve_x264, but the library itself) prints YUV. 4. add PSNR for all pixels ...calculated the same way as in ve_xvid and ve_lavc. This is actually the only change I care about, but the others seemed reasonable. I sort of have a feeling someone will tell me there's no good reason to apply this patch, but I wanted to supply it for feedback just in case. -Corey --------------020104030107070004090807 Content-Type: text/plain; name="xvid4_psnr.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="xvid4_psnr.diff" Index: libmpcodecs/ve_xvid4.c =================================================================== --- libmpcodecs/ve_xvid4.c (revision 20015) +++ libmpcodecs/ve_xvid4.c (working copy) @@ -1454,22 +1454,25 @@ "The value 99.99dB is a special value and represents " "the upper range limit\n"); mp_msg(MSGT_MENCODER, MSGL_INFO, - "xvid: Min PSNR y : %.2f dB, u : %.2f dB, v : %.2f dB, in frame %d\n", + "xvid: Min PSNR Y:%.2f, Cb:%.2f, Cr:%.2f, All:%.2f in frame %d\n", SSE2PSNR(mod->max_sse_y, mod->pixels), SSE2PSNR(mod->max_sse_u, mod->pixels/4), SSE2PSNR(mod->max_sse_v, mod->pixels/4), + SSE2PSNR(mod->max_sse_y + mod->max_sse_u + mod->max_sse_v, mod->pixels*1.5), mod->max_framenum); mp_msg(MSGT_MENCODER, MSGL_INFO, - "xvid: Average PSNR y : %.2f dB, u : %.2f dB, v : %.2f dB, for %d frames\n", + "xvid: Average PSNR Y:%.2f, Cb:%.2f, Cr:%.2f, All:%.2f for %d frames\n", SSE2PSNR(mod->sse_y, mod->pixels), SSE2PSNR(mod->sse_u, mod->pixels/4), SSE2PSNR(mod->sse_v, mod->pixels/4), + SSE2PSNR(mod->sse_y + mod->sse_u + mod->sse_v, mod->pixels*1.5), mod->frames); mp_msg(MSGT_MENCODER, MSGL_INFO, - "xvid: Max PSNR y : %.2f dB, u : %.2f dB, v : %.2f dB, in frame %d\n", + "xvid: Max PSNR Y:%.2f, Cb:%.2f, Cr:%.2f, All:%.2f in frame %d\n", SSE2PSNR(mod->min_sse_y, mod->pixels), SSE2PSNR(mod->min_sse_u, mod->pixels/4), SSE2PSNR(mod->min_sse_v, mod->pixels/4), + SSE2PSNR(mod->min_sse_y + mod->min_sse_u + mod->min_sse_v, mod->pixels*1.5), mod->min_framenum); } } --------------020104030107070004090807 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng --------------020104030107070004090807-- From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 00:52:00 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id DCC37126D83 for ; Mon, 2 Oct 2006 00:52:00 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 3DEBC3B1AC; Mon, 2 Oct 2006 00:51:57 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 3FA703B182 for ; Mon, 2 Oct 2006 00:51:55 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 28482-01-6 for ; Mon, 2 Oct 2006 00:51:55 +0200 (CEST) Received: from pne-smtpout4-sn2.hy.skanova.net (pne-smtpout4-sn2.hy.skanova.net [81.228.8.154]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 1C3BB3B15B for ; Mon, 2 Oct 2006 00:51:54 +0200 (CEST) Received: from symbol.nonexistent.fi (80.220.221.236) by pne-smtpout4-sn2.hy.skanova.net (7.2.075) id 44A2EAB8003D3C29 for mplayer-dev-eng@mplayerhq.hu; Mon, 2 Oct 2006 00:51:56 +0200 Subject: Re: [MPlayer-dev-eng] [PATCH] double click to switch to full screen in GUI From: Uoti Urpala To: mplayer-dev-eng@mplayerhq.hu In-Reply-To: <20061001222322.GC2167@biurrun.de> References: <4502FE79.80701@laposte.net> <20060910050021.GC2246@biurrun.de> <4503F73B.6030706@laposte.net> <20060912081334.GD8252@biurrun.de> <4506F479.6050202@laposte.net> <20060913230300.GC2420@biurrun.de> <20060914034028.GA27034@brightrain.aerifal.cx> <4509C56B.5060508@laposte.net> <20060929161656.GC4702@1und1.de> <20061001222322.GC2167@biurrun.de> Content-Type: text/plain Date: Mon, 02 Oct 2006 01:51:56 +0300 Message-Id: <1159743116.11221.142.camel@symbol.nonexistent.fi> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu On Mon, 2006-10-02 at 00:23 +0200, Diego Biurrun wrote: > gtk_settings_get_default'. Some sort of solution is needed. This part > of the code can be dropped, protected by #ifdef or support for GTK 1.x > dropped. GTK1 support should be dropped. It's quite dead. Even if the current features could be supported in GTK1 the GUI sucks as is, and if anyone ever tries to improve it they shouldn't have to deal with GTK1 compatibility. _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 05:25:07 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 2CDFC126D82 for ; Mon, 2 Oct 2006 05:25:07 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 33BC23B22B; Mon, 2 Oct 2006 05:25:02 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id AD2AE3B229 for ; Mon, 2 Oct 2006 05:24:59 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 28455-03 for ; Mon, 2 Oct 2006 05:24:59 +0200 (CEST) Received: from ns.live555.com (ns.live555.com [66.80.62.34]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 0E1363B223 for ; Mon, 2 Oct 2006 05:24:54 +0200 (CEST) Received: from ns.live555.com (localhost.live555.com [127.0.0.1]) by ns.live555.com (8.13.6/8.13.6) with ESMTP id k923OtKo045152 for ; Sun, 1 Oct 2006 20:24:55 -0700 (PDT) (envelope-from rsf@ns.live555.com) Received: (from rsf@localhost) by ns.live555.com (8.13.6/8.13.6/Submit) id k923OsQ4045142; Sun, 1 Oct 2006 20:24:54 -0700 (PDT) (envelope-from rsf) Mime-Version: 1.0 Message-Id: In-Reply-To: <20061001173523.GD2112@biurrun.de> References: <20061001173523.GD2112@biurrun.de> Date: Sun, 1 Oct 2006 20:24:42 -0700 To: mplayer-dev-eng@mplayerhq.hu From: Ross Finlayson Subject: Re: [MPlayer-dev-eng] [PATCH] avc1 in X-QT over RTSP Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu At 7:35 PM +0200 10/1/06, Diego Biurrun wrote: >On Wed, Sep 27, 2006 at 12:45:59AM +0000, Carl Eugen Hoyos wrote: >> >> Attached patch allows to play avc1 Videos sent over RTSP in subsession > > "X-QUICKTIME". That's the way Apple streams at the moment. Since when? I've never heard of a QuickTime H.264/RTP stream that uses anything other than the IETF standard "video/H264" RTP payload format. >Ross, is this patch OK? I have no idea. I don't know what - if anything - is special about this alleged 'avc1' 'X-QUICKTIME' stream that needs to be handled differently from other 'X-QUICKTIME' (or 'X-QT') stream. I originally wrote that part of the code with the intention/hope that it work the same for all such streams. -- Ross Finlayson Live Networks, Inc. http://www.live555.com/ _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 09:57:27 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id B0702126D82 for ; Mon, 2 Oct 2006 09:57:27 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 073B13B1EC; Mon, 2 Oct 2006 09:57:26 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 9AA463B1CE for ; Mon, 2 Oct 2006 09:57:24 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 00304-01-4 for ; Mon, 2 Oct 2006 09:57:24 +0200 (CEST) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.171]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 665E63B1AB for ; Mon, 2 Oct 2006 09:57:24 +0200 (CEST) Received: by ug-out-1314.google.com with SMTP id h2so524717ugf for ; Mon, 02 Oct 2006 00:57:24 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=fRZ6QIjZ0nG1Ac5g9nz19O9nCoGIwUrX2+Mwwjim0Wv0EN0MPRKRRayFhMbp/N6nk+NgAVd5Zr5xeZvkI/FJkTQdyolZ6HRk4fXsI+R5Tty2uPCA0uTZMLy2UDTdOdAHYVjsoDz+U4ZjuvzG/aE0uksc2eGFLv5vSG4qfZlcMr8= Received: by 10.67.93.7 with SMTP id v7mr2567163ugl; Mon, 02 Oct 2006 00:57:24 -0700 (PDT) Received: by 10.66.222.2 with HTTP; Mon, 2 Oct 2006 00:57:23 -0700 (PDT) Message-ID: <4e03026a0610020057i278bd940q3108c20a145bfb4d@mail.gmail.com> Date: Mon, 2 Oct 2006 09:57:23 +0200 From: "Guillaume POIRIER" To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] [PATCH] add support for latest x264 options In-Reply-To: <20061001222810.GD2167@biurrun.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_12582_1948246.1159775843632" References: <4e03026a0610011331y5d72f90dt5093abb14fbbbdb0@mail.gmail.com> <20061001222810.GD2167@biurrun.de> X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu ------=_Part_12582_1948246.1159775843632 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, On 10/2/06, Diego Biurrun wrote: > On Sun, Oct 01, 2006 at 10:31:35PM +0200, Guillaume POIRIER wrote: > > > > Please review. > > > > --- DOCS/man/en/mplayer.1 (r??vision 20015) > > +++ DOCS/man/en/mplayer.1 (copie de travail) > > @@ -9270,6 +9270,10 @@ > > .RE > > . > > .TP > > +.B (no)interlaced > > +enable pure-interlaced mode > > Capitalize, add period. > > > @@ -9433,6 +9451,16 @@ > > .TP > > +.B deadzone_inter=<0\-32> > > +set the size of the inter luma quantization deadzone for non-trellis > > +quantization (default: 21) > > dito > > > +.B deadzone_intra=<0\-32> > > +set the size of the intra luma quantization deadzone for non-trellis > > +quantization (default: 11) > > dito Updated patch applied. Note once again that I really hope the description can be improved. I'll try to gather some more information about these features so that the user can understand what they are meant for. Guillaume -- With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has a lead on USA on selling out individuals right to corporations! Vive la France! ------=_Part_12582_1948246.1159775843632 Content-Type: text/plain; name=x264-r575-sync.1.diff; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_esskj91x Content-Disposition: attachment; filename="x264-r575-sync.1.diff" SW5kZXg6IGxpYm1wY29kZWNzL3ZlX3gyNjQuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsaWJtcGNvZGVjcy92 ZV94MjY0LmMJKHLDqXZpc2lvbiAyMDAxNSkKKysrIGxpYm1wY29kZWNzL3ZlX3gyNjQuYwkoY29w aWUgZGUgdHJhdmFpbCkKQEAgLTEyMCw2ICsxMjAsMTAgQEAKIHN0YXRpYyBjaGFyICpjcW04aXkg PSBOVUxMOwogc3RhdGljIGNoYXIgKmNxbThweSA9IE5VTEw7CiBzdGF0aWMgaW50IGdsb2JhbGhl YWRlcj0wOworc3RhdGljIGludCBkaXJlY3RfOHg4ID0gLTE7CitzdGF0aWMgaW50IGRlYWR6b25l X2ludGVyID0gMjE7CitzdGF0aWMgaW50IGRlYWR6b25lX2ludHJhID0gMTE7CitzdGF0aWMgaW50 IGludGVybGFjZWQgPSAwOwogCiBtX29wdGlvbl90IHgyNjRlbmNvcHRzX2NvbmZbXSA9IHsKICAg ICB7ImJpdHJhdGUiLCAmYml0cmF0ZSwgQ09ORl9UWVBFX0lOVCwgQ09ORl9SQU5HRSwgMCwgMjQw MDAwMDAsIE5VTEx9LApAQCAtMjA3LDYgKzIxMSwxMSBAQAogICAgIHsibm92aXN1YWxpemUiLCAm dmlzdWFsaXplLCBDT05GX1RZUEVfRkxBRywgMCwgMSwgMCwgTlVMTH0sCiAgICAgeyJnbG9iYWwi LCAmZ2xvYmFsaGVhZGVyLCBDT05GX1RZUEVfRkxBRywgMCwgMCwgMSwgTlVMTH0sCiAgICAgeyJu b2dsb2JhbCIsICZnbG9iYWxoZWFkZXIsIENPTkZfVFlQRV9GTEFHLCAwLCAxLCAwLCBOVUxMfSwK KyAgICB7ImRpcmVjdF84eDgiLCAmZGlyZWN0Xzh4OCwgQ09ORl9UWVBFX0lOVCwgQ09ORl9SQU5H RSwgLTEsIDEsIE5VTEx9LAorICAgIHsiZGVhZHpvbmVfaW50ZXIiLCAmZGVhZHpvbmVfaW50ZXIs IENPTkZfVFlQRV9JTlQsIENPTkZfUkFOR0UsIDAsIDMyLCBOVUxMfSwKKyAgICB7ImRlYWR6b25l X2ludHJhIiwgJmRlYWR6b25lX2ludHJhLCBDT05GX1RZUEVfSU5ULCBDT05GX1JBTkdFLCAwLCAz MiwgTlVMTH0sCisgICAgeyJpbnRlcmxhY2VkIiwgJmludGVybGFjZWQsIENPTkZfVFlQRV9GTEFH LCAwLCAwLCAxLCBOVUxMfSwKKyAgICB7Im5vaW50ZXJsYWNlZCIsICZpbnRlcmxhY2VkLCBDT05G X1RZUEVfRkxBRywgMCwgMCwgMCwgTlVMTH0sCiAgICAge05VTEwsIE5VTEwsIDAsIDAsIDAsIDAs IE5VTEx9CiB9OwogCkBAIC0zNDIsNiArMzUxLDEwIEBACiAgICAgbW9kLT5wYXJhbS52dWkuaV9z YXJfaGVpZ2h0ID0gZF9oZWlnaHQqd2lkdGg7CiAgICAgbW9kLT5wYXJhbS5pX3RocmVhZHMgPSB0 aHJlYWRzOwogICAgIGlmKGdsb2JhbGhlYWRlcikgbW9kLT5wYXJhbS5iX3JlcGVhdF9oZWFkZXJz ID0gMDsKKyAgICBtb2QtPnBhcmFtLmFuYWx5c2UuaV9kaXJlY3RfOHg4X2luZmVyZW5jZSA9IGRp cmVjdF84eDg7CisgICAgbW9kLT5wYXJhbS5iX2ludGVybGFjZWQgPSBpbnRlcmxhY2VkOworICAg IG1vZC0+cGFyYW0uYW5hbHlzZS5pX2x1bWFfZGVhZHpvbmVbMF0gPSBkZWFkem9uZV9pbnRlcjsK KyAgICBtb2QtPnBhcmFtLmFuYWx5c2UuaV9sdW1hX2RlYWR6b25lWzFdID0gZGVhZHpvbmVfaW50 cmE7CiAKICAgICBpZihjcW0gIT0gTlVMTCkKICAgICB7CkluZGV4OiBET0NTL21hbi9lbi9tcGxh eWVyLjEKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gRE9DUy9tYW4vZW4vbXBsYXllci4xCShyw6l2aXNpb24gMjAw MTUpCisrKyBET0NTL21hbi9lbi9tcGxheWVyLjEJKGNvcGllIGRlIHRyYXZhaWwpCkBAIC05Mjcw LDYgKzkyNzAsMTAgQEAKIC5SRQogLgogLlRQCisuQiAobm8paW50ZXJsYWNlZAorRW5hYmxlIHB1 cmUtaW50ZXJsYWNlZCBtb2RlLgorLgorLlRQCiAuQiBkaXJlY3RfcHJlZD08MFwtMz4KIERldGVy bWluZXMgdGhlIHR5cGUgb2YgbW90aW9uIHByZWRpY3Rpb24gdXNlZCBmb3IgZGlyZWN0IG1hY3Jv YmxvY2tzCiBpbiBCLWZyYW1lcy4KQEAgLTkyOTQsNiArOTI5OCwyMCBAQAogLlJFCiAuCiAuVFAK Ky5CIGRpcmVjdF84eDg9PC0xXC0xPgorZGlyZWN0IHByZWRpY3Rpb24gc2l6ZQorLlBEIDAKKy5S U3MKKy5JUHMgLTEKK3NtYWxsZXN0IHBvc3NpYmxlIGFjY29yZGluZyB0byBsZXZlbCAoZGVmYXVs dCkKKy5JUHMgMAorNHg0CisuSVBzIDEKKzh4OAorLlJFCisuUEQgMQorLgorLlRQCiAuQiAobm8p d2VpZ2h0X2IKIFVzZSB3ZWlnaHRlZCBwcmVkaWN0aW9uIGluIEItZnJhbWVzLgogV2l0aG91dCB0 aGlzIG9wdGlvbiwgYmlkaXJlY3Rpb25hbGx5IHByZWRpY3RlZCBtYWNyb2Jsb2NrcyBnaXZlCkBA IC05NDMzLDYgKzk0NTEsMTYgQEAKIFRoaXMgb3B0aW9uIGhhcyBubyBlZmZlY3Qgd2l0aG91dCBC LWZyYW1lcy4KIC4KIC5UUAorLkIgZGVhZHpvbmVfaW50ZXI9PDBcLTMyPgorU2V0IHRoZSBzaXpl IG9mIHRoZSBpbnRlciBsdW1hIHF1YW50aXphdGlvbiBkZWFkem9uZSBmb3Igbm9uLXRyZWxsaXMK K3F1YW50aXphdGlvbiAoZGVmYXVsdDogMjEpLgorLgorLlRQCisuQiBkZWFkem9uZV9pbnRyYT08 MFwtMzI+CitTZXQgdGhlIHNpemUgb2YgdGhlIGludHJhIGx1bWEgcXVhbnRpemF0aW9uIGRlYWR6 b25lIGZvciBub24tdHJlbGxpcworcXVhbnRpemF0aW9uIChkZWZhdWx0OiAxMSkuCisuCisuVFAK IC5CIHRyZWxsaXM9PDBcLTI+CiByYXRlLWRpc3RvcnRpb24gb3B0aW1hbCBxdWFudGl6YXRpb24K IC5QRCAwCg== ------=_Part_12582_1948246.1159775843632 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng ------=_Part_12582_1948246.1159775843632-- From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 10:56:55 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 74670126D92 for ; Mon, 2 Oct 2006 10:56:55 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 0DEF73B485; Mon, 2 Oct 2006 10:56:53 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 7610F3B482 for ; Mon, 2 Oct 2006 10:56:50 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 04876-02-2 for ; Mon, 2 Oct 2006 10:56:50 +0200 (CEST) Received: from akuvian.org (unknown [64.71.168.13]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 737EA3B481 for ; Mon, 2 Oct 2006 10:56:49 +0200 (CEST) Received: by akuvian.org (Postfix, from userid 1000) id B429B5563F; Mon, 2 Oct 2006 02:56:47 -0600 (MDT) Received: from localhost (localhost [127.0.0.1]) by akuvian.org (Postfix) with ESMTP id 8F1A459403 for ; Mon, 2 Oct 2006 02:56:47 -0600 (MDT) Date: Mon, 2 Oct 2006 02:56:47 -0600 (MDT) From: Loren Merritt X-X-Sender: loren@akuvian.org To: MPlayer-ML Subject: Re: [MPlayer-dev-eng] [PATCH] add support for all current and future x264 options In-Reply-To: <4e03026a0610011331y5d72f90dt5093abb14fbbbdb0@mail.gmail.com> Message-ID: References: <4e03026a0610011331y5d72f90dt5093abb14fbbbdb0@mail.gmail.com> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="1195380136-657429816-1159779407=:13477" X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1195380136-657429816-1159779407=:13477 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Sun, 1 Oct 2006, Guillaume POIRIER wrote: > Hi there, > Attached patch does $SUBJ. The doc part can be improved I imagine, but > I lack the technical background to do so. Counter proposal: libx264 already contains code to parse options symbolically, no need to duplicate it in mencoder. However, some of the older options didn't use the same names between mencoder and x264cli, so they would have to change. (documentation part not included.) Side-effect: if we do it this way, a failure to parse -x264encopts is a vf_open error rather than a parse error. vf_open errors aren't fatal, so it tries to continue encoding. This should be fixed anyway. --Loren Merritt --1195380136-657429816-1159779407=:13477 Content-Type: TEXT/plain; charset=US-ASCII; name=vex264_param_parse.0.diff Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=vex264_param_parse.0.diff SW5kZXg6IGNvbmZpZ3VyZQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0t IGNvbmZpZ3VyZQkocmV2aXNpb24gMjAwMTYpDQorKysgY29uZmlndXJlCSh3 b3JraW5nIGNvcHkpDQpAQCAtNjUxMSw3ICs2NTExLDcgQEANCiAgIGNhdCA+ ICRUTVBDIDw8IEVPRg0KICNpbmNsdWRlIDxpbnR0eXBlcy5oPg0KICNpbmNs dWRlIDx4MjY0Lmg+DQotI2lmIFgyNjRfQlVJTEQgPCA0OA0KKyNpZiBYMjY0 X0JVSUxEIDwgNTMNCiAjZXJyb3IgV2UgZG8gbm90IHN1cHBvcnQgb2xkIHZl cnNpb25zIG9mIHgyNjQuIEdldCB0aGUgbGF0ZXN0IGZyb20gU1ZOLg0KICNl bmRpZg0KIGludCBtYWluKHZvaWQpIHsgeDI2NF9lbmNvZGVyX29wZW4oKHZv aWQqKTApOyByZXR1cm4gMDsgfQ0KSW5kZXg6IGNmZy1tZW5jb2Rlci5oDQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09DQotLS0gY2ZnLW1lbmNvZGVyLmgJKHJl dmlzaW9uIDIwMDE2KQ0KKysrIGNmZy1tZW5jb2Rlci5oCSh3b3JraW5nIGNv cHkpDQpAQCAtNDMsNyArNDMsNyBAQA0KICNlbmRpZg0KIA0KICNpZiBkZWZp bmVkKEhBVkVfWDI2NCkNCi1leHRlcm4gbV9vcHRpb25fdCB4MjY0ZW5jb3B0 c19jb25mW107DQorZXh0ZXJuIGNoYXIgKngyNjRlbmNvcHRzOw0KICNlbmRp Zg0KIA0KIGV4dGVybiBtX29wdGlvbl90IG51dm9wdHNfY29uZltdOw0KQEAg LTI3MSw3ICsyNzEsNyBAQA0KIAl7Inh2aWRlbmNvcHRzIiwgeHZpZGVuY29w dHNfY29uZiwgQ09ORl9UWVBFX1NVQkNPTkZJRywgQ09ORl9HTE9CQUwsIDAs IDAsIE5VTEx9LA0KICNlbmRpZg0KICNpZiBkZWZpbmVkKEhBVkVfWDI2NCkN Ci0JeyJ4MjY0ZW5jb3B0cyIsIHgyNjRlbmNvcHRzX2NvbmYsIENPTkZfVFlQ RV9TVUJDT05GSUcsIENPTkZfR0xPQkFMLCAwLCAwLCBOVUxMfSwNCisJeyJ4 MjY0ZW5jb3B0cyIsICZ4MjY0ZW5jb3B0cywgQ09ORl9UWVBFX1NUUklORywg Q09ORl9HTE9CQUwsIDAsIDAsIE5VTEx9LA0KICNlbmRpZg0KIA0KIAl7Im51 dm9wdHMiLCAgbnV2b3B0c19jb25mLCBDT05GX1RZUEVfU1VCQ09ORklHLCBD T05GX0dMT0JBTCwgMCwgMCwgTlVMTH0sDQpJbmRleDogbGlibXBjb2RlY3Mv dmVfeDI2NC5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gbGlibXBj b2RlY3MvdmVfeDI2NC5jCShyZXZpc2lvbiAyMDAxNykNCisrKyBsaWJtcGNv ZGVjcy92ZV94MjY0LmMJKHdvcmtpbmcgY29weSkNCkBAIC01NSwxNzggKzU1 LDkgQEANCiB9IGgyNjRfbW9kdWxlX3Q7DQogDQogZXh0ZXJuIGNoYXIqIHBh c3N0bXBmaWxlOw0KLQ0KLXN0YXRpYyBpbnQgYml0cmF0ZSA9IC0xOw0KLXN0 YXRpYyBpbnQgcXBfY29uc3RhbnQgPSAyNjsNCi1zdGF0aWMgaW50IHJmX2Nv bnN0YW50ID0gMDsNCi1zdGF0aWMgaW50IGZyYW1lX3JlZiA9IDE7DQotc3Rh dGljIGludCBrZXlpbnRfbWF4ID0gMjUwOw0KLXN0YXRpYyBpbnQga2V5aW50 X21pbiA9IDI1Ow0KLXN0YXRpYyBpbnQgc2NlbmVjdXRfdGhyZXNob2xkID0g NDA7DQotc3RhdGljIGludCBiZnJhbWUgPSAwOw0KLXN0YXRpYyBpbnQgYmZy YW1lX2FkYXB0aXZlID0gMTsNCi1zdGF0aWMgaW50IGJmcmFtZV9iaWFzID0g MDsNCi1zdGF0aWMgaW50IGJmcmFtZV9weXJhbWlkID0gMDsNCi1zdGF0aWMg aW50IGRlYmxvY2sgPSAxOw0KLXN0YXRpYyBpbnQgZGVibG9ja2FscGhhID0g MDsNCi1zdGF0aWMgaW50IGRlYmxvY2tiZXRhID0gMDsNCi1zdGF0aWMgaW50 IGNhYmFjID0gMTsNCi1zdGF0aWMgaW50IHA0eDRtdiA9IDA7DQotc3RhdGlj IGludCBwOHg4bXYgPSAxOw0KLXN0YXRpYyBpbnQgYjh4OG12ID0gMTsNCi1z dGF0aWMgaW50IGk4eDggPSAxOw0KLXN0YXRpYyBpbnQgaTR4NCA9IDE7DQot c3RhdGljIGludCBkY3Q4ID0gMDsNCi1zdGF0aWMgaW50IGRpcmVjdF9wcmVk ID0gWDI2NF9ESVJFQ1RfUFJFRF9TUEFUSUFMOw0KLXN0YXRpYyBpbnQgd2Vp Z2h0X2IgPSAwOw0KLXN0YXRpYyBpbnQgY2hyb21hX21lID0gMTsNCi1zdGF0 aWMgaW50IG1peGVkX3JlZmVyZW5jZXMgPSAwOw0KLXN0YXRpYyBpbnQgY2hy b21hX3FwX29mZnNldCA9IDA7DQotc3RhdGljIGZsb2F0IGlwX2ZhY3RvciA9 IDEuNDsNCi1zdGF0aWMgZmxvYXQgcGJfZmFjdG9yID0gMS4zOw0KLXN0YXRp YyBmbG9hdCByYXRldG9sID0gMS4wOw0KLXN0YXRpYyBpbnQgdmJ2X21heHJh dGUgPSAwOw0KLXN0YXRpYyBpbnQgdmJ2X2J1ZnNpemUgPSAwOw0KLXN0YXRp YyBmbG9hdCB2YnZfaW5pdCA9IDAuOTsNCi1zdGF0aWMgaW50IHFwX21pbiA9 IDEwOw0KLXN0YXRpYyBpbnQgcXBfbWF4ID0gNTE7DQotc3RhdGljIGludCBx cF9zdGVwID0gMjsNCi1zdGF0aWMgaW50IHBhc3MgPSAwOw0KLXN0YXRpYyBm bG9hdCBxY29tcCA9IDAuNjsNCi1zdGF0aWMgZmxvYXQgcWJsdXIgPSAwLjU7 DQotc3RhdGljIGZsb2F0IGNvbXBsZXhpdHlfYmx1ciA9IDIwOw0KLXN0YXRp YyBjaGFyICpyY19lcSA9ICJibHVyQ3BseF4oMS1xQ29tcCkiOw0KLXN0YXRp YyBjaGFyICp6b25lcyA9IE5VTEw7DQotc3RhdGljIGludCBzdWJxID0gNTsN Ci1zdGF0aWMgaW50IGJmcmFtZV9yZG8gPSAwOw0KLXN0YXRpYyBpbnQgYmlk aXJfbWUgPSAwOw0KLXN0YXRpYyBpbnQgbWVfbWV0aG9kID0gMjsNCi1zdGF0 aWMgaW50IG1lX3JhbmdlID0gMTY7DQotc3RhdGljIGludCB0cmVsbGlzID0g MTsNCi1zdGF0aWMgaW50IGZhc3RfcHNraXAgPSAxOw0KLXN0YXRpYyBpbnQg ZGN0X2RlY2ltYXRlID0gMTsNCi1zdGF0aWMgaW50IG5vaXNlX3JlZHVjdGlv biA9IDA7DQotc3RhdGljIGludCB0aHJlYWRzID0gMTsNCi1zdGF0aWMgaW50 IGxldmVsX2lkYyA9IDUxOw0KLXN0YXRpYyBpbnQgcHNuciA9IDA7DQotc3Rh dGljIGludCBsb2dfbGV2ZWwgPSAyOw0KIHN0YXRpYyBpbnQgdHVyYm8gPSAw Ow0KLXN0YXRpYyBpbnQgdmlzdWFsaXplID0gMDsNCi1zdGF0aWMgY2hhciAq Y3FtID0gTlVMTDsNCi1zdGF0aWMgY2hhciAqY3FtNGl5ID0gTlVMTDsNCi1z dGF0aWMgY2hhciAqY3FtNGljID0gTlVMTDsNCi1zdGF0aWMgY2hhciAqY3Ft NHB5ID0gTlVMTDsNCi1zdGF0aWMgY2hhciAqY3FtNHBjID0gTlVMTDsNCi1z dGF0aWMgY2hhciAqY3FtOGl5ID0gTlVMTDsNCi1zdGF0aWMgY2hhciAqY3Ft OHB5ID0gTlVMTDsNCi1zdGF0aWMgaW50IGdsb2JhbGhlYWRlcj0wOw0KK2No YXIgKngyNjRlbmNvcHRzID0gIiI7DQogDQotbV9vcHRpb25fdCB4MjY0ZW5j b3B0c19jb25mW10gPSB7DQotICAgIHsiYml0cmF0ZSIsICZiaXRyYXRlLCBD T05GX1RZUEVfSU5ULCBDT05GX1JBTkdFLCAwLCAyNDAwMDAwMCwgTlVMTH0s DQotICAgIHsicXBfY29uc3RhbnQiLCAmcXBfY29uc3RhbnQsIENPTkZfVFlQ RV9JTlQsIENPTkZfUkFOR0UsIDAsIDUxLCBOVUxMfSwNCi0gICAgeyJxcCIs ICZxcF9jb25zdGFudCwgQ09ORl9UWVBFX0lOVCwgQ09ORl9SQU5HRSwgMCwg NTEsIE5VTEx9LA0KLSAgICB7ImNyZiIsICZyZl9jb25zdGFudCwgQ09ORl9U WVBFX0lOVCwgQ09ORl9SQU5HRSwgMSwgNTAsIE5VTEx9LA0KLSAgICB7ImZy YW1lcmVmIiwgJmZyYW1lX3JlZiwgQ09ORl9UWVBFX0lOVCwgQ09ORl9SQU5H RSwgMSwgMTYsIE5VTEx9LA0KLSAgICB7ImtleWludCIsICZrZXlpbnRfbWF4 LCBDT05GX1RZUEVfSU5ULCBDT05GX1JBTkdFLCAxLCAyNDAwMDAwMCwgTlVM TH0sDQotICAgIHsia2V5aW50X21pbiIsICZrZXlpbnRfbWluLCBDT05GX1RZ UEVfSU5ULCBDT05GX1JBTkdFLCAxLCAyNDAwMDAwMCwgTlVMTH0sDQotICAg IHsic2NlbmVjdXQiLCAmc2NlbmVjdXRfdGhyZXNob2xkLCBDT05GX1RZUEVf SU5ULCBDT05GX1JBTkdFLCAtMSwgMTAwLCBOVUxMfSwNCi0gICAgeyJiZnJh bWVzIiwgJmJmcmFtZSwgQ09ORl9UWVBFX0lOVCwgQ09ORl9SQU5HRSwgMCwg MTYsIE5VTEx9LA0KLSAgICB7ImJfYWRhcHQiLCAmYmZyYW1lX2FkYXB0aXZl LCBDT05GX1RZUEVfRkxBRywgMCwgMCwgMSwgTlVMTH0sDQotICAgIHsibm9i X2FkYXB0IiwgJmJmcmFtZV9hZGFwdGl2ZSwgQ09ORl9UWVBFX0ZMQUcsIDAs IDEsIDAsIE5VTEx9LA0KLSAgICB7ImJfYmlhcyIsICZiZnJhbWVfYmlhcywg Q09ORl9UWVBFX0lOVCwgQ09ORl9SQU5HRSwgLTEwMCwgMTAwLCBOVUxMfSwN Ci0gICAgeyJiX3B5cmFtaWQiLCAmYmZyYW1lX3B5cmFtaWQsIENPTkZfVFlQ RV9GTEFHLCAwLCAwLCAxLCBOVUxMfSwNCi0gICAgeyJub2JfcHlyYW1pZCIs ICZiZnJhbWVfcHlyYW1pZCwgQ09ORl9UWVBFX0ZMQUcsIDAsIDEsIDAsIE5V TEx9LA0KLSAgICB7ImRlYmxvY2siLCAmZGVibG9jaywgQ09ORl9UWVBFX0ZM QUcsIDAsIDAsIDEsIE5VTEx9LA0KLSAgICB7Im5vZGVibG9jayIsICZkZWJs b2NrLCBDT05GX1RZUEVfRkxBRywgMCwgMSwgMCwgTlVMTH0sDQotICAgIHsi ZGVibG9ja2FscGhhIiwgJmRlYmxvY2thbHBoYSwgQ09ORl9UWVBFX0lOVCwg Q09ORl9SQU5HRSwgLTYsIDYsIE5VTEx9LA0KLSAgICB7ImRlYmxvY2tiZXRh IiwgJmRlYmxvY2tiZXRhLCBDT05GX1RZUEVfSU5ULCBDT05GX1JBTkdFLCAt NiwgNiwgTlVMTH0sDQotICAgIHsiY2FiYWMiLCAmY2FiYWMsIENPTkZfVFlQ RV9GTEFHLCAwLCAwLCAxLCBOVUxMfSwNCi0gICAgeyJub2NhYmFjIiwgJmNh YmFjLCBDT05GX1RZUEVfRkxBRywgMCwgMSwgMCwgTlVMTH0sDQotICAgIHsi NHg0bXYiLCAmcDR4NG12LCBDT05GX1RZUEVfRkxBRywgMCwgMCwgMSwgTlVM TH0sDQotICAgIHsibm80eDRtdiIsICZwNHg0bXYsIENPTkZfVFlQRV9GTEFH LCAwLCAxLCAwLCBOVUxMfSwNCi0gICAgeyI4eDhtdiIsICZwOHg4bXYsIENP TkZfVFlQRV9GTEFHLCAwLCAwLCAxLCBOVUxMfSwNCi0gICAgeyJubzh4OG12 IiwgJnA4eDhtdiwgQ09ORl9UWVBFX0ZMQUcsIDAsIDEsIDAsIE5VTEx9LA0K LSAgICB7ImI4eDhtdiIsICZiOHg4bXYsIENPTkZfVFlQRV9GTEFHLCAwLCAw LCAxLCBOVUxMfSwNCi0gICAgeyJub2I4eDhtdiIsICZiOHg4bXYsIENPTkZf VFlQRV9GTEFHLCAwLCAxLCAwLCBOVUxMfSwNCi0gICAgeyJpNHg0IiwgJmk0 eDQsIENPTkZfVFlQRV9GTEFHLCAwLCAwLCAxLCBOVUxMfSwNCi0gICAgeyJu b2k0eDQiLCAmaTR4NCwgQ09ORl9UWVBFX0ZMQUcsIDAsIDAsIDAsIE5VTEx9 LA0KLSAgICB7Imk4eDgiLCAmaTh4OCwgQ09ORl9UWVBFX0ZMQUcsIDAsIDAs IDEsIE5VTEx9LA0KLSAgICB7Im5vaTh4OCIsICZpOHg4LCBDT05GX1RZUEVf RkxBRywgMCwgMCwgMCwgTlVMTH0sDQotICAgIHsiOHg4ZGN0IiwgJmRjdDgs IENPTkZfVFlQRV9GTEFHLCAwLCAwLCAxLCBOVUxMfSwNCi0gICAgeyJubzh4 OGRjdCIsICZkY3Q4LCBDT05GX1RZUEVfRkxBRywgMCwgMCwgMCwgTlVMTH0s DQotICAgIHsiZGlyZWN0X3ByZWQiLCAmZGlyZWN0X3ByZWQsIENPTkZfVFlQ RV9JTlQsIENPTkZfUkFOR0UsIDAsIDMsIE5VTEx9LA0KLSAgICB7IndlaWdo dF9iIiwgJndlaWdodF9iLCBDT05GX1RZUEVfRkxBRywgMCwgMCwgMSwgTlVM TH0sDQotICAgIHsibm93ZWlnaHRfYiIsICZ3ZWlnaHRfYiwgQ09ORl9UWVBF X0ZMQUcsIDAsIDEsIDAsIE5VTEx9LA0KLSAgICB7ImJpbWUiLCAmYmlkaXJf bWUsIENPTkZfVFlQRV9GTEFHLCAwLCAwLCAxLCBOVUxMfSwNCi0gICAgeyJu b2JpbWUiLCAmYmlkaXJfbWUsIENPTkZfVFlQRV9GTEFHLCAwLCAwLCAwLCBO VUxMfSwNCi0gICAgeyJjaHJvbWFfbWUiLCAmY2hyb21hX21lLCBDT05GX1RZ UEVfRkxBRywgMCwgMCwgMSwgTlVMTH0sDQotICAgIHsibm9jaHJvbWFfbWUi LCAmY2hyb21hX21lLCBDT05GX1RZUEVfRkxBRywgMCwgMSwgMCwgTlVMTH0s DQotICAgIHsibWl4ZWRfcmVmcyIsICZtaXhlZF9yZWZlcmVuY2VzLCBDT05G X1RZUEVfRkxBRywgMCwgMCwgMSwgTlVMTH0sDQotICAgIHsibm9taXhlZF9y ZWZzIiwgJm1peGVkX3JlZmVyZW5jZXMsIENPTkZfVFlQRV9GTEFHLCAwLCAx LCAwLCBOVUxMfSwNCi0gICAgeyJjaHJvbWFfcXBfb2Zmc2V0IiwgJmNocm9t YV9xcF9vZmZzZXQsIENPTkZfVFlQRV9JTlQsIENPTkZfUkFOR0UsIC0xMiwg MTIsIE5VTEx9LA0KLSAgICB7ImlwX2ZhY3RvciIsICZpcF9mYWN0b3IsIENP TkZfVFlQRV9GTE9BVCwgQ09ORl9SQU5HRSwgLTEwLjAsIDEwLjAsIE5VTEx9 LA0KLSAgICB7InBiX2ZhY3RvciIsICZwYl9mYWN0b3IsIENPTkZfVFlQRV9G TE9BVCwgQ09ORl9SQU5HRSwgLTEwLjAsIDEwLjAsIE5VTEx9LA0KLSAgICB7 InJhdGV0b2wiLCAmcmF0ZXRvbCwgQ09ORl9UWVBFX0ZMT0FULCBDT05GX1JB TkdFLCAwLjEsIDEwMC4wLCBOVUxMfSwNCi0gICAgeyJ2YnZfbWF4cmF0ZSIs ICZ2YnZfbWF4cmF0ZSwgQ09ORl9UWVBFX0lOVCwgQ09ORl9SQU5HRSwgMCwg MjQwMDAwMDAsIE5VTEx9LA0KLSAgICB7InZidl9idWZzaXplIiwgJnZidl9i dWZzaXplLCBDT05GX1RZUEVfSU5ULCBDT05GX1JBTkdFLCAwLCAyNDAwMDAw MCwgTlVMTH0sDQotICAgIHsidmJ2X2luaXQiLCAmdmJ2X2luaXQsIENPTkZf VFlQRV9GTE9BVCwgQ09ORl9SQU5HRSwgMC4wLCAxLjAsIE5VTEx9LA0KLSAg ICB7InFwX21pbiIsICZxcF9taW4sIENPTkZfVFlQRV9JTlQsIENPTkZfUkFO R0UsIDEsIDUxLCBOVUxMfSwNCi0gICAgeyJxcF9tYXgiLCAmcXBfbWF4LCBD T05GX1RZUEVfSU5ULCBDT05GX1JBTkdFLCAxLCA1MSwgTlVMTH0sDQotICAg IHsicXBfc3RlcCIsICZxcF9zdGVwLCBDT05GX1RZUEVfSU5ULCBDT05GX1JB TkdFLCAxLCA1MCwgTlVMTH0sDQotICAgIHsicGFzcyIsICZwYXNzLCBDT05G X1RZUEVfSU5ULCBDT05GX1JBTkdFLCAxLCAzLCBOVUxMfSwNCi0gICAgeyJy Y19lcSIsICZyY19lcSwgQ09ORl9UWVBFX1NUUklORywgMCwgMCwgMCwgTlVM TH0sDQotICAgIHsiY3FtIiwgJmNxbSwgQ09ORl9UWVBFX1NUUklORywgMCwg MCwgMCwgTlVMTH0sDQotICAgIHsiY3FtNGl5IiwgJmNxbTRpeSwgQ09ORl9U WVBFX1NUUklORywgMCwgMCwgMCwgTlVMTH0sDQotICAgIHsiY3FtNGljIiwg JmNxbTRpYywgQ09ORl9UWVBFX1NUUklORywgMCwgMCwgMCwgTlVMTH0sDQot ICAgIHsiY3FtNHB5IiwgJmNxbTRweSwgQ09ORl9UWVBFX1NUUklORywgMCwg MCwgMCwgTlVMTH0sDQotICAgIHsiY3FtNHBjIiwgJmNxbTRwYywgQ09ORl9U WVBFX1NUUklORywgMCwgMCwgMCwgTlVMTH0sDQotICAgIHsiY3FtOGl5Iiwg JmNxbThpeSwgQ09ORl9UWVBFX1NUUklORywgMCwgMCwgMCwgTlVMTH0sDQot ICAgIHsiY3FtOHB5IiwgJmNxbThweSwgQ09ORl9UWVBFX1NUUklORywgMCwg MCwgMCwgTlVMTH0sDQotICAgIHsicWNvbXAiLCAmcWNvbXAsIENPTkZfVFlQ RV9GTE9BVCwgQ09ORl9SQU5HRSwgMCwgMSwgTlVMTH0sDQotICAgIHsicWJs dXIiLCAmcWJsdXIsIENPTkZfVFlQRV9GTE9BVCwgQ09ORl9SQU5HRSwgMCwg OTksIE5VTEx9LA0KLSAgICB7ImNwbHhfYmx1ciIsICZjb21wbGV4aXR5X2Js dXIsIENPTkZfVFlQRV9GTE9BVCwgQ09ORl9SQU5HRSwgMCwgOTk5LCBOVUxM fSwNCi0gICAgeyJ6b25lcyIsICZ6b25lcywgQ09ORl9UWVBFX1NUUklORywg MCwgMCwgMCwgTlVMTH0sDQotICAgIHsic3VicSIsICZzdWJxLCBDT05GX1RZ UEVfSU5ULCBDT05GX1JBTkdFLCAxLCA3LCBOVUxMfSwNCi0gICAgeyJicmRv IiwgJmJmcmFtZV9yZG8sIENPTkZfVFlQRV9GTEFHLCAwLCAwLCAxLCBOVUxM fSwNCi0gICAgeyJub2JyZG8iLCAmYmZyYW1lX3JkbywgQ09ORl9UWVBFX0ZM QUcsIDAsIDAsIDAsIE5VTEx9LA0KLSAgICB7Im1lIiwgJm1lX21ldGhvZCwg Q09ORl9UWVBFX0lOVCwgQ09ORl9SQU5HRSwgMSwgNCwgTlVMTH0sDQotICAg IHsibWVfcmFuZ2UiLCAmbWVfcmFuZ2UsIENPTkZfVFlQRV9JTlQsIENPTkZf UkFOR0UsIDQsIDY0LCBOVUxMfSwNCi0gICAgeyJ0cmVsbGlzIiwgJnRyZWxs aXMsIENPTkZfVFlQRV9JTlQsIENPTkZfUkFOR0UsIDAsIDIsIE5VTEx9LA0K LSAgICB7ImZhc3RfcHNraXAiLCAmZmFzdF9wc2tpcCwgQ09ORl9UWVBFX0ZM QUcsIDAsIDAsIDEsIE5VTEx9LA0KLSAgICB7Im5vZmFzdF9wc2tpcCIsICZm YXN0X3Bza2lwLCBDT05GX1RZUEVfRkxBRywgMCwgMCwgMCwgTlVMTH0sDQot ICAgIHsiZGN0X2RlY2ltYXRlIiwgJmRjdF9kZWNpbWF0ZSwgQ09ORl9UWVBF X0ZMQUcsIDAsIDAsIDEsIE5VTEx9LA0KLSAgICB7Im5vZGN0X2RlY2ltYXRl IiwgJmRjdF9kZWNpbWF0ZSwgQ09ORl9UWVBFX0ZMQUcsIDAsIDAsIDAsIE5V TEx9LA0KLSAgICB7Im5yIiwgJm5vaXNlX3JlZHVjdGlvbiwgQ09ORl9UWVBF X0lOVCwgQ09ORl9SQU5HRSwgMCwgMTAwMDAwLCBOVUxMfSwNCi0gICAgeyJs ZXZlbF9pZGMiLCAmbGV2ZWxfaWRjLCBDT05GX1RZUEVfSU5ULCBDT05GX1JB TkdFLCAxMCwgNTEsIE5VTEx9LA0KLSAgICB7InRocmVhZHMiLCAmdGhyZWFk cywgQ09ORl9UWVBFX0lOVCwgQ09ORl9SQU5HRSwgMSwgNCwgTlVMTH0sDQot ICAgIHsicHNuciIsICZwc25yLCBDT05GX1RZUEVfRkxBRywgMCwgMCwgMSwg TlVMTH0sDQotICAgIHsibm9wc25yIiwgJnBzbnIsIENPTkZfVFlQRV9GTEFH LCAwLCAxLCAwLCBOVUxMfSwNCi0gICAgeyJsb2ciLCAmbG9nX2xldmVsLCBD T05GX1RZUEVfSU5ULCBDT05GX1JBTkdFLCAtMSwgMywgTlVMTH0sDQotICAg IHsidHVyYm8iLCAmdHVyYm8sIENPTkZfVFlQRV9JTlQsIENPTkZfUkFOR0Us IDAsIDIsIE5VTEx9LA0KLSAgICB7InZpc3VhbGl6ZSIsICZ2aXN1YWxpemUs IENPTkZfVFlQRV9GTEFHLCAwLCAwLCAxLCBOVUxMfSwNCi0gICAgeyJub3Zp c3VhbGl6ZSIsICZ2aXN1YWxpemUsIENPTkZfVFlQRV9GTEFHLCAwLCAxLCAw LCBOVUxMfSwNCi0gICAgeyJnbG9iYWwiLCAmZ2xvYmFsaGVhZGVyLCBDT05G X1RZUEVfRkxBRywgMCwgMCwgMSwgTlVMTH0sDQotICAgIHsibm9nbG9iYWwi LCAmZ2xvYmFsaGVhZGVyLCBDT05GX1RZUEVfRkxBRywgMCwgMSwgMCwgTlVM TH0sDQotICAgIHtOVUxMLCBOVUxMLCAwLCAwLCAwLCAwLCBOVUxMfQ0KLX07 DQotDQotc3RhdGljIGludCBwYXJzZV9jcW0oY29uc3QgY2hhciAqc3RyLCB1 aW50OF90ICpjcW0sIGludCBsZW5ndGgsDQotICAgICAgICAgICAgICAgICAg ICAgaDI2NF9tb2R1bGVfdCAqbW9kLCBjb25zdCBjaGFyICptYXRyaXhfbmFt ZSkgew0KLSAgICBpbnQgaTsNCi0gICAgaWYgKCFzdHIpIHJldHVybiAwOw0K LSAgICBmb3IgKGkgPSAwOyBpIDwgbGVuZ3RoOyBpKyspIHsNCi0gICAgICAg IGxvbmcgY29lZiA9IHN0cnRvbChzdHIsICZzdHIsIDApOw0KLSAgICAgICAg aWYgKGNvZWYgPCAxIHx8IGNvZWYgPiAyNTUgfHwgc3RyWzBdICE9ICgoaSAr IDEgPT0gbGVuZ3RoKT8wOicsJykpIHsNCi0gICAgICAgICAgICBtcF9tc2co IE1TR1RfTUVOQ09ERVIsIE1TR0xfRVJSLCAieDI2NDogSW52YWxpZCBlbnRy eSBpbiBjcW0lcyBhdCBwb3NpdGlvbiAlZC5cbiIsIG1hdHJpeF9uYW1lLCBp KzEgKTsNCi0gICAgICAgICAgICByZXR1cm4gLTE7DQotICAgICAgICB9DQot ICAgICAgICBjcW1baV0gPSBjb2VmOw0KLSAgICAgICAgc3RyID0gJnN0clsx XTsNCi0gICAgfQ0KLSAgICBtb2QtPnBhcmFtLmlfY3FtX3ByZXNldCA9IFgy NjRfQ1FNX0NVU1RPTTsNCi0gICAgcmV0dXJuIDA7DQotfQ0KLQ0KIHN0YXRp YyBpbnQgZW5jb2RlX25hbHModWludDhfdCAqYnVmLCBpbnQgc2l6ZSwgeDI2 NF9uYWxfdCAqbmFscywgaW50IG5uYWwpew0KICAgICB1aW50OF90ICpwID0g YnVmOw0KICAgICBpbnQgaTsNCkBAIC0yNTEsMTQxICs4Miw1MSBAQA0KICAg ICBtb2QtPm11eC0+YXNwZWN0ID0gKGZsb2F0KWRfd2lkdGgvZF9oZWlnaHQ7 DQogICAgIA0KICAgICB4MjY0X3BhcmFtX2RlZmF1bHQoJm1vZC0+cGFyYW0p Ow0KLSAgICBtb2QtPnBhcmFtLmlfZnJhbWVfcmVmZXJlbmNlID0gZnJhbWVf cmVmOw0KLSAgICBtb2QtPnBhcmFtLmlfa2V5aW50X21heCA9IGtleWludF9t YXg7DQotICAgIG1vZC0+cGFyYW0uaV9rZXlpbnRfbWluID0ga2V5aW50X21p bjsNCi0gICAgbW9kLT5wYXJhbS5pX3NjZW5lY3V0X3RocmVzaG9sZCA9IHNj ZW5lY3V0X3RocmVzaG9sZDsNCi0gICAgbW9kLT5wYXJhbS5pX2JmcmFtZSA9 IGJmcmFtZTsNCi0gICAgbW9kLT5wYXJhbS5iX2JmcmFtZV9hZGFwdGl2ZSA9 IGJmcmFtZV9hZGFwdGl2ZTsNCi0gICAgbW9kLT5wYXJhbS5pX2JmcmFtZV9i aWFzID0gYmZyYW1lX2JpYXM7DQotICAgIG1vZC0+cGFyYW0uYl9iZnJhbWVf cHlyYW1pZCA9IGJmcmFtZV9weXJhbWlkOw0KLSAgICBtb2QtPnBhcmFtLmJf ZGVibG9ja2luZ19maWx0ZXIgPSBkZWJsb2NrOw0KLSAgICBtb2QtPnBhcmFt LmlfZGVibG9ja2luZ19maWx0ZXJfYWxwaGFjMCA9IGRlYmxvY2thbHBoYTsN Ci0gICAgbW9kLT5wYXJhbS5pX2RlYmxvY2tpbmdfZmlsdGVyX2JldGEgPSBk ZWJsb2NrYmV0YTsNCi0gICAgbW9kLT5wYXJhbS5iX2NhYmFjID0gY2FiYWM7 DQogDQotICAgIG1vZC0+cGFyYW0ucmMuaV9yY19tZXRob2QgPSBYMjY0X1JD X0NRUDsNCi0gICAgbW9kLT5wYXJhbS5yYy5pX3FwX2NvbnN0YW50ID0gcXBf Y29uc3RhbnQ7DQotICAgIGlmKHJmX2NvbnN0YW50ID4gMCkNCi0gICAgICAg IG1vZC0+cGFyYW0ucmMuaV9yY19tZXRob2QgPSBYMjY0X1JDX0NSRjsNCi0g ICAgbW9kLT5wYXJhbS5yYy5pX3JmX2NvbnN0YW50ID0gcmZfY29uc3RhbnQ7 DQotICAgIGlmKHFwX21pbiA+IHFwX2NvbnN0YW50KQ0KLSAgICAgICAgcXBf bWluID0gcXBfY29uc3RhbnQ7DQotICAgIGlmKHFwX21heCA8IHFwX2NvbnN0 YW50KQ0KLSAgICAgICAgcXBfbWF4ID0gcXBfY29uc3RhbnQ7DQotICAgIG1v ZC0+cGFyYW0ucmMuaV9xcF9taW4gPSBxcF9taW47DQotICAgIG1vZC0+cGFy YW0ucmMuaV9xcF9tYXggPSBxcF9tYXg7DQotICAgIG1vZC0+cGFyYW0ucmMu aV9xcF9zdGVwID0gcXBfc3RlcDsNCi0gICAgbW9kLT5wYXJhbS5yYy5wc3pf cmNfZXEgPSByY19lcTsNCi0gICAgbW9kLT5wYXJhbS5yYy5mX3Fjb21wcmVz cyA9IHFjb21wOw0KLSAgICBtb2QtPnBhcmFtLnJjLmZfcWJsdXIgPSBxYmx1 cjsNCi0gICAgbW9kLT5wYXJhbS5yYy5mX2NvbXBsZXhpdHlfYmx1ciA9IGNv bXBsZXhpdHlfYmx1cjsNCi0gICAgbW9kLT5wYXJhbS5hbmFseXNlLmlfc3Vi cGVsX3JlZmluZSA9IHN1YnE7DQotICAgIG1vZC0+cGFyYW0ucmMucHN6X3N0 YXRfb3V0ID0gcGFzc3RtcGZpbGU7DQotICAgIG1vZC0+cGFyYW0ucmMucHN6 X3N0YXRfaW4gPSBwYXNzdG1wZmlsZTsNCi0gICAgaWYoKHBhc3MgJiAyKSAm JiBiaXRyYXRlIDw9IDApDQotICAgIHsNCi0gICAgICAgIG1wX21zZyhNU0dU X01FTkNPREVSLCBNU0dMX0VSUiwNCi0gICAgICAgICAgICAgICAiMiBwYXNz IGVuY29kaW5nIGVuYWJsZWQsIGJ1dCBubyBiaXRyYXRlIHNwZWNpZmllZC5c biIpOw0KLSAgICAgICAgcmV0dXJuIDA7DQotICAgIH0NCi0gICAgaWYoYml0 cmF0ZSA+IDApIHsNCi0gICAgICAgIGlmKCh2YnZfbWF4cmF0ZSA+IDApICE9 ICh2YnZfYnVmc2l6ZSA+IDApKSB7DQotICAgICAgICAgICAgbXBfbXNnKE1T R1RfTUVOQ09ERVIsIE1TR0xfRVJSLA0KLSAgICAgICAgICAgICAgICAgICAi VkJWIHJlcXVpcmVzIGJvdGggdmJ2X21heHJhdGUgYW5kIHZidl9idWZzaXpl LlxuIik7DQotICAgICAgICAgICAgcmV0dXJuIDA7DQotICAgICAgICB9DQot ICAgICAgICBtb2QtPnBhcmFtLnJjLmlfcmNfbWV0aG9kID0gWDI2NF9SQ19B QlI7DQotICAgICAgICBtb2QtPnBhcmFtLnJjLmlfYml0cmF0ZSA9IGJpdHJh dGU7DQotICAgICAgICBtb2QtPnBhcmFtLnJjLmZfcmF0ZV90b2xlcmFuY2Ug PSByYXRldG9sOw0KLSAgICAgICAgbW9kLT5wYXJhbS5yYy5pX3Zidl9tYXhf Yml0cmF0ZSA9IHZidl9tYXhyYXRlOw0KLSAgICAgICAgbW9kLT5wYXJhbS5y Yy5pX3Zidl9idWZmZXJfc2l6ZSA9IHZidl9idWZzaXplOw0KLSAgICAgICAg bW9kLT5wYXJhbS5yYy5mX3Zidl9idWZmZXJfaW5pdCA9IHZidl9pbml0Ow0K LSAgICB9DQotICAgIG1vZC0+cGFyYW0ucmMuZl9pcF9mYWN0b3IgPSBpcF9m YWN0b3I7DQotICAgIG1vZC0+cGFyYW0ucmMuZl9wYl9mYWN0b3IgPSBwYl9m YWN0b3I7DQotICAgIG1vZC0+cGFyYW0ucmMucHN6X3pvbmVzID0gem9uZXM7 DQotICAgIHN3aXRjaChtZV9tZXRob2QpIHsNCi0gICAgICAgIGNhc2UgMTog bW9kLT5wYXJhbS5hbmFseXNlLmlfbWVfbWV0aG9kID0gWDI2NF9NRV9ESUE7 IGJyZWFrOw0KLSAgICAgICAgY2FzZSAyOiBtb2QtPnBhcmFtLmFuYWx5c2Uu aV9tZV9tZXRob2QgPSBYMjY0X01FX0hFWDsgYnJlYWs7DQotICAgICAgICBj YXNlIDM6IG1vZC0+cGFyYW0uYW5hbHlzZS5pX21lX21ldGhvZCA9IFgyNjRf TUVfVU1IOyBicmVhazsNCi0gICAgICAgIGNhc2UgNDogbW9kLT5wYXJhbS5h bmFseXNlLmlfbWVfbWV0aG9kID0gWDI2NF9NRV9FU0E7IGJyZWFrOw0KLSAg ICB9DQotICAgIG1vZC0+cGFyYW0uYW5hbHlzZS5pbnRlciA9IDA7DQotICAg IGlmKHA0eDRtdikgbW9kLT5wYXJhbS5hbmFseXNlLmludGVyIHw9IFgyNjRf QU5BTFlTRV9QU1VCOHg4Ow0KLSAgICBpZihwOHg4bXYpIG1vZC0+cGFyYW0u YW5hbHlzZS5pbnRlciB8PSBYMjY0X0FOQUxZU0VfUFNVQjE2eDE2Ow0KLSAg ICBpZihiOHg4bXYpIG1vZC0+cGFyYW0uYW5hbHlzZS5pbnRlciB8PSBYMjY0 X0FOQUxZU0VfQlNVQjE2eDE2Ow0KLSAgICBpZihpNHg0KSAgIG1vZC0+cGFy YW0uYW5hbHlzZS5pbnRlciB8PSBYMjY0X0FOQUxZU0VfSTR4NDsNCi0gICAg aWYoaTh4OCkgICBtb2QtPnBhcmFtLmFuYWx5c2UuaW50ZXIgfD0gWDI2NF9B TkFMWVNFX0k4eDg7DQotICAgIG1vZC0+cGFyYW0uYW5hbHlzZS5iX3RyYW5z Zm9ybV84eDggPSBkY3Q4Ow0KLSAgICBtb2QtPnBhcmFtLmFuYWx5c2UuaV9k aXJlY3RfbXZfcHJlZCA9IGRpcmVjdF9wcmVkOw0KLSAgICBtb2QtPnBhcmFt LmFuYWx5c2UuYl93ZWlnaHRlZF9iaXByZWQgPSB3ZWlnaHRfYjsNCi0gICAg bW9kLT5wYXJhbS5hbmFseXNlLmlfY2hyb21hX3FwX29mZnNldCA9IGNocm9t YV9xcF9vZmZzZXQ7DQotICAgIG1vZC0+cGFyYW0uYW5hbHlzZS5iX2JpZGly X21lID0gYmlkaXJfbWU7DQotICAgIG1vZC0+cGFyYW0uYW5hbHlzZS5iX2No cm9tYV9tZSA9IGNocm9tYV9tZTsNCi0gICAgbW9kLT5wYXJhbS5hbmFseXNl LmJfbWl4ZWRfcmVmZXJlbmNlcyA9IG1peGVkX3JlZmVyZW5jZXM7DQotICAg IG1vZC0+cGFyYW0uYW5hbHlzZS5pX3RyZWxsaXMgPSB0cmVsbGlzOw0KLSAg ICBtb2QtPnBhcmFtLmFuYWx5c2UuYl9mYXN0X3Bza2lwID0gZmFzdF9wc2tp cDsNCi0gICAgbW9kLT5wYXJhbS5hbmFseXNlLmJfZGN0X2RlY2ltYXRlID0g ZGN0X2RlY2ltYXRlOw0KLSAgICBtb2QtPnBhcmFtLmFuYWx5c2UuaV9ub2lz ZV9yZWR1Y3Rpb24gPSBub2lzZV9yZWR1Y3Rpb247DQotICAgIG1vZC0+cGFy YW0uYW5hbHlzZS5iX2JmcmFtZV9yZG8gPSBiZnJhbWVfcmRvOw0KLQ0KICAg ICBtb2QtPnBhcmFtLmlfd2lkdGggPSB3aWR0aDsNCiAgICAgbW9kLT5wYXJh bS5pX2hlaWdodCA9IGhlaWdodDsNCiAgICAgbW9kLT5wYXJhbS5pX2Zwc19u dW0gPSBtb2QtPm11eC0+aC5kd1JhdGU7DQogICAgIG1vZC0+cGFyYW0uaV9m cHNfZGVuID0gbW9kLT5tdXgtPmguZHdTY2FsZTsNCi0gICAgbW9kLT5wYXJh bS5pX2xldmVsX2lkYyA9IGxldmVsX2lkYzsNCi0gICAgbW9kLT5wYXJhbS5h bmFseXNlLmJfcHNuciA9IHBzbnI7DQotICAgIG1vZC0+cGFyYW0uaV9sb2df bGV2ZWwgPSBsb2dfbGV2ZWw7DQotICAgIG1vZC0+cGFyYW0uYl92aXN1YWxp emUgPSB2aXN1YWxpemU7DQogICAgIG1vZC0+cGFyYW0udnVpLmlfc2FyX3dp ZHRoID0gZF93aWR0aCpoZWlnaHQ7DQogICAgIG1vZC0+cGFyYW0udnVpLmlf c2FyX2hlaWdodCA9IGRfaGVpZ2h0KndpZHRoOw0KLSAgICBtb2QtPnBhcmFt LmlfdGhyZWFkcyA9IHRocmVhZHM7DQotICAgIGlmKGdsb2JhbGhlYWRlcikg bW9kLT5wYXJhbS5iX3JlcGVhdF9oZWFkZXJzID0gMDsNCiANCi0gICAgaWYo Y3FtICE9IE5VTEwpDQotICAgIHsNCi0gICAgICAgIGlmKCAhc3RyY21wKGNx bSwgImZsYXQiKSApDQotICAgICAgICAgICAgbW9kLT5wYXJhbS5pX2NxbV9w cmVzZXQgPSBYMjY0X0NRTV9GTEFUOw0KLSAgICAgICAgZWxzZSBpZiggIXN0 cmNtcChjcW0sICJqdnQiKSApDQotICAgICAgICAgICAgbW9kLT5wYXJhbS5p X2NxbV9wcmVzZXQgPSBYMjY0X0NRTV9KVlQ7DQotICAgICAgICBlbHNlDQot ICAgICAgICB7DQotICAgICAgICAgICAgRklMRSAqY3FtX3Rlc3Q7DQotICAg ICAgICAgICAgY3FtX3Rlc3QgPSBmb3BlbiggY3FtLCAicmIiICk7DQotICAg ICAgICAgICAgaWYoIGNxbV90ZXN0ICkNCi0gICAgICAgICAgICB7DQotICAg ICAgICAgICAgICAgIG1vZC0+cGFyYW0uaV9jcW1fcHJlc2V0ID0gWDI2NF9D UU1fQ1VTVE9NOw0KLSAgICAgICAgICAgICAgICBtb2QtPnBhcmFtLnBzel9j cW1fZmlsZSA9IGNxbTsNCi0gICAgICAgICAgICAgICAgZmNsb3NlKCBjcW1f dGVzdCApOw0KLSAgICAgICAgICAgIH0NCi0gICAgICAgICAgICBlbHNlDQot ICAgICAgICAgICAgew0KLSAgICAgICAgICAgICAgICBtcF9tc2coIE1TR1Rf TUVOQ09ERVIsIE1TR0xfRVJSLCAieDI2NDogQ1FNIGZpbGUgZmFpbGVkIHRv IG9wZW4uXG4iICk7DQotICAgICAgICAgICAgICAgIHJldHVybiAwOw0KLSAg ICAgICAgICAgIH0NCisgICAgd2hpbGUoKngyNjRlbmNvcHRzKSB7DQorICAg ICAgICBjaGFyICpuYW1lID0geDI2NGVuY29wdHM7DQorICAgICAgICBjaGFy ICp2YWx1ZTsNCisgICAgICAgIGludCByZXQ7DQorDQorICAgICAgICB4MjY0 ZW5jb3B0cyArPSBzdHJjc3BuKHgyNjRlbmNvcHRzLCAiOiIpOw0KKyAgICAg ICAgaWYoKngyNjRlbmNvcHRzKSB7DQorICAgICAgICAgICAgKngyNjRlbmNv cHRzID0gMDsNCisgICAgICAgICAgICB4MjY0ZW5jb3B0cysrOw0KICAgICAg ICAgfQ0KLSAgICB9DQogDQotICAgIGlmKCAocGFyc2VfY3FtKGNxbTRpeSwg bW9kLT5wYXJhbS5jcW1fNGl5LCAxNiwgbW9kLCAiNGl5IikgPCAwKSB8fA0K LSAgICAgICAgKHBhcnNlX2NxbShjcW00aWMsIG1vZC0+cGFyYW0uY3FtXzRp YywgMTYsIG1vZCwgIjRpYyIpIDwgMCkgfHwNCi0gICAgICAgIChwYXJzZV9j cW0oY3FtNHB5LCBtb2QtPnBhcmFtLmNxbV80cHksIDE2LCBtb2QsICI0cHki KSA8IDApIHx8DQotICAgICAgICAocGFyc2VfY3FtKGNxbTRwYywgbW9kLT5w YXJhbS5jcW1fNHBjLCAxNiwgbW9kLCAiNHBjIikgPCAwKSB8fA0KLSAgICAg ICAgKHBhcnNlX2NxbShjcW04aXksIG1vZC0+cGFyYW0uY3FtXzhpeSwgNjQs IG1vZCwgIjhpeSIpIDwgMCkgfHwNCi0gICAgICAgIChwYXJzZV9jcW0oY3Ft OHB5LCBtb2QtPnBhcmFtLmNxbV84cHksIDY0LCBtb2QsICI4cHkiKSA8IDAp ICkNCi0gICAgICAgIHJldHVybiAwOw0KKyAgICAgICAgdmFsdWUgPSBzdHJj aHIoIG5hbWUsICc9JyApOw0KKyAgICAgICAgaWYodmFsdWUpIHsNCisgICAg ICAgICAgICAqdmFsdWUgPSAwOw0KKyAgICAgICAgICAgIHZhbHVlKys7DQor ICAgICAgICB9DQogDQotICAgIHN3aXRjaChwYXNzKSB7DQotICAgIGNhc2Ug MDoNCi0gICAgICAgIG1vZC0+cGFyYW0ucmMuYl9zdGF0X3dyaXRlID0gMDsN Ci0gICAgICAgIG1vZC0+cGFyYW0ucmMuYl9zdGF0X3JlYWQgPSAwOw0KLSAg ICAgICAgYnJlYWs7DQotICAgIGNhc2UgMToNCisgICAgICAgIGlmKCFzdHJj bXAobmFtZSwgInR1cmJvIikpIHsNCisgICAgICAgICAgICB0dXJibyA9IGF0 b2kodmFsdWUpOw0KKyAgICAgICAgICAgIGNvbnRpbnVlOw0KKyAgICAgICAg fQ0KKw0KKyAgICAgICAgcmV0ID0geDI2NF9wYXJhbV9wYXJzZSgmbW9kLT5w YXJhbSwgbmFtZSwgdmFsdWUpOw0KKyAgICAgICAgaWYocmV0ID09IFgyNjRf UEFSQU1fQkFEX05BTUUpDQorCSAgICBtcF9tc2coTVNHVF9DRkdQQVJTRVIs IE1TR0xfRVJSLCAiT3B0aW9uIHgyNjRlbmNvcHRzOiBVbmtub3duIHN1Ym9w dGlvbiAlc1xuIiwgbmFtZSk7DQorICAgICAgICBpZihyZXQgPT0gWDI2NF9Q QVJBTV9CQURfVkFMVUUpDQorCSAgICBtcF9tc2coTVNHVF9DRkdQQVJTRVIs IE1TR0xfRVJSLCAiT3B0aW9uIHgyNjRlbmNvcHRzOiBCYWQgYXJndW1lbnQg JXM9JXNcbiIsIG5hbWUsIHZhbHVlID8gdmFsdWUgOiAiKG51bGwpIik7DQor ICAgICAgICBpZihyZXQpDQorICAgICAgICAgICAgcmV0dXJuIDA7DQorICAg IH0NCisNCisgICAgaWYobW9kLT5wYXJhbS5yYy5iX3N0YXRfd3JpdGUpIHsN CiAgICAgICAgIC8qIEFkanVzdCBvciBkaXNhYmxlIHNvbWUgZmxhZ3MgdG8g Z2FpbiBzcGVlZCBpbiB0aGUgZmlyc3QgcGFzcyAqLw0KICAgICAgICAgaWYo dHVyYm8gPT0gMSkNCiAgICAgICAgIHsNCi0gICAgICAgICAgICBtb2QtPnBh cmFtLmlfZnJhbWVfcmVmZXJlbmNlID0gKCBmcmFtZV9yZWYgKyAxICkgPj4g MTsNCi0gICAgICAgICAgICBtb2QtPnBhcmFtLmFuYWx5c2UuaV9zdWJwZWxf cmVmaW5lID0gbWF4KCBtaW4oIDMsIHN1YnEgLSAxICksIDEgKTsNCisgICAg ICAgICAgICBtb2QtPnBhcmFtLmlfZnJhbWVfcmVmZXJlbmNlID0gKCBtb2Qt PnBhcmFtLmlfZnJhbWVfcmVmZXJlbmNlICsgMSApID4+IDE7DQorICAgICAg ICAgICAgbW9kLT5wYXJhbS5hbmFseXNlLmlfc3VicGVsX3JlZmluZSA9IG1h eCggbWluKCAzLCBtb2QtPnBhcmFtLmFuYWx5c2UuaV9zdWJwZWxfcmVmaW5l IC0gMSApLCAxICk7DQogICAgICAgICAgICAgbW9kLT5wYXJhbS5hbmFseXNl LmludGVyICY9ICggflgyNjRfQU5BTFlTRV9QU1VCOHg4ICk7DQogICAgICAg ICAgICAgbW9kLT5wYXJhbS5hbmFseXNlLmludGVyICY9ICggflgyNjRfQU5B TFlTRV9CU1VCMTZ4MTYgKTsNCiAgICAgICAgICAgICBtb2QtPnBhcmFtLmFu YWx5c2UuaV90cmVsbGlzID0gMDsNCkBAIC00MDAsMjIgKzE0MSw4IEBADQog ICAgICAgICAgICAgbW9kLT5wYXJhbS5hbmFseXNlLmJfd2VpZ2h0ZWRfYmlw cmVkID0gMDsNCiAgICAgICAgICAgICBtb2QtPnBhcmFtLmFuYWx5c2UuaV90 cmVsbGlzID0gMDsNCiAgICAgICAgIH0NCi0gICAgICAgIG1vZC0+cGFyYW0u cmMuYl9zdGF0X3dyaXRlID0gMTsNCi0gICAgICAgIG1vZC0+cGFyYW0ucmMu Yl9zdGF0X3JlYWQgPSAwOw0KLSAgICAgICAgYnJlYWs7DQotICAgIGNhc2Ug MjoNCi0gICAgICAgIG1vZC0+cGFyYW0ucmMuYl9zdGF0X3dyaXRlID0gMDsN Ci0gICAgICAgIG1vZC0+cGFyYW0ucmMuYl9zdGF0X3JlYWQgPSAxOw0KLSAg ICAgICAgYnJlYWs7DQotICAgIGNhc2UgMzoNCi0gICAgICAgIG1vZC0+cGFy YW0ucmMuYl9zdGF0X3dyaXRlID0gMTsNCi0gICAgICAgIG1vZC0+cGFyYW0u cmMuYl9zdGF0X3JlYWQgPSAxOw0KLSAgICAgICAgYnJlYWs7DQogICAgIH0N CiANCi0gICAgaWYobWVfbWV0aG9kID49IDMpDQotICAgICAgICBtb2QtPnBh cmFtLmFuYWx5c2UuaV9tZV9yYW5nZSA9IG1lX3JhbmdlOw0KLQ0KICAgICBz d2l0Y2gob3V0Zm10KSB7DQogICAgIGNhc2UgSU1HRk1UX0k0MjA6DQogICAg ICAgICBtb2QtPnBhcmFtLmlfY3NwID0gWDI2NF9DU1BfSTQyMDsNCkBAIC00 NjAsNyArMTg3LDcgQEANCiAgICAgICAgIHJldHVybiAwOw0KICAgICB9DQog DQotICAgIGlmKGdsb2JhbGhlYWRlcil7DQorICAgIGlmKCFtb2QtPnBhcmFt LmJfcmVwZWF0X2hlYWRlcnMpew0KICAgICAgICAgdWludDhfdCAqZXh0cmFk YXRhOw0KICAgICAgICAgeDI2NF9uYWxfdCAqbmFsOw0KICAgICAgICAgaW50 IGV4dHJhZGF0YV9zaXplLCBubmFsLCBpLCBzID0gMDsNCkBAIC00ODksOSAr MjE2LDEwIEBADQogDQogc3RhdGljIGludCBjb250cm9sKHN0cnVjdCB2Zl9p bnN0YW5jZV9zKiB2ZiwgaW50IHJlcXVlc3QsIHZvaWQgKmRhdGEpDQogew0K KyAgICBoMjY0X21vZHVsZV90ICptb2Q9KGgyNjRfbW9kdWxlX3QqKXZmLT5w cml2Ow0KICAgICBzd2l0Y2gocmVxdWVzdCl7DQogICAgICAgICBjYXNlIFZG Q1RSTF9GTFVTSF9GUkFNRVM6DQotICAgICAgICAgICAgaWYoYmZyYW1lKQ0K KyAgICAgICAgICAgIGlmKG1vZC0+cGFyYW0uaV9iZnJhbWUpDQogICAgICAg ICAgICAgICAgIHdoaWxlKGVuY29kZV9mcmFtZSh2ZiwgTlVMTCkgPiAwKTsN CiAgICAgICAgICAgICByZXR1cm4gQ09OVFJPTF9UUlVFOw0KICAgICAgICAg ZGVmYXVsdDoNCkBAIC01NTcsNyArMjg1LDggQEANCiAgICAgaWYoaV9zaXpl PjApIHsNCiAgICAgICAgIGludCBrZXlmcmFtZSA9IChwaWNfb3V0LmlfdHlw ZSA9PSBYMjY0X1RZUEVfSURSKSB8fA0KICAgICAgICAgICAgICAgICAgICAg ICAgKHBpY19vdXQuaV90eXBlID09IFgyNjRfVFlQRV9JDQotICAgICAgICAg ICAgICAgICAgICAgICAgJiYgZnJhbWVfcmVmID09IDEgJiYgIWJmcmFtZSk7 DQorICAgICAgICAgICAgICAgICAgICAgICAgJiYgbW9kLT5wYXJhbS5pX2Zy YW1lX3JlZmVyZW5jZSA9PSAxDQorICAgICAgICAgICAgICAgICAgICAgICAg JiYgIW1vZC0+cGFyYW0uaV9iZnJhbWUpOw0KICAgICAgICAgbXV4ZXJfd3Jp dGVfY2h1bmsobW9kLT5tdXgsIGlfc2l6ZSwga2V5ZnJhbWU/MHgxMDowLCBN UF9OT1BUU19WQUxVRSwgTVBfTk9QVFNfVkFMVUUpOw0KICAgICB9DQogICAg IGVsc2UNCg== --1195380136-657429816-1159779407=:13477 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng --1195380136-657429816-1159779407=:13477-- From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 11:01:45 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 6F4AB126D83 for ; Mon, 2 Oct 2006 11:01:45 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 80A5E3B4AC; Mon, 2 Oct 2006 11:01:43 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 33C093B482 for ; Mon, 2 Oct 2006 11:01:42 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 04876-02-17 for ; Mon, 2 Oct 2006 11:01:42 +0200 (CEST) Received: from ciao.gmane.org (main.gmane.org [80.91.229.2]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 134253B47E for ; Mon, 2 Oct 2006 11:01:42 +0200 (CEST) Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GUJg3-0003Hy-UM for mplayer-dev-eng@mplayerhq.hu; Mon, 02 Oct 2006 11:01:32 +0200 Received: from socks.tuwien.ac.at ([192.35.241.134]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 02 Oct 2006 11:01:31 +0200 Received: from cehoyos by socks.tuwien.ac.at with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 02 Oct 2006 11:01:31 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: mplayer-dev-eng@mplayerhq.hu From: Carl Eugen Hoyos Date: Mon, 2 Oct 2006 09:01:20 +0000 (UTC) Lines: 21 Message-ID: References: <20061001173523.GD2112@biurrun.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: main.gmane.org User-Agent: Loom/3.14 (http://gmane.org/) X-Loom-IP: 192.35.241.134 (Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.7) Gecko/20060911 SUSE/1.5.0.7-1.1 Firefox/1.5.0.7) X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu Subject: [MPlayer-dev-eng] Re: [PATCH] avc1 in X-QT over RTSP X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Ross Finlayson live555.com> writes: > At 7:35 PM +0200 10/1/06, Diego Biurrun wrote: > >On Wed, Sep 27, 2006 at 12:45:59AM +0000, Carl Eugen Hoyos wrote: > >> > >> Attached patch allows to play avc1 Videos sent over RTSP in subsession > > > "X-QUICKTIME". That's the way Apple streams at the moment. > > Since when? I've never heard of a QuickTime H.264/RTP stream that > uses anything other than the IETF standard "video/H264" RTP payload > format. http://stream.qtv.apple.com/events/aug/wwdc_2006/m3_wwdc_2006_650_ref.mov (-fps 8 for the 110 stream) The link in the original bugreport still works for me (but not without the patch): rtsp://www.as.huji.ac.il:7070/phys23/Dec_28_1600.mov (-fps 15 is the correct speed.) Carl Eugen _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 11:11:49 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id CB6B0126D82 for ; Mon, 2 Oct 2006 11:11:49 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 7E66F3B4C3; Mon, 2 Oct 2006 11:11:47 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id D53213B4BF for ; Mon, 2 Oct 2006 11:11:45 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 09132-01 for ; Mon, 2 Oct 2006 11:11:45 +0200 (CEST) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.175]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id B1C853B4BC for ; Mon, 2 Oct 2006 11:11:45 +0200 (CEST) Received: by ug-out-1314.google.com with SMTP id h2so529283ugf for ; Mon, 02 Oct 2006 02:11:45 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=uPw8+3QhbtEBl6clDGb/vjVIJ6d1cfE1x+yqKujNou6Pot0UbRjmnUCLSlErDv+E8Gu3ZyqFU9dz3uVjon/Oad3c/2HJSV7zK5CROmfT3nVPhrpg20z1Buj/1zso+HRQq4riHNIUa6JMuUJuqkQ0wUD4MTknCnmsS8hjDR2pT3s= Received: by 10.67.91.6 with SMTP id t6mr2613017ugl; Mon, 02 Oct 2006 02:11:45 -0700 (PDT) Received: by 10.66.222.2 with HTTP; Mon, 2 Oct 2006 02:11:45 -0700 (PDT) Message-ID: <4e03026a0610020211t4062e1f9j202fb66ca32c7a36@mail.gmail.com> Date: Mon, 2 Oct 2006 11:11:45 +0200 From: "Guillaume POIRIER" To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] [PATCH] add support for all current and future x264 options In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4e03026a0610011331y5d72f90dt5093abb14fbbbdb0@mail.gmail.com> X-Google-Sender-Auth: 549214fa2129fc55 X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi, On 10/2/06, Loren Merritt wrote: > On Sun, 1 Oct 2006, Guillaume POIRIER wrote: > > > Hi there, > > Attached patch does $SUBJ. The doc part can be improved I imagine, but > > I lack the technical background to do so. > > Counter proposal: libx264 already contains code to parse options > symbolically, no need to duplicate it in mencoder. > However, some of the older options didn't use the same names between > mencoder and x264cli, so they would have to change. Didn't you add synonym support to x264 a few minutes ago? Maybe it's a stupid proposition, but could mencoder's options be added to x264's parser as synonyms of x264 options? > (documentation part not included.) I can certainly take care of that part. > Side-effect: if we do it this way, a failure to parse -x264encopts is a > vf_open error rather than a parse error. vf_open errors aren't > fatal, so it tries to continue encoding. This should be fixed anyway. :-) In any case, I certainly welcome the idea of using x264's parser to remove the need to duplicate maintenance effort in MEncoder. Guillaume _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 16:40:25 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id B2D54126D92 for ; Mon, 2 Oct 2006 16:40:25 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id AF1F33B1B2; Mon, 2 Oct 2006 16:40:23 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id ADF2F3B1A7 for ; Mon, 2 Oct 2006 16:40:21 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 14777-02-14 for ; Mon, 2 Oct 2006 16:40:21 +0200 (CEST) Received: from mx.republique.smartjog.net (republique.smartjog.net [83.243.17.194]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 9223E3B16D for ; Mon, 2 Oct 2006 16:40:21 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mx.republique.smartjog.net (Postfix) with ESMTP id 34BF1C02E for ; Mon, 2 Oct 2006 16:39:54 +0200 (CEST) Received: from mx.republique.smartjog.net ([127.0.0.1]) by localhost (mail [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 26242-02-8 for ; Mon, 2 Oct 2006 16:39:48 +0200 (CEST) Received: from [192.168.0.75] (bcouduri.republique.smartjog.lan [192.168.0.75]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx.republique.smartjog.net (Postfix) with ESMTP id 74828BFE8 for ; Mon, 2 Oct 2006 16:39:48 +0200 (CEST) Message-ID: <45212422.5020006@smartjog.com> Date: Mon, 02 Oct 2006 16:37:22 +0200 From: Baptiste Coudurier User-Agent: Thunderbird 1.5.0.7 (X11/20060927) MIME-Version: 1.0 To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] mjpeg yuv422 output from mencoder/mplayer References: <200609301246.59119.karolina.lindqvist@kramnet.se> <20060930145816.GA16579@MichaelsNB> <451FD563.4030505@smartjog.com> <20061001161949.GM2852@MichaelsNB> <451FFFE3.3060702@smartjog.com> <20061001194957.GP2852@MichaelsNB> In-Reply-To: <20061001194957.GP2852@MichaelsNB> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at smartjog.com X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Hi Michael Niedermayer wrote: >>>>> [...] >>>> Tried to. I have at least something working in progressive. Problem is >>>> that mpegvideo.c is really hardcoded to 4:2:0 and since DCT on jpeg is >>>> done on 8x8 mb it is quite hard to work around that. >>> hmm lavc mpeg2 video supports 422 encoding over mpegvideo.c ... >>> >>> [...] >> Yes. Mpeg2 macroblocks are orderded right out of encode_mb_internal. >> Output is 8 blocks: 4 luma blocks, 4 chroma blocks in 4:2:2, and stored >> that way. >> >> In mjpeg_encode_mb, you will have 8 blocks while they must be coded 2 >> luma, 2 chroma, in 4:2:2 and 4 others will be on the next line in the >> bitstream. > > what is the problem with coding them like in mpeg2, IIRC the jpeg syntax > is flexible enough ... > > [...] > Indeed, I dig further and sent a patch to ffmpeg-devel. Check it out. -- Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA SMARTJOG S.A. http://www.smartjog.com Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA Phone: +33 1 49966312 _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 16:45:01 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 0E8D0126D82 for ; Mon, 2 Oct 2006 16:45:01 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 236373B1DC; Mon, 2 Oct 2006 16:44:59 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 68A6F3B1C4 for ; Mon, 2 Oct 2006 16:44:56 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 14777-02-27 for ; Mon, 2 Oct 2006 16:44:56 +0200 (CEST) Received: from mail.netfarm.it (unknown [151.1.32.181]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 4E3AF3B19F for ; Mon, 2 Oct 2006 16:44:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.netfarm.it (AMaViS/SpamAssassin) with ESMTP id 8965049C03E for ; Mon, 2 Oct 2006 16:43:59 +0200 (CEST) X-Virus-Scanned: by AMaViS New (Debian) at mail.netfarm.it Received: from mail.netfarm.it ([127.0.0.1]) by localhost (mail.netfarm.it [127.0.0.1]) (amavisd-new, port 10024) with LMTP id icVnnCIVY4dZ for ; Mon, 2 Oct 2006 16:43:55 +0200 (CEST) Received: by mail.netfarm.it (Netfarm MailServer v1.2 [Powered by Postfix], from userid 0) id 5CEB649C0BD; Mon, 2 Oct 2006 16:43:55 +0200 (CEST) Date: Mon, 2 Oct 2006 16:43:55 +0200 From: Gianluigi Tiesi To: mplayer-dev-eng@mplayerhq.hu Message-ID: <20061002144355.GA8708@netfarm.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu Subject: [MPlayer-dev-eng] bug in postprocessing code (vf=pp) X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu Mplayer crashes while using postprocessing code, I've tried some movies, same problem. The system is linux amd64. MPlayer interrupted by signal 6 in module: decode_video Here the stack trace: *** glibc detected *** free(): invalid pointer: 0x0000000000f44ef0 *** Program received signal SIGABRT, Aborted. [Switching to Thread 47122415793712 (LWP 29047)] 0x00002adb88e5c07b in raise () from /lib/libc.so.6 (gdb) bt #0 0x00002adb88e5c07b in raise () from /lib/libc.so.6 #1 0x00002adb88e5d84e in abort () from /lib/libc.so.6 #2 0x00002adb88e92639 in __libc_message () from /lib/libc.so.6 #3 0x00002adb88e991a3 in _int_free () from /lib/libc.so.6 #4 0x00002adb88e9922e in free () from /lib/libc.so.6 #5 0x000000000091b4c1 in av_free (ptr=0xf44ef0) at mem.c:134 #6 0x0000000000920535 in reallocAlign (p=0xf44ef0, alignment=8, size=14976) at postprocess.c:960 #7 0x00000000009205c0 in reallocBuffers (c=0xf44ea0, width=624, height=496, stride=624, qpStride=41) at postprocess.c:972 #8 0x0000000000920893 in pp_get_context (width=624, height=496, cpuCaps=-536870887) at postprocess.c:1017 #9 0x00000000004db6c0 in config (vf=0xdffbc0, width=624, height=496, d_width=662, d_height=496, voflags=0, outfmt=842094169) at vf_pp.c:56 #10 0x00000000004a608a in vf_config_wrapper (vf=0xdffbc0, width=624, height=496, d_width=662, d_height=496, flags=0, outfmt=842094169) at vf.c:623 #11 0x000000000049d6f0 in mpcodecs_config_vo (sh=0xdf9160, w=624, h=496, preferred_outfmt=842094169) at vd.c:309 #12 0x00000000004a1ecf in init_vo (sh=0xdf9160, pix_fmt=PIX_FMT_YUV420P) at vd_ffmpeg.c:486 #13 0x00000000004a2123 in get_buffer (avctx=0xe01180, pic=0xeb58f0) at vd_ffmpeg.c:534 #14 0x000000000063fabf in alloc_picture (s=0xe01540, pic=0xeb58f0, shared=0) at mpegvideo.c:390 #15 0x00000000006446b9 in MPV_frame_start (s=0xe01540, avctx=0xe01180) at mpegvideo.c:1555 #16 0x000000000079aaec in ff_h263_decode_frame (avctx=0xe01180, data=0xe01060, data_size=0x7fff2540c288, buf=0xe9e130 "", buf_size=29158) at h263dec.c:707 #17 0x000000000063d1e5 in avcodec_decode_video (avctx=0xe01180, picture=0xe01060, got_picture_ptr=0x7fff2540c288, buf=0xe9e130 "", buf_size=29158) at utils.c:897 #18 0x00000000004a282d in decode (sh=0xdf9160, data=0xe9e130, len=29158, flags=0) at vd_ffmpeg.c:720 #19 0x000000000049ca31 in decode_video (sh_video=0xdf9160, start=0xe9e130 "", in_size=29158, drop_frame=0, pts=0) at dec_video.c:357 #20 0x000000000041b8e5 in main (argc=2, argv=0x7fff2540dba8) at mplayer.c:4110 if additional infos are needed please let me known. Regards -- Gianluigi Tiesi EDP Project Leader Netfarm S.r.l. - http://www.netfarm.it/ Free Software: http://oss.netfarm.it/ _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng From mplayer-dev-eng-bounces@mplayerhq.hu Mon Oct 2 19:19:29 2006 Return-Path: X-Original-To: itdp@fh-biergarten.de Delivered-To: itdp@localhost Received: from natsuki.mplayerhq.hu (natsuki.mplayerhq.hu [213.144.138.186]) by mail.kliche.org (Postfix) with ESMTP id 00603126D82 for ; Mon, 2 Oct 2006 19:19:29 +0200 (CEST) Received: from natsuki.mplayerhq.hu (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 8F2DE3B1D6; Mon, 2 Oct 2006 19:19:24 +0200 (CEST) X-Original-To: mplayer-dev-eng@mplayerhq.hu Delivered-To: mplayer-dev-eng@mplayerhq.hu Received: from localhost (localhost.localdomain [127.0.0.1]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 3EC663B1D5 for ; Mon, 2 Oct 2006 19:19:21 +0200 (CEST) Received: from natsuki.mplayerhq.hu ([127.0.0.1]) by localhost (natsuki [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 03478-02-6 for ; Mon, 2 Oct 2006 19:19:21 +0200 (CEST) Received: from mofongo.naic.edu (remoto.naic.edu [192.65.176.45]) by natsuki.mplayerhq.hu (Postfix) with ESMTP id 210BE3B1D3 for ; Mon, 2 Oct 2006 19:19:19 +0200 (CEST) Received: from monopoli.naic.edu (monopoli [192.65.176.208]) by mofongo.naic.edu (8.12.8/8.12.8) with ESMTP id k92HJIPQ020978 for ; Mon, 2 Oct 2006 13:19:19 -0400 Received: by monopoli.naic.edu (Postfix, from userid 205) id 1558E468DB7; Mon, 2 Oct 2006 13:19:16 -0400 (AST) Date: Mon, 2 Oct 2006 13:19:16 -0400 From: Giacomo Comes To: mplayer-dev-eng@mplayerhq.hu Message-ID: <20061002171916.GA18792@monopoli.naic.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="4Ckj6UjgE2iN1+kY" Content-Disposition: inline User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at mplayerhq.hu Subject: [MPlayer-dev-eng] [PATCH] encode2mpeglight 0.6.0 X-BeenThere: mplayer-dev-eng@mplayerhq.hu X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mplayer-dev-eng@mplayerhq.hu List-Id: MPlayer development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mplayer-dev-eng-bounces@mplayerhq.hu Errors-To: mplayer-dev-eng-bounces@mplayerhq.hu --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, the attached patch upgrades TOOLS/encode2mpeglight to the latest version. Please somebody apply. Giacomo --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch_light_0.6.0" diff -Nraub mplayer.ori/TOOLS/encode2mpeglight mplayer/TOOLS/encode2mpeglight --- mplayer.ori/TOOLS/encode2mpeglight 2006-09-12 12:07:30.000000000 -0400 +++ mplayer/TOOLS/encode2mpeglight 2006-10-02 13:05:57.000000000 -0400 @@ -1,11 +1,11 @@ #!/bin/bash # -# Version: 0.5.5 +# Version: 0.6.0 # # Licence: GPL # # 2004-05-22 Giacomo Comes -# 2006-01-14 +# 2006-09-29 # # Pourpose: Convert anything MPlayer can play to AVI/VCD/SVCD/DVD mpeg # @@ -43,8 +43,8 @@ # and more, consider to use the full release (http://encode2mpeg.sf.net) # # encode2mpeglight is mainly tested with the stable release of MPlayer, -# I try to make it work with CVS too, but due to the "instable" nature of -# CVS, bugs may suddenly appear. If you find any, please report it to me. +# I try to make it work with SVN too, but due to the "instable" nature of +# SVN, bugs may suddenly appear. If you find any, please report it to me. ############################################################################### ############################################################################### @@ -68,8 +68,8 @@ ############################################################################### ModeText () { echo - echo -e "$PROGNAME defaults to encode2mpeg's Mpeg Mode, the others mode are not" - echo -e "available" + echo "$PROGNAME defaults to encode2mpeg's Mpeg Mode, the others mode are not" + echo "available" } ############################################################################### usage () { @@ -92,20 +92,26 @@ } ############################################################################### mp_identify () { - mplayer -identify -vo null -ao null -nocache "$@" -frames 0 2>/dev/null + mplayer -msglevel identify=6 -vo md5sum:outfile=/dev/null -ao null -nocache -frames 0 "$@" 2>/dev/null +} +############################################################################### +id_find () { + local ID=$1 + shift + mp_identify "$@" | awk -v id=$ID -F= '$1==id{t=$2}END{print t}' } ############################################################################### get_aspect () { - mplayer -vo null -ao null -nocache -frames 4 "$@" 2>/dev/null | sed '/^Movie-Aspect is/!d;s/.*Movie-Aspect is //;s/:.*//' + mplayer -vc -mpegpes, -vo null -ao null -nocache -frames 4 "$@" 2>/dev/null | sed '/^Movie-Aspect is/!d;s/.*Movie-Aspect is //;s/:.*//' } ############################################################################### mlistopt () { mplayer -list-options 2>&1 | awk '$1=="Name"{m=1}{if(m&&$1!="Name"&&$1!=""&&$1!="Total:")print "\""$1"\""}' } ############################################################################### -pre_log () { +do_log () { echo "$1" - WARN="$WARN${WARN:+\n}$1" + ((LG)) && echo "$1" >>"$output".log || WARN="$WARN${WARN:+\n}$1" } ############################################################################### isarg () { @@ -133,7 +139,7 @@ get_abr () { local INFO ABR INFO=$(mp_identify "${MPLAYEROPT[@]}" ${dvddev:+-dvd-device "$dvddev"} "$@" | grep '^ID_') - ABR=$(echo "$INFO" | grep '^ID_AUDIO_BITRATE' | cut -f2 -d=) + ABR=$(echo "$INFO" | grep '^ID_AUDIO_BITRATE' | tail -1 | cut -f2 -d=) case $(echo "$INFO" | grep '^ID_AUDIO_CODEC' | cut -f2 -d=) in dvdpcm) abr=$((abr+ABR/1024)) ;; *) abr=$((abr+ABR/1000)) ;; @@ -164,12 +170,12 @@ elif [[ $1 && ! -d $INSTDOCDIR/html && ! -d $SRCDOCDIR/html ]]; then HTML="http://encode2mpeg.sourceforge.net/html/$1" fi - LIST=(mozilla firefox) + LIST=(mozilla seamonkey firefox) [[ ${HTML:0:1} = / ]] && PREFIX=file:// || PREFIX= for ((i=0;i<${#LIST[*]};i++)); do type ${LIST[i]} &>/dev/null && ${LIST[i]} -remote 'openURL('"$PREFIX$HTML"',new-tab)' 2>/dev/null && return done - LIST=(mozilla firefox opera konqueror epiphany galeon) + LIST=(mozilla firefox seamonkey opera konqueror epiphany galeon) if [[ $BROWSER ]]; then type "$BROWSER" &>/dev/null && LIST=("$BROWSER") || echo "++ WARN: default browser '$BROWSER' not found, using builtin browser list" fi @@ -189,7 +195,7 @@ ############################################################################### #### variables initialization ############################################################################### -abr=;asr=;vbr=;vfr=;videonorm=;frameformat=;output=;audioformat=;mp1=;mp2=;mp3=;ac3=;dts=;lpcm=;normalize=;volume=;multiaudio=;mpegchannels=;quiet=;resume=;blank=;encode=;ofps=;mono=;usesbr=;sbr=;clear=;keep=;frames=;avisplit=;channels=;vcustom=;acustom=;cpu=;interlaced=;mpegaspect=;intra_matrix=;inter_matrix=;fixavi=;mpeg=;crop=;audioid=;dvdaudiolang=;bframes=;firstchap=;lastchap=;dvdtrack=;addchapter=;cdi=;mpegfixaspect=;nowait=;vf=;frameres=;trick=;autocrop=;ac=;afm=;cache=;removecache=;turbo=;dvddev=;srate=;endpos=;fourcc=;menu=;menubg=;dvdtitle=;rotate=;menuvtsbg=;autosync=;telecine=;AFMT=;telesrc=;vcodec=;vrfyumnt=;burniso=;verify=;fixasync=;removedir=;MPGRES=;GOP=;TXTSUBOPT=;usespeed=;testmca=;chconf=;noodml=;pictsrc=;slideaudio=;audioonly=;norc= +abr=;asr=;vbr=;vfr=;videonorm=;frameformat=;output=;audioformat=;mp1=;mp2=;mp3=;ac3=;dts=;lpcm=;aac=;normalize=;volume=;multiaudio=;mpegchannels=;quiet=;resume=;blank=;encode=;ofps=;mono=;usesbr=;sbr=;clear=;keep=;frames=;avisplit=;channels=;vcustom=;acustom=;cpu=;interlaced=;mpegaspect=;intra_matrix=;inter_matrix=;fixavi=;mpeg=;crop=;audioid=;dvdaudiolang=;bframes=;firstchap=;lastchap=;dvdtrack=;addchapter=;cdi=;mpegfixaspect=;nowait=;vf=;frameres=;trick=;autocrop=;afm=;cache=;removecache=;turbo=;dvddev=;srate=;endpos=;fourcc=;menu=;menubg=;dvdtitle=;rotate=;menuvtsbg=;autosync=;telecine=;AFMT=;telesrc=;vcodec=;vrfyumnt=;burniso=;verify=;fixasync=;removedir=;MPGRES=;GOP=;TXTSUBOPT=;usespeed=;testmca=;chconf=;noodml=;pictsrc=;slideaudio=;audioonly=;norc=;rawsub=;vobsubsrc=;af= unset encsid encsdx encsla addsub addsdx addsla savecache txtsub txtsubopts zoom=0 scale=1 @@ -238,6 +244,8 @@ LAVC= WARN= LOG= +LG=0 +SVN=0 MAXFIX=20 timelen=0 ocrsub=0 @@ -406,7 +414,9 @@ shift ;; -n|-video-norm) # - #-set the video norm of the VCD/SVCD/DVD + # set the video norm of the VCD/SVCD/DVD; NTSC is USA standard, + # PAL is European standard and SECAM is French standard; concerning + #-VCD/SVCD/DVD encoding, SECAM is equivalent to PAL case $2 in n|N|ntsc|NTSC) videonorm=n ;; p|P|pal|PAL) videonorm=p ;; @@ -586,9 +596,10 @@ # 5 libavcodec/mp3 # 6 libavcodec/ac3 for m=[2-4] and i>1 turbo is on # 7 toolame/mp2 + # 8 libfaac/aac #- with n=[3-7] b specify the audio bit rate encode=5:3:2 - echo "$2" | grep -qE '^[0-7]:[0-4]:[1-9](,[0-9]+)?$' && encode=$2 + echo "$2" | grep -qE '^[0-8]:[0-4]:[1-9](,[0-9]+)?$' && encode=$2 isarg $1 "$2" $([[ $mpeg ]] && echo mpeg || echo Avi) shift ;; @@ -632,7 +643,8 @@ shift ;; -acustom) # - #-specify a custom set of lame options, use with -encode 2:m:i + # specify a custom set of lame options (with -encode 2:m:i) or faac + #-options (with -encode 8:m:i) acustom=$2 isarg $1 "$2" Avi shift @@ -695,8 +707,8 @@ # fps to use when creating video from pictures, default is 1; if # there is a audio file associated with a picture, the duration of #-the audio file is used - slidefps=$(awk -v a=$2 'BEGIN{printf("%.3f",1/a)}') isarg $1 "$2" images + slidefps=$(awk -v a=$2 'BEGIN{printf("%.3f",1/a)}') shift ;; -slideaudio) #